From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD4C8C43381 for ; Fri, 15 Mar 2019 11:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A361121871 for ; Fri, 15 Mar 2019 11:29:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbfCOL3v (ORCPT ); Fri, 15 Mar 2019 07:29:51 -0400 Received: from mail.netline.ch ([148.251.143.178]:54585 "EHLO netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbfCOL3v (ORCPT ); Fri, 15 Mar 2019 07:29:51 -0400 Received: from localhost (localhost [127.0.0.1]) by netline-mail3.netline.ch (Postfix) with ESMTP id B46272A6054; Fri, 15 Mar 2019 12:29:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at netline-mail3.netline.ch Received: from netline-mail3.netline.ch ([127.0.0.1]) by localhost (netline-mail3.netline.ch [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Cgoj3OPZPoud; Fri, 15 Mar 2019 12:29:47 +0100 (CET) Received: from thor (116.245.63.188.dynamic.wline.res.cust.swisscom.ch [188.63.245.116]) by netline-mail3.netline.ch (Postfix) with ESMTPSA id 1B2A12A6053; Fri, 15 Mar 2019 12:29:46 +0100 (CET) Received: from [::1] by thor with esmtp (Exim 4.92) (envelope-from ) id 1h4l21-0007n0-OY; Fri, 15 Mar 2019 12:29:45 +0100 Subject: Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update To: Boris Brezillon Cc: =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Sean Paul , David Airlie , Daniel Vetter , Linux Kernel Mailing List , dri-devel , Tomasz Figa , "open list:ARM/Rockchip SoC..." , Helen Koike , "list@263.net:IOMMU DRIVERS" , kernel@collabora.com, nicholas.kazlauskas@amd.com, linux-arm-kernel@lists.infradead.org References: <20190312022204.2775-1-helen.koike@collabora.com> <20190312022204.2775-2-helen.koike@collabora.com> <20190312073438.05ad8173@collabora.com> <20190312165243.5b771e4a@collabora.com> <05750143-708b-b84e-af67-82ec6815bd89@daenzer.net> <61b8420e-9b63-b67f-e9a8-fb8a0cb7d219@daenzer.net> <20190315112519.0af4fdc0@collabora.com> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Openpgp: preference=signencrypt Autocrypt: addr=michel@daenzer.net; prefer-encrypt=mutual; keydata= mQGiBDsehS8RBACbsIQEX31aYSIuEKxEnEX82ezMR8z3LG8ktv1KjyNErUX9Pt7AUC7W3W0b LUhu8Le8S2va6hi7GfSAifl0ih3k6Bv1Itzgnd+7ZmSrvCN8yGJaHNQfAevAuEboIb+MaVHo 9EMJj4ikOcRZCmQWw7evu/D9uQdtkCnRY9iJiAGxbwCguBHtpoGMxDOINCr5UU6qt+m4O+UD /355ohBBzzyh49lTj0kTFKr0Ozd20G2FbcqHgfFL1dc1MPyigej2gLga2osu2QY0ObvAGkOu WBi3LTY8Zs8uqFGDC4ZAwMPoFy3yzu3ne6T7d/68rJil0QcdQjzzHi6ekqHuhst4a+/+D23h Za8MJBEcdOhRhsaDVGAJSFEQB1qLBACOs0xN+XblejO35gsDSVVk8s+FUUw3TSWJBfZa3Imp V2U2tBO4qck+wqbHNfdnU/crrsHahjzBjvk8Up7VoY8oT+z03sal2vXEonS279xN2B92Tttr AgwosujguFO/7tvzymWC76rDEwue8TsADE11ErjwaBTs8ZXfnN/uAANgPLQjTWljaGVsIERh ZW56ZXIgPG1pY2hlbEBkYWVuemVyLm5ldD6IXgQTEQIAHgUCQFXxJgIbAwYLCQgHAwIDFQID AxYCAQIeAQIXgAAKCRBaga+OatuyAIrPAJ9ykonXI3oQcX83N2qzCEStLNW47gCeLWm/QiPY jqtGUnnSbyuTQfIySkK5AQ0EOx6FRRAEAJZkcvklPwJCgNiw37p0GShKmFGGqf/a3xZZEpjI qNxzshFRFneZze4f5LhzbX1/vIm5+ZXsEWympJfZzyCmYPw86QcFxyZflkAxHx9LeD+89Elx bw6wT0CcLvSv8ROfU1m8YhGbV6g2zWyLD0/naQGVb8e4FhVKGNY2EEbHgFBrAAMGA/0VktFO CxFBdzLQ17RCTwCJ3xpyP4qsLJH0yCoA26rH2zE2RzByhrTFTYZzbFEid3ddGiHOBEL+bO+2 GNtfiYKmbTkj1tMZJ8L6huKONaVrASFzLvZa2dlc2zja9ZSksKmge5BOTKWgbyepEc5qxSju YsYrX5xfLgTZC5abhhztpYhGBBgRAgAGBQI7HoVFAAoJEFqBr45q27IAlscAn2Ufk2d6/3p4 Cuyz/NX7KpL2dQ8WAJ9UD5JEakhfofed8PSqOM7jOO3LCA== Message-ID: Date: Fri, 15 Mar 2019 12:29:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190315112519.0af4fdc0@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-03-15 11:25 a.m., Boris Brezillon wrote: > On Fri, 15 Mar 2019 11:11:36 +0100 > Michel Dänzer wrote: > >> On 2019-03-14 6:51 p.m., Helen Koike wrote: >>> On 3/14/19 6:15 AM, Michel Dänzer wrote: >>>> On 2019-03-13 7:08 p.m., Helen Koike wrote: >>>>> On 3/13/19 6:58 AM, Michel Dänzer wrote: >>>>>> On 2019-03-13 4:42 a.m., Tomasz Figa wrote: >>>>>>> On Wed, Mar 13, 2019 at 12:52 AM Boris Brezillon >>>>>>> wrote: >>>>>>>> On Tue, 12 Mar 2019 12:34:45 -0300 >>>>>>>> Helen Koike wrote: >>>>>>>>> On 3/12/19 3:34 AM, Boris Brezillon wrote: >>>>>>>>>> On Mon, 11 Mar 2019 23:21:59 -0300 >>>>>>>>>> Helen Koike wrote: >>>>>>>>>> >>>>>>>>>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>>>>>>>>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c >>>>>>>>>>> @@ -912,30 +912,31 @@ static void vop_plane_atomic_async_update(struct drm_plane *plane, >>>>>>>>>>> struct drm_plane_state *new_state) >>>>>>>>>>> { >>>>>>>>>>> struct vop *vop = to_vop(plane->state->crtc); >>>>>>>>>>> - struct drm_plane_state *plane_state; >>>>>>>>>>> + struct drm_framebuffer *old_fb = plane->state->fb; >>>>>>>>>>> >>>>>>>>>>> - plane_state = plane->funcs->atomic_duplicate_state(plane); >>>>>>>>>>> - plane_state->crtc_x = new_state->crtc_x; >>>>>>>>>>> - plane_state->crtc_y = new_state->crtc_y; >>>>>>>>>>> - plane_state->crtc_h = new_state->crtc_h; >>>>>>>>>>> - plane_state->crtc_w = new_state->crtc_w; >>>>>>>>>>> - plane_state->src_x = new_state->src_x; >>>>>>>>>>> - plane_state->src_y = new_state->src_y; >>>>>>>>>>> - plane_state->src_h = new_state->src_h; >>>>>>>>>>> - plane_state->src_w = new_state->src_w; >>>>>>>>>>> - >>>>>>>>>>> - if (plane_state->fb != new_state->fb) >>>>>>>>>>> - drm_atomic_set_fb_for_plane(plane_state, new_state->fb); >>>>>>>>>>> - >>>>>>>>>>> - swap(plane_state, plane->state); >>>>>>>>>>> - >>>>>>>>>>> - if (plane->state->fb && plane->state->fb != new_state->fb) { >>>>>>>>>>> + /* >>>>>>>>>>> + * A scanout can still be occurring, so we can't drop the reference to >>>>>>>>>>> + * the old framebuffer. To solve this we get a reference to old_fb and >>>>>>>>>>> + * set a worker to release it later. >>>>>>>>>> >>>>>>>>>> Hm, doesn't look like an async update to me if we have to wait for the >>>>>>>>>> next VBLANK to happen to get the new content on the screen. Maybe we >>>>>>>>>> should reject async updates when old_fb != new_fb in the rk >>>>>>>>>> ->async_check() hook. >>>>>>>>> >>>>>>>>> Unless I am misunderstanding this, we don't wait here, we just grab a >>>>>>>>> reference to the fb in case it is being still used by the hw, so it >>>>>>>>> doesn't get released prematurely. >>>>>>>> >>>>>>>> I was just reacting to the comment that says the new FB should stay >>>>>>>> around until the next VBLANK event happens. If the FB must stay around >>>>>>>> that probably means the HW is still using, which made me wonder if this >>>>>>>> HW actually supports async update (where async means "update now and >>>>>>>> don't care about about tearing"). Or maybe it takes some time to switch >>>>>>>> to the new FB and waiting for the next VBLANK to release the old FB was >>>>>>>> an easy solution to not wait for the flip to actually happen in >>>>>>>> ->async_update() (which is kind of a combination of async+non-blocking). >>>>>>> >>>>>>> The hardware switches framebuffers on vblank, so whatever framebuffer >>>>>>> is currently being scanned out from needs to stay there until the >>>>>>> hardware switches to the new one in shadow registers. If that doesn't >>>>>>> happen, you get IOMMU faults and the display controller stops working >>>>>>> since we don't have any fault handling currently, just printing a >>>>>>> message. >>>>>> >>>>>> Sounds like your hardware doesn't actually support async flips. It's >>>>>> probably better for the driver not to pretend otherwise. >>>>> >>>>> I think wee need to clarify the meaning of the async_update callback >>>>> (and we should clarify it in the docs). >>>>> >>>>> The way I understand what the async_update callback should do is: don't >>>>> block (i.e. don't wait for the next vblank), >>>> >>>> Note that those are two separate things. "Async flips" are about "don't >>>> wait for vblank", not about "don't block". >>>> >>>> >>>>> and update the hw state at some point with the latest state from the >>>>> last call to async_update. >>>>> >>>>> Which means that: any driver can implement the async_update callback, >>>>> independently if it supports changing its state right away or not. >>>>> If hw supports, async_update can change the hw state right away, if not, >>>>> then changes will be applied in the next vblank (it can even amend the >>>>> pending commit if there is one). >>>>> With this, we can remove all the legacy cursor code to use the >>>>> async_update callback, since async_update can be called 100 times before >>>>> the next vblank, and the latest state will be set to the hw without >>>>> waiting 100 vblanks. >>>>> >>>>> Please, let me know if this is your understanding as well. If not, then >>>>> we need to remodel things. >>>> >>>> While this may make sense for cursor updates, I don't think it does for >>>> async flips. If the flip only actually takes effect during the next >>>> vblank, it doesn't really fit the definition and userspace expectation >>>> of an async flip. It's better to clearly communicate to userspace that >>>> the hardware cannot do async flips, than to pretend it can and fake >>>> them. Userspace has to deal with this anyway, since async flips weren't >>>> always supported in general. >>> >>> What do you think if we separate two concepts here: >>> >>> - amend mode: works like cursor updates, i.e, update the hw state at >>> some point with the latest state from the last call to async_update. No >>> special hardware support is required. >>> >>> - async update: update hw state immediately. This depends if the hw >>> supports it or not. >>> >>> Every async update is an amend, but the opposite is not necessarily true. >>> >>> What do you think if we rename the current async_update to amend_update, >>> and we add a parameter "force_async" to it? (or maybe >>> force_immediate_update?) >>> Then amend_check with force_async=1 would fail if the hardware doesn't >>> support it (we could also add flags in the capabilities to inform >>> userspace the expected behaviour of things and if the hw supports >>> force_sync). >>> >>> Like this, we can implement the cursors using the amend_update (which is >>> now called async_update), and async_flips with amend_update with >>> force_async=1. >> >> Might force_async make sense for cursor updates as well? I thought some >> hardware supported HW cursor updates outside of vblank, but I'm not sure. >> >> Without force_async, are cursor updates always applied to the hardware >> on the next vblank, even if the pending commit is delayed further (e.g. >> because a fence it depends on doesn't signal before vblank)? If cursor >> updates can be delayed beyond the next vblank, that can result in bad >> user experience. > > You mean you have > > 1. sync/regular update pending (waiting on a fence) > 2. async update on top of #1 > > ? Yeah. -- Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A95C43381 for ; Fri, 15 Mar 2019 11:30:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7258E21871 for ; Fri, 15 Mar 2019 11:30:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A2nt5CQ0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7258E21871 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=daenzer.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4yMtCA/EBaHtt+WPyZR1Fvq24J6N5oC2dJeyc4rLZTI=; b=A2nt5CQ0y5zNh/ 3P7uxCLTVDPsb44p2HbTfKKGBCWw+3FRm/ITlq7AWtW2P60F7Sh4avXPD/AB3K+//h4jS5sN+8Mo7 zGgSg5r/PbXyekaDKsIOrf8kEStyz+wTOLY3q7DXr+cuv+agdL9ckovZqTwg4WyNoSE4hpEPxVx+t cb5keAi4NdLX6iyAPjPUbOAfI4K2+7KfJOzbs2aTYLSQYqFBUUI45jadhwh1Q0d7KLsa+pl6/qldS 2ZjZ8BC8W4h/hOAbYAwtpT4qGhaoiwAuKC4IAjxe862hSnNkCtqTozrbEYS3xkcj77Okt4LNu4mVk xZ9URiRfwIvHFczPu7Zw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4l2A-0002Sc-PZ; Fri, 15 Mar 2019 11:29:54 +0000 Received: from mail.netline.ch ([148.251.143.178] helo=netline-mail3.netline.ch) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4l25-0002S3-VW; Fri, 15 Mar 2019 11:29:52 +0000 Received: from localhost (localhost [127.0.0.1]) by netline-mail3.netline.ch (Postfix) with ESMTP id B46272A6054; Fri, 15 Mar 2019 12:29:47 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at netline-mail3.netline.ch Received: from netline-mail3.netline.ch ([127.0.0.1]) by localhost (netline-mail3.netline.ch [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Cgoj3OPZPoud; Fri, 15 Mar 2019 12:29:47 +0100 (CET) Received: from thor (116.245.63.188.dynamic.wline.res.cust.swisscom.ch [188.63.245.116]) by netline-mail3.netline.ch (Postfix) with ESMTPSA id 1B2A12A6053; Fri, 15 Mar 2019 12:29:46 +0100 (CET) Received: from [::1] by thor with esmtp (Exim 4.92) (envelope-from ) id 1h4l21-0007n0-OY; Fri, 15 Mar 2019 12:29:45 +0100 Subject: Re: [PATCH v2 1/5] drm/rockchip: fix fb references in async update To: Boris Brezillon References: <20190312022204.2775-1-helen.koike@collabora.com> <20190312022204.2775-2-helen.koike@collabora.com> <20190312073438.05ad8173@collabora.com> <20190312165243.5b771e4a@collabora.com> <05750143-708b-b84e-af67-82ec6815bd89@daenzer.net> <61b8420e-9b63-b67f-e9a8-fb8a0cb7d219@daenzer.net> <20190315112519.0af4fdc0@collabora.com> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Openpgp: preference=signencrypt Autocrypt: addr=michel@daenzer.net; prefer-encrypt=mutual; keydata= mQGiBDsehS8RBACbsIQEX31aYSIuEKxEnEX82ezMR8z3LG8ktv1KjyNErUX9Pt7AUC7W3W0b LUhu8Le8S2va6hi7GfSAifl0ih3k6Bv1Itzgnd+7ZmSrvCN8yGJaHNQfAevAuEboIb+MaVHo 9EMJj4ikOcRZCmQWw7evu/D9uQdtkCnRY9iJiAGxbwCguBHtpoGMxDOINCr5UU6qt+m4O+UD /355ohBBzzyh49lTj0kTFKr0Ozd20G2FbcqHgfFL1dc1MPyigej2gLga2osu2QY0ObvAGkOu WBi3LTY8Zs8uqFGDC4ZAwMPoFy3yzu3ne6T7d/68rJil0QcdQjzzHi6ekqHuhst4a+/+D23h Za8MJBEcdOhRhsaDVGAJSFEQB1qLBACOs0xN+XblejO35gsDSVVk8s+FUUw3TSWJBfZa3Imp V2U2tBO4qck+wqbHNfdnU/crrsHahjzBjvk8Up7VoY8oT+z03sal2vXEonS279xN2B92Tttr AgwosujguFO/7tvzymWC76rDEwue8TsADE11ErjwaBTs8ZXfnN/uAANgPLQjTWljaGVsIERh ZW56ZXIgPG1pY2hlbEBkYWVuemVyLm5ldD6IXgQTEQIAHgUCQFXxJgIbAwYLCQgHAwIDFQID AxYCAQIeAQIXgAAKCRBaga+OatuyAIrPAJ9ykonXI3oQcX83N2qzCEStLNW47gCeLWm/QiPY jqtGUnnSbyuTQfIySkK5AQ0EOx6FRRAEAJZkcvklPwJCgNiw37p0GShKmFGGqf/a3xZZEpjI qNxzshFRFneZze4f5LhzbX1/vIm5+ZXsEWympJfZzyCmYPw86QcFxyZflkAxHx9LeD+89Elx bw6wT0CcLvSv8ROfU1m8YhGbV6g2zWyLD0/naQGVb8e4FhVKGNY2EEbHgFBrAAMGA/0VktFO CxFBdzLQ17RCTwCJ3xpyP4qsLJH0yCoA26rH2zE2RzByhrTFTYZzbFEid3ddGiHOBEL+bO+2 GNtfiYKmbTkj1tMZJ8L6huKONaVrASFzLvZa2dlc2zja9ZSksKmge5BOTKWgbyepEc5qxSju YsYrX5xfLgTZC5abhhztpYhGBBgRAgAGBQI7HoVFAAoJEFqBr45q27IAlscAn2Ufk2d6/3p4 Cuyz/NX7KpL2dQ8WAJ9UD5JEakhfofed8PSqOM7jOO3LCA== Message-ID: Date: Fri, 15 Mar 2019 12:29:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190315112519.0af4fdc0@collabora.com> Content-Language: en-CA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_042950_313142_F0BC2D7C X-CRM114-Status: GOOD ( 27.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?St=c3=a9phane_Marchesin?= , Sean Paul , David Airlie , Daniel Vetter , Linux Kernel Mailing List , dri-devel , Tomasz Figa , "open list:ARM/Rockchip SoC..." , Helen Koike , "list@263.net:IOMMU DRIVERS" , kernel@collabora.com, nicholas.kazlauskas@amd.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAxOS0wMy0xNSAxMToyNSBhLm0uLCBCb3JpcyBCcmV6aWxsb24gd3JvdGU6Cj4gT24gRnJp LCAxNSBNYXIgMjAxOSAxMToxMTozNiArMDEwMAo+IE1pY2hlbCBEw6RuemVyIDxtaWNoZWxAZGFl bnplci5uZXQ+IHdyb3RlOgo+IAo+PiBPbiAyMDE5LTAzLTE0IDY6NTEgcC5tLiwgSGVsZW4gS29p a2Ugd3JvdGU6Cj4+PiBPbiAzLzE0LzE5IDY6MTUgQU0sIE1pY2hlbCBEw6RuemVyIHdyb3RlOiAg Cj4+Pj4gT24gMjAxOS0wMy0xMyA3OjA4IHAubS4sIEhlbGVuIEtvaWtlIHdyb3RlOiAgCj4+Pj4+ IE9uIDMvMTMvMTkgNjo1OCBBTSwgTWljaGVsIETDpG56ZXIgd3JvdGU6ICAKPj4+Pj4+IE9uIDIw MTktMDMtMTMgNDo0MiBhLm0uLCBUb21hc3ogRmlnYSB3cm90ZTogIAo+Pj4+Pj4+IE9uIFdlZCwg TWFyIDEzLCAyMDE5IGF0IDEyOjUyIEFNIEJvcmlzIEJyZXppbGxvbgo+Pj4+Pj4+IDxib3Jpcy5i cmV6aWxsb25AY29sbGFib3JhLmNvbT4gd3JvdGU6ICAKPj4+Pj4+Pj4gT24gVHVlLCAxMiBNYXIg MjAxOSAxMjozNDo0NSAtMDMwMAo+Pj4+Pj4+PiBIZWxlbiBLb2lrZSA8aGVsZW4ua29pa2VAY29s bGFib3JhLmNvbT4gd3JvdGU6ICAKPj4+Pj4+Pj4+IE9uIDMvMTIvMTkgMzozNCBBTSwgQm9yaXMg QnJlemlsbG9uIHdyb3RlOiAgCj4+Pj4+Pj4+Pj4gT24gTW9uLCAxMSBNYXIgMjAxOSAyMzoyMTo1 OSAtMDMwMAo+Pj4+Pj4+Pj4+IEhlbGVuIEtvaWtlIDxoZWxlbi5rb2lrZUBjb2xsYWJvcmEuY29t PiB3cm90ZToKPj4+Pj4+Pj4+PiAgCj4+Pj4+Pj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPj4+Pj4+Pj4+Pj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+Pj4+Pj4+Pj4+PiBAQCAtOTEyLDMwICs5 MTIsMzEgQEAgc3RhdGljIHZvaWQgdm9wX3BsYW5lX2F0b21pY19hc3luY191cGRhdGUoc3RydWN0 IGRybV9wbGFuZSAqcGxhbmUsCj4+Pj4+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpuZXdfc3RhdGUpCj4+Pj4+Pj4+Pj4+ ICB7Cj4+Pj4+Pj4+Pj4+ICAgIHN0cnVjdCB2b3AgKnZvcCA9IHRvX3ZvcChwbGFuZS0+c3RhdGUt PmNydGMpOwo+Pj4+Pj4+Pj4+PiAtICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0 ZTsKPj4+Pj4+Pj4+Pj4gKyAgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqb2xkX2ZiID0gcGxhbmUt PnN0YXRlLT5mYjsKPj4+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+Pj4gLSAgcGxhbmVfc3RhdGUgPSBwbGFu ZS0+ZnVuY3MtPmF0b21pY19kdXBsaWNhdGVfc3RhdGUocGxhbmUpOwo+Pj4+Pj4+Pj4+PiAtICBw bGFuZV9zdGF0ZS0+Y3J0Y194ID0gbmV3X3N0YXRlLT5jcnRjX3g7Cj4+Pj4+Pj4+Pj4+IC0gIHBs YW5lX3N0YXRlLT5jcnRjX3kgPSBuZXdfc3RhdGUtPmNydGNfeTsKPj4+Pj4+Pj4+Pj4gLSAgcGxh bmVfc3RhdGUtPmNydGNfaCA9IG5ld19zdGF0ZS0+Y3J0Y19oOwo+Pj4+Pj4+Pj4+PiAtICBwbGFu ZV9zdGF0ZS0+Y3J0Y193ID0gbmV3X3N0YXRlLT5jcnRjX3c7Cj4+Pj4+Pj4+Pj4+IC0gIHBsYW5l X3N0YXRlLT5zcmNfeCA9IG5ld19zdGF0ZS0+c3JjX3g7Cj4+Pj4+Pj4+Pj4+IC0gIHBsYW5lX3N0 YXRlLT5zcmNfeSA9IG5ld19zdGF0ZS0+c3JjX3k7Cj4+Pj4+Pj4+Pj4+IC0gIHBsYW5lX3N0YXRl LT5zcmNfaCA9IG5ld19zdGF0ZS0+c3JjX2g7Cj4+Pj4+Pj4+Pj4+IC0gIHBsYW5lX3N0YXRlLT5z cmNfdyA9IG5ld19zdGF0ZS0+c3JjX3c7Cj4+Pj4+Pj4+Pj4+IC0KPj4+Pj4+Pj4+Pj4gLSAgaWYg KHBsYW5lX3N0YXRlLT5mYiAhPSBuZXdfc3RhdGUtPmZiKQo+Pj4+Pj4+Pj4+PiAtICAgICAgICAg IGRybV9hdG9taWNfc2V0X2ZiX2Zvcl9wbGFuZShwbGFuZV9zdGF0ZSwgbmV3X3N0YXRlLT5mYik7 Cj4+Pj4+Pj4+Pj4+IC0KPj4+Pj4+Pj4+Pj4gLSAgc3dhcChwbGFuZV9zdGF0ZSwgcGxhbmUtPnN0 YXRlKTsKPj4+Pj4+Pj4+Pj4gLQo+Pj4+Pj4+Pj4+PiAtICBpZiAocGxhbmUtPnN0YXRlLT5mYiAm JiBwbGFuZS0+c3RhdGUtPmZiICE9IG5ld19zdGF0ZS0+ZmIpIHsKPj4+Pj4+Pj4+Pj4gKyAgLyoK Pj4+Pj4+Pj4+Pj4gKyAgICogQSBzY2Fub3V0IGNhbiBzdGlsbCBiZSBvY2N1cnJpbmcsIHNvIHdl IGNhbid0IGRyb3AgdGhlIHJlZmVyZW5jZSB0bwo+Pj4+Pj4+Pj4+PiArICAgKiB0aGUgb2xkIGZy YW1lYnVmZmVyLiBUbyBzb2x2ZSB0aGlzIHdlIGdldCBhIHJlZmVyZW5jZSB0byBvbGRfZmIgYW5k Cj4+Pj4+Pj4+Pj4+ICsgICAqIHNldCBhIHdvcmtlciB0byByZWxlYXNlIGl0IGxhdGVyLiAgCj4+ Pj4+Pj4+Pj4KPj4+Pj4+Pj4+PiBIbSwgZG9lc24ndCBsb29rIGxpa2UgYW4gYXN5bmMgdXBkYXRl IHRvIG1lIGlmIHdlIGhhdmUgdG8gd2FpdCBmb3IgdGhlCj4+Pj4+Pj4+Pj4gbmV4dCBWQkxBTksg dG8gaGFwcGVuIHRvIGdldCB0aGUgbmV3IGNvbnRlbnQgb24gdGhlIHNjcmVlbi4gTWF5YmUgd2UK Pj4+Pj4+Pj4+PiBzaG91bGQgcmVqZWN0IGFzeW5jIHVwZGF0ZXMgd2hlbiBvbGRfZmIgIT0gbmV3 X2ZiIGluIHRoZSByayAgCj4+Pj4+Pj4+Pj4gLT5hc3luY19jaGVjaygpIGhvb2suICAKPj4+Pj4+ Pj4+Cj4+Pj4+Pj4+PiBVbmxlc3MgSSBhbSBtaXN1bmRlcnN0YW5kaW5nIHRoaXMsIHdlIGRvbid0 IHdhaXQgaGVyZSwgd2UganVzdCBncmFiIGEKPj4+Pj4+Pj4+IHJlZmVyZW5jZSB0byB0aGUgZmIg aW4gY2FzZSBpdCBpcyBiZWluZyBzdGlsbCB1c2VkIGJ5IHRoZSBodywgc28gaXQKPj4+Pj4+Pj4+ IGRvZXNuJ3QgZ2V0IHJlbGVhc2VkIHByZW1hdHVyZWx5LiAgCj4+Pj4+Pj4+Cj4+Pj4+Pj4+IEkg d2FzIGp1c3QgcmVhY3RpbmcgdG8gdGhlIGNvbW1lbnQgdGhhdCBzYXlzIHRoZSBuZXcgRkIgc2hv dWxkIHN0YXkKPj4+Pj4+Pj4gYXJvdW5kIHVudGlsIHRoZSBuZXh0IFZCTEFOSyBldmVudCBoYXBw ZW5zLiBJZiB0aGUgRkIgbXVzdCBzdGF5IGFyb3VuZAo+Pj4+Pj4+PiB0aGF0IHByb2JhYmx5IG1l YW5zIHRoZSBIVyBpcyBzdGlsbCB1c2luZywgd2hpY2ggbWFkZSBtZSB3b25kZXIgaWYgdGhpcwo+ Pj4+Pj4+PiBIVyBhY3R1YWxseSBzdXBwb3J0cyBhc3luYyB1cGRhdGUgKHdoZXJlIGFzeW5jIG1l YW5zICJ1cGRhdGUgbm93IGFuZAo+Pj4+Pj4+PiBkb24ndCBjYXJlIGFib3V0IGFib3V0IHRlYXJp bmciKS4gT3IgbWF5YmUgaXQgdGFrZXMgc29tZSB0aW1lIHRvIHN3aXRjaAo+Pj4+Pj4+PiB0byB0 aGUgbmV3IEZCIGFuZCB3YWl0aW5nIGZvciB0aGUgbmV4dCBWQkxBTksgdG8gcmVsZWFzZSB0aGUg b2xkIEZCIHdhcwo+Pj4+Pj4+PiBhbiBlYXN5IHNvbHV0aW9uIHRvIG5vdCB3YWl0IGZvciB0aGUg ZmxpcCB0byBhY3R1YWxseSBoYXBwZW4gaW4gIAo+Pj4+Pj4+PiAtPmFzeW5jX3VwZGF0ZSgpICh3 aGljaCBpcyBraW5kIG9mIGEgY29tYmluYXRpb24gb2YgYXN5bmMrbm9uLWJsb2NraW5nKS4gIAo+ Pj4+Pj4+Cj4+Pj4+Pj4gVGhlIGhhcmR3YXJlIHN3aXRjaGVzIGZyYW1lYnVmZmVycyBvbiB2Ymxh bmssIHNvIHdoYXRldmVyIGZyYW1lYnVmZmVyCj4+Pj4+Pj4gaXMgY3VycmVudGx5IGJlaW5nIHNj YW5uZWQgb3V0IGZyb20gbmVlZHMgdG8gc3RheSB0aGVyZSB1bnRpbCB0aGUKPj4+Pj4+PiBoYXJk d2FyZSBzd2l0Y2hlcyB0byB0aGUgbmV3IG9uZSBpbiBzaGFkb3cgcmVnaXN0ZXJzLiBJZiB0aGF0 IGRvZXNuJ3QKPj4+Pj4+PiBoYXBwZW4sIHlvdSBnZXQgSU9NTVUgZmF1bHRzIGFuZCB0aGUgZGlz cGxheSBjb250cm9sbGVyIHN0b3BzIHdvcmtpbmcKPj4+Pj4+PiBzaW5jZSB3ZSBkb24ndCBoYXZl IGFueSBmYXVsdCBoYW5kbGluZyBjdXJyZW50bHksIGp1c3QgcHJpbnRpbmcgYQo+Pj4+Pj4+IG1l c3NhZ2UuICAKPj4+Pj4+Cj4+Pj4+PiBTb3VuZHMgbGlrZSB5b3VyIGhhcmR3YXJlIGRvZXNuJ3Qg YWN0dWFsbHkgc3VwcG9ydCBhc3luYyBmbGlwcy4gSXQncwo+Pj4+Pj4gcHJvYmFibHkgYmV0dGVy IGZvciB0aGUgZHJpdmVyIG5vdCB0byBwcmV0ZW5kIG90aGVyd2lzZS4gIAo+Pj4+Pgo+Pj4+PiBJ IHRoaW5rIHdlZSBuZWVkIHRvIGNsYXJpZnkgdGhlIG1lYW5pbmcgb2YgdGhlIGFzeW5jX3VwZGF0 ZSBjYWxsYmFjawo+Pj4+PiAoYW5kIHdlIHNob3VsZCBjbGFyaWZ5IGl0IGluIHRoZSBkb2NzKS4K Pj4+Pj4KPj4+Pj4gVGhlIHdheSBJIHVuZGVyc3RhbmQgd2hhdCB0aGUgYXN5bmNfdXBkYXRlIGNh bGxiYWNrIHNob3VsZCBkbyBpczogZG9uJ3QKPj4+Pj4gYmxvY2sgKGkuZS4gZG9uJ3Qgd2FpdCBm b3IgdGhlIG5leHQgdmJsYW5rKSwgIAo+Pj4+Cj4+Pj4gTm90ZSB0aGF0IHRob3NlIGFyZSB0d28g c2VwYXJhdGUgdGhpbmdzLiAiQXN5bmMgZmxpcHMiIGFyZSBhYm91dCAiZG9uJ3QKPj4+PiB3YWl0 IGZvciB2YmxhbmsiLCBub3QgYWJvdXQgImRvbid0IGJsb2NrIi4KPj4+Pgo+Pj4+ICAKPj4+Pj4g YW5kIHVwZGF0ZSB0aGUgaHcgc3RhdGUgYXQgc29tZSBwb2ludCB3aXRoIHRoZSBsYXRlc3Qgc3Rh dGUgZnJvbSB0aGUKPj4+Pj4gbGFzdCBjYWxsIHRvIGFzeW5jX3VwZGF0ZS4KPj4+Pj4KPj4+Pj4g V2hpY2ggbWVhbnMgdGhhdDogYW55IGRyaXZlciBjYW4gaW1wbGVtZW50IHRoZSBhc3luY191cGRh dGUgY2FsbGJhY2ssCj4+Pj4+IGluZGVwZW5kZW50bHkgaWYgaXQgc3VwcG9ydHMgY2hhbmdpbmcg aXRzIHN0YXRlIHJpZ2h0IGF3YXkgb3Igbm90Lgo+Pj4+PiBJZiBodyBzdXBwb3J0cywgYXN5bmNf dXBkYXRlIGNhbiBjaGFuZ2UgdGhlIGh3IHN0YXRlIHJpZ2h0IGF3YXksIGlmIG5vdCwKPj4+Pj4g dGhlbiBjaGFuZ2VzIHdpbGwgYmUgYXBwbGllZCBpbiB0aGUgbmV4dCB2YmxhbmsgKGl0IGNhbiBl dmVuIGFtZW5kIHRoZQo+Pj4+PiBwZW5kaW5nIGNvbW1pdCBpZiB0aGVyZSBpcyBvbmUpLgo+Pj4+ PiBXaXRoIHRoaXMsIHdlIGNhbiByZW1vdmUgYWxsIHRoZSBsZWdhY3kgY3Vyc29yIGNvZGUgdG8g dXNlIHRoZQo+Pj4+PiBhc3luY191cGRhdGUgY2FsbGJhY2ssIHNpbmNlIGFzeW5jX3VwZGF0ZSBj YW4gYmUgY2FsbGVkIDEwMCB0aW1lcyBiZWZvcmUKPj4+Pj4gdGhlIG5leHQgdmJsYW5rLCBhbmQg dGhlIGxhdGVzdCBzdGF0ZSB3aWxsIGJlIHNldCB0byB0aGUgaHcgd2l0aG91dAo+Pj4+PiB3YWl0 aW5nIDEwMCB2YmxhbmtzLgo+Pj4+Pgo+Pj4+PiBQbGVhc2UsIGxldCBtZSBrbm93IGlmIHRoaXMg aXMgeW91ciB1bmRlcnN0YW5kaW5nIGFzIHdlbGwuIElmIG5vdCwgdGhlbgo+Pj4+PiB3ZSBuZWVk IHRvIHJlbW9kZWwgdGhpbmdzLiAgCj4+Pj4KPj4+PiBXaGlsZSB0aGlzIG1heSBtYWtlIHNlbnNl IGZvciBjdXJzb3IgdXBkYXRlcywgSSBkb24ndCB0aGluayBpdCBkb2VzIGZvcgo+Pj4+IGFzeW5j IGZsaXBzLiBJZiB0aGUgZmxpcCBvbmx5IGFjdHVhbGx5IHRha2VzIGVmZmVjdCBkdXJpbmcgdGhl IG5leHQKPj4+PiB2YmxhbmssIGl0IGRvZXNuJ3QgcmVhbGx5IGZpdCB0aGUgZGVmaW5pdGlvbiBh bmQgdXNlcnNwYWNlIGV4cGVjdGF0aW9uCj4+Pj4gb2YgYW4gYXN5bmMgZmxpcC4gSXQncyBiZXR0 ZXIgdG8gY2xlYXJseSBjb21tdW5pY2F0ZSB0byB1c2Vyc3BhY2UgdGhhdAo+Pj4+IHRoZSBoYXJk d2FyZSBjYW5ub3QgZG8gYXN5bmMgZmxpcHMsIHRoYW4gdG8gcHJldGVuZCBpdCBjYW4gYW5kIGZh a2UKPj4+PiB0aGVtLiBVc2Vyc3BhY2UgaGFzIHRvIGRlYWwgd2l0aCB0aGlzIGFueXdheSwgc2lu Y2UgYXN5bmMgZmxpcHMgd2VyZW4ndAo+Pj4+IGFsd2F5cyBzdXBwb3J0ZWQgaW4gZ2VuZXJhbC4g IAo+Pj4KPj4+IFdoYXQgZG8geW91IHRoaW5rIGlmIHdlIHNlcGFyYXRlIHR3byBjb25jZXB0cyBo ZXJlOgo+Pj4KPj4+IC0gYW1lbmQgbW9kZTogd29ya3MgbGlrZSBjdXJzb3IgdXBkYXRlcywgaS5l LCB1cGRhdGUgdGhlIGh3IHN0YXRlIGF0Cj4+PiBzb21lIHBvaW50IHdpdGggdGhlIGxhdGVzdCBz dGF0ZSBmcm9tIHRoZSBsYXN0IGNhbGwgdG8gYXN5bmNfdXBkYXRlLiBObwo+Pj4gc3BlY2lhbCBo YXJkd2FyZSBzdXBwb3J0IGlzIHJlcXVpcmVkLgo+Pj4KPj4+IC0gYXN5bmMgdXBkYXRlOiB1cGRh dGUgaHcgc3RhdGUgaW1tZWRpYXRlbHkuIFRoaXMgZGVwZW5kcyBpZiB0aGUgaHcKPj4+IHN1cHBv cnRzIGl0IG9yIG5vdC4KPj4+Cj4+PiBFdmVyeSBhc3luYyB1cGRhdGUgaXMgYW4gYW1lbmQsIGJ1 dCB0aGUgb3Bwb3NpdGUgaXMgbm90IG5lY2Vzc2FyaWx5IHRydWUuCj4+Pgo+Pj4gV2hhdCBkbyB5 b3UgdGhpbmsgaWYgd2UgcmVuYW1lIHRoZSBjdXJyZW50IGFzeW5jX3VwZGF0ZSB0byBhbWVuZF91 cGRhdGUsCj4+PiBhbmQgd2UgYWRkIGEgcGFyYW1ldGVyICJmb3JjZV9hc3luYyIgdG8gaXQ/IChv ciBtYXliZQo+Pj4gZm9yY2VfaW1tZWRpYXRlX3VwZGF0ZT8pCj4+PiBUaGVuIGFtZW5kX2NoZWNr IHdpdGggZm9yY2VfYXN5bmM9MSB3b3VsZCBmYWlsIGlmIHRoZSBoYXJkd2FyZSBkb2Vzbid0Cj4+ PiBzdXBwb3J0IGl0ICh3ZSBjb3VsZCBhbHNvIGFkZCBmbGFncyBpbiB0aGUgY2FwYWJpbGl0aWVz IHRvIGluZm9ybQo+Pj4gdXNlcnNwYWNlIHRoZSBleHBlY3RlZCBiZWhhdmlvdXIgb2YgdGhpbmdz IGFuZCBpZiB0aGUgaHcgc3VwcG9ydHMKPj4+IGZvcmNlX3N5bmMpLgo+Pj4KPj4+IExpa2UgdGhp cywgd2UgY2FuIGltcGxlbWVudCB0aGUgY3Vyc29ycyB1c2luZyB0aGUgYW1lbmRfdXBkYXRlICh3 aGljaCBpcwo+Pj4gbm93IGNhbGxlZCBhc3luY191cGRhdGUpLCBhbmQgYXN5bmNfZmxpcHMgd2l0 aCBhbWVuZF91cGRhdGUgd2l0aAo+Pj4gZm9yY2VfYXN5bmM9MS4gIAo+Pgo+PiBNaWdodCBmb3Jj ZV9hc3luYyBtYWtlIHNlbnNlIGZvciBjdXJzb3IgdXBkYXRlcyBhcyB3ZWxsPyBJIHRob3VnaHQg c29tZQo+PiBoYXJkd2FyZSBzdXBwb3J0ZWQgSFcgY3Vyc29yIHVwZGF0ZXMgb3V0c2lkZSBvZiB2 YmxhbmssIGJ1dCBJJ20gbm90IHN1cmUuCj4+Cj4+IFdpdGhvdXQgZm9yY2VfYXN5bmMsIGFyZSBj dXJzb3IgdXBkYXRlcyBhbHdheXMgYXBwbGllZCB0byB0aGUgaGFyZHdhcmUKPj4gb24gdGhlIG5l eHQgdmJsYW5rLCBldmVuIGlmIHRoZSBwZW5kaW5nIGNvbW1pdCBpcyBkZWxheWVkIGZ1cnRoZXIg KGUuZy4KPj4gYmVjYXVzZSBhIGZlbmNlIGl0IGRlcGVuZHMgb24gZG9lc24ndCBzaWduYWwgYmVm b3JlIHZibGFuayk/IElmIGN1cnNvcgo+PiB1cGRhdGVzIGNhbiBiZSBkZWxheWVkIGJleW9uZCB0 aGUgbmV4dCB2YmxhbmssIHRoYXQgY2FuIHJlc3VsdCBpbiBiYWQKPj4gdXNlciBleHBlcmllbmNl Lgo+IAo+IFlvdSBtZWFuIHlvdSBoYXZlCj4gCj4gMS4gc3luYy9yZWd1bGFyIHVwZGF0ZSBwZW5k aW5nICh3YWl0aW5nIG9uIGEgZmVuY2UpCj4gMi4gYXN5bmMgdXBkYXRlIG9uIHRvcCBvZiAjMQo+ IAo+ID8KClllYWguCgoKLS0gCkVhcnRobGluZyBNaWNoZWwgRMOkbnplciAgICAgICAgICAgICAg IHwgICAgICAgICAgICAgIGh0dHBzOi8vd3d3LmFtZC5jb20KTGlicmUgc29mdHdhcmUgZW50aHVz aWFzdCAgICAgICAgICAgICB8ICAgICAgICAgICAgIE1lc2EgYW5kIFggZGV2ZWxvcGVyCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==