From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD060C433EF for ; Thu, 27 Jan 2022 08:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237686AbiA0INi (ORCPT ); Thu, 27 Jan 2022 03:13:38 -0500 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:52388 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231533AbiA0INh (ORCPT ); Thu, 27 Jan 2022 03:13:37 -0500 Received: from [192.168.1.9] (unknown [222.129.35.96]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 0A3D13F165; Thu, 27 Jan 2022 08:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1643271215; bh=hw3lkqK/LDZ3HCWjOQelAYLaXklxekttKsCZttUwteA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GlONunEpY2/s9MVJacq+kLXgcHFQwYHDi/b+yMSnr0XU3dGFOic1B4jc6iGRPrpJh o36B8UpyomY2ZzMgAPc6H76RsvczBbAckEF4MilgywAL6aSZK8tLGGQEryiNt5FkJ9 S9oIFDLuOYQbt1xMh5Gm9/69RyLMBWOLsxwyftgqATgR29cQGyfuV6m4uMGxZ+4viO Tvhv+fI+ZYCHsNG8YmgkFdhUR9grHJ3JJNChzcGsvb5GpYJcA0Ym0gDZ8HOq4QrsY6 1NK9/1eLMpMfc25C3XNq3CB/MY3YHdgSqT/5qh8qTXnZQdXkIRkQc7bVrUtCpbijzG 92IAghEebDMqw== Message-ID: Date: Thu, 27 Jan 2022 16:13:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/3 v3] net: usb: r8152: Check used MAC passthrough address Content-Language: en-US To: Hayes Wang , "Limonciello, Mario" , Henning Schild Cc: Jakub Kicinski , Kai-Heng Feng , Andrew Lunn , Oliver Neukum , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "tiwai@suse.de" References: <20220105151427.8373-1-aaron.ma@canonical.com> <20220110085110.3902b6d4@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <20220111082653.02050070@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <3f258c23-c844-7b48-fffb-2fbf5d6d7475@amd.com> <20220111084348.7e897af9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <2b779fef-459f-79bb-4005-db4fd3fd057f@amd.com> <20220111090648.511e95e8@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <5411b3a0-7e36-fa75-5c5c-eb2fda9273b1@amd.com> <20220112202125.105d4c58@md1za8fc.ad001.siemens.net> <5b94f064bd5c48589ea856f68ac0e930@realtek.com> From: Aaron Ma In-Reply-To: <5b94f064bd5c48589ea856f68ac0e930@realtek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/27/22 16:06, Hayes Wang wrote: > I don't think the feature of MAC passthrough address is maintained > by Realtek. Especially, there is no uniform way about it. The > different companies have to maintain their own ways by themselves. > > Realtek could provide the method of finding out the specific device > for Lenovo. You could check USB OCP 0xD81F bit 3. For example, > > ocp_data = ocp_read_byte(tp, MCU_TYPE_USB, USB_MISC_1); > if (tp->version == RTL_VER_09 && (ocp_data & BIT(3))) { > /* This is the RTL8153B for Lenovo. */ > } > May I use the code from Realtek Outbox driver to implement the MAPT? If so, allow me to write a patch and send here to review. Thanks, Aaron > Best Regards, > Hayes