All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Martin Wilck <Martin.Wilck@suse.com>,
	Himanshu Madhani <hmadhani@marvell.com>,
	Michael Hernandez <mhernandez@marvell.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: James Bottomley <jejb@linux.vnet.ibm.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] scsi: qla2xxx: don't use zero for FC4_PRIORITY_NVME
Date: Thu, 7 Nov 2019 13:36:20 -0800	[thread overview]
Message-ID: <e5425bd0-6cb6-81ff-e8af-5392454b72a1@acm.org> (raw)
In-Reply-To: <4935afb4-a54f-5ebd-d9bd-bf4da70ba088@acm.org>

On 11/7/19 1:26 PM, Bart Van Assche wrote:
> On 11/7/19 8:49 AM, Martin Wilck wrote:
>> Avoid an uninitialized value being falsely treated as NVMe priority.
> 
> Although this patch looks fine to me: which uninitialized value are you 
> referring to and how does this patch make a difference?

Does your comment refer to ha->fc4_type_priority ? You may want to 
mention this in the commit message since that variable does not occur in 
the code touched by this patch.

Thanks,

Bart.

  reply	other threads:[~2019-11-07 21:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 16:49 [PATCH 1/2] scsi: qla2xxx: initialize fc4_type_priority Martin Wilck
2019-11-07 16:49 ` [PATCH 2/2] scsi: qla2xxx: don't use zero for FC4_PRIORITY_NVME Martin Wilck
2019-11-07 21:05   ` Martin Wilck
2019-11-07 21:26   ` Bart Van Assche
2019-11-07 21:36     ` Bart Van Assche [this message]
2019-11-07 22:36       ` Martin Wilck
2019-11-07 21:04 ` [PATCH 1/2] scsi: qla2xxx: initialize fc4_type_priority Martin Wilck
2019-11-07 21:29 ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5425bd0-6cb6-81ff-e8af-5392454b72a1@acm.org \
    --to=bvanassche@acm.org \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=Martin.Wilck@suse.com \
    --cc=hmadhani@marvell.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mhernandez@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.