All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()
@ 2022-03-14 14:04 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2022-03-14 14:04 UTC (permalink / raw)
  To: Evan Quan, Yifan Zhang, Huang Rui
  Cc: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
	Daniel Vetter, Lijo Lazar, Guchun Chen, Luben Tuikov,
	Graham Sider, Darren Powell, Prike Liang, amd-gfx,
	kernel-janitors

Smatch complains that the dev_err_ratelimited() is indented one tab more
than the surrounding lines.

	drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
	__smu_cmn_reg_print_error() warn: inconsistent indenting

It looks like it's not a bug, just that the indenting needs to be cleaned
up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index ae64d1980f10..b8d0c70ff668 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -164,17 +164,17 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
 
 	switch (reg_c2pmsg_90) {
 	case SMU_RESP_NONE: {
-	if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
-		msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
-		prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
-	} else {
-		msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
-		prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
-	}
+		if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
+			msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
+			prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
+		} else {
+			msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
+			prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
+		}
 		dev_err_ratelimited(adev->dev,
 				    "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
 				    msg_idx, prm);
-	}
+		}
 		break;
 	case SMU_RESP_OK:
 		/* The SMU executed the command. It completed with a
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()
@ 2022-03-14 14:04 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2022-03-14 14:04 UTC (permalink / raw)
  To: Evan Quan, Yifan Zhang, Huang Rui
  Cc: Lijo Lazar, Guchun Chen, David Airlie, Pan, Xinhui,
	kernel-janitors, amd-gfx, Prike Liang, Luben Tuikov,
	Daniel Vetter, Darren Powell, Alex Deucher, Christian König,
	Graham Sider

Smatch complains that the dev_err_ratelimited() is indented one tab more
than the surrounding lines.

	drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
	__smu_cmn_reg_print_error() warn: inconsistent indenting

It looks like it's not a bug, just that the indenting needs to be cleaned
up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index ae64d1980f10..b8d0c70ff668 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -164,17 +164,17 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
 
 	switch (reg_c2pmsg_90) {
 	case SMU_RESP_NONE: {
-	if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
-		msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
-		prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
-	} else {
-		msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
-		prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
-	}
+		if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
+			msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
+			prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
+		} else {
+			msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
+			prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
+		}
 		dev_err_ratelimited(adev->dev,
 				    "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
 				    msg_idx, prm);
-	}
+		}
 		break;
 	case SMU_RESP_OK:
 		/* The SMU executed the command. It completed with a
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()
  2022-03-14 14:04 ` Dan Carpenter
@ 2022-03-14 16:06   ` Luben Tuikov
  -1 siblings, 0 replies; 6+ messages in thread
From: Luben Tuikov @ 2022-03-14 16:06 UTC (permalink / raw)
  To: Dan Carpenter, Evan Quan, Yifan Zhang, Huang Rui
  Cc: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
	Daniel Vetter, Lijo Lazar, Guchun Chen, Graham Sider,
	Darren Powell, Prike Liang, amd-gfx, kernel-janitors

Thanks!

Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>

Regards,
Luben

On 2022-03-14 10:04, Dan Carpenter wrote:
> Smatch complains that the dev_err_ratelimited() is indented one tab more
> than the surrounding lines.
> 
> 	drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
> 	__smu_cmn_reg_print_error() warn: inconsistent indenting
> 
> It looks like it's not a bug, just that the indenting needs to be cleaned
> up.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index ae64d1980f10..b8d0c70ff668 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -164,17 +164,17 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
>  
>  	switch (reg_c2pmsg_90) {
>  	case SMU_RESP_NONE: {
> -	if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> -		msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> -		prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> -	} else {
> -		msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> -		prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> -	}
> +		if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> +			msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> +			prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> +		} else {
> +			msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> +			prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> +		}
>  		dev_err_ratelimited(adev->dev,
>  				    "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
>  				    msg_idx, prm);
> -	}
> +		}
>  		break;
>  	case SMU_RESP_OK:
>  		/* The SMU executed the command. It completed with a

Regards,
-- 
Luben

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()
@ 2022-03-14 16:06   ` Luben Tuikov
  0 siblings, 0 replies; 6+ messages in thread
From: Luben Tuikov @ 2022-03-14 16:06 UTC (permalink / raw)
  To: Dan Carpenter, Evan Quan, Yifan Zhang, Huang Rui
  Cc: Lijo Lazar, Guchun Chen, David Airlie, Pan, Xinhui,
	kernel-janitors, amd-gfx, Prike Liang, Daniel Vetter,
	Darren Powell, Alex Deucher, Christian König, Graham Sider

Thanks!

Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>

Regards,
Luben

On 2022-03-14 10:04, Dan Carpenter wrote:
> Smatch complains that the dev_err_ratelimited() is indented one tab more
> than the surrounding lines.
> 
> 	drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
> 	__smu_cmn_reg_print_error() warn: inconsistent indenting
> 
> It looks like it's not a bug, just that the indenting needs to be cleaned
> up.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index ae64d1980f10..b8d0c70ff668 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -164,17 +164,17 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
>  
>  	switch (reg_c2pmsg_90) {
>  	case SMU_RESP_NONE: {
> -	if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> -		msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> -		prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> -	} else {
> -		msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> -		prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> -	}
> +		if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> +			msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> +			prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> +		} else {
> +			msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> +			prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> +		}
>  		dev_err_ratelimited(adev->dev,
>  				    "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
>  				    msg_idx, prm);
> -	}
> +		}
>  		break;
>  	case SMU_RESP_OK:
>  		/* The SMU executed the command. It completed with a

Regards,
-- 
Luben

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()
  2022-03-14 16:06   ` Luben Tuikov
@ 2022-03-15 15:53     ` Alex Deucher
  -1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-03-15 15:53 UTC (permalink / raw)
  To: Luben Tuikov
  Cc: Dan Carpenter, Evan Quan, Yifan Zhang, Huang Rui, Lijo Lazar,
	Guchun Chen, David Airlie, Pan, Xinhui, kernel-janitors,
	amd-gfx list, Prike Liang, Daniel Vetter, Darren Powell,
	Alex Deucher, Christian König, Graham Sider

Applied.  Thanks!

Alex

On Mon, Mar 14, 2022 at 12:06 PM Luben Tuikov <luben.tuikov@amd.com> wrote:
>
> Thanks!
>
> Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
>
> Regards,
> Luben
>
> On 2022-03-14 10:04, Dan Carpenter wrote:
> > Smatch complains that the dev_err_ratelimited() is indented one tab more
> > than the surrounding lines.
> >
> >       drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
> >       __smu_cmn_reg_print_error() warn: inconsistent indenting
> >
> > It looks like it's not a bug, just that the indenting needs to be cleaned
> > up.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> >  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > index ae64d1980f10..b8d0c70ff668 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > @@ -164,17 +164,17 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
> >
> >       switch (reg_c2pmsg_90) {
> >       case SMU_RESP_NONE: {
> > -     if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> > -             msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> > -             prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> > -     } else {
> > -             msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> > -             prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> > -     }
> > +             if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> > +                     msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> > +                     prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> > +             } else {
> > +                     msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> > +                     prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> > +             }
> >               dev_err_ratelimited(adev->dev,
> >                                   "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
> >                                   msg_idx, prm);
> > -     }
> > +             }
> >               break;
> >       case SMU_RESP_OK:
> >               /* The SMU executed the command. It completed with a
>
> Regards,
> --
> Luben

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error()
@ 2022-03-15 15:53     ` Alex Deucher
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-03-15 15:53 UTC (permalink / raw)
  To: Luben Tuikov
  Cc: Yifan Zhang, Pan, Xinhui, Guchun Chen, David Airlie, Lijo Lazar,
	kernel-janitors, amd-gfx list, Prike Liang, Huang Rui,
	Graham Sider, Daniel Vetter, Darren Powell, Alex Deucher,
	Evan Quan, Christian König, Dan Carpenter

Applied.  Thanks!

Alex

On Mon, Mar 14, 2022 at 12:06 PM Luben Tuikov <luben.tuikov@amd.com> wrote:
>
> Thanks!
>
> Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>
>
> Regards,
> Luben
>
> On 2022-03-14 10:04, Dan Carpenter wrote:
> > Smatch complains that the dev_err_ratelimited() is indented one tab more
> > than the surrounding lines.
> >
> >       drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:174
> >       __smu_cmn_reg_print_error() warn: inconsistent indenting
> >
> > It looks like it's not a bug, just that the indenting needs to be cleaned
> > up.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> >  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > index ae64d1980f10..b8d0c70ff668 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> > @@ -164,17 +164,17 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu,
> >
> >       switch (reg_c2pmsg_90) {
> >       case SMU_RESP_NONE: {
> > -     if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> > -             msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> > -             prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> > -     } else {
> > -             msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> > -             prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> > -     }
> > +             if (adev->ip_versions[MP1_HWIP][0] == IP_VERSION(13, 0, 5)) {
> > +                     msg_idx = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_2);
> > +                     prm     = RREG32_SOC15(MP1, 0, mmMP1_C2PMSG_34);
> > +             } else {
> > +                     msg_idx = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_66);
> > +                     prm     = RREG32_SOC15(MP1, 0, mmMP1_SMN_C2PMSG_82);
> > +             }
> >               dev_err_ratelimited(adev->dev,
> >                                   "SMU: I'm not done with your previous command: SMN_C2PMSG_66:0x%08X SMN_C2PMSG_82:0x%08X",
> >                                   msg_idx, prm);
> > -     }
> > +             }
> >               break;
> >       case SMU_RESP_OK:
> >               /* The SMU executed the command. It completed with a
>
> Regards,
> --
> Luben

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-15 15:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 14:04 [PATCH] drm/amd/pm: fix indenting in __smu_cmn_reg_print_error() Dan Carpenter
2022-03-14 14:04 ` Dan Carpenter
2022-03-14 16:06 ` Luben Tuikov
2022-03-14 16:06   ` Luben Tuikov
2022-03-15 15:53   ` Alex Deucher
2022-03-15 15:53     ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.