From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE0D9C64EC5 for ; Wed, 8 Feb 2023 09:49:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbjBHJti (ORCPT ); Wed, 8 Feb 2023 04:49:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230194AbjBHJth (ORCPT ); Wed, 8 Feb 2023 04:49:37 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0834B166C5; Wed, 8 Feb 2023 01:49:33 -0800 (PST) Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 08 Feb 2023 18:49:32 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 8C54E2083D75; Wed, 8 Feb 2023 18:49:32 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Wed, 8 Feb 2023 18:49:25 +0900 Received: from [10.212.242.61] (unknown [10.212.242.61]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 414167361; Wed, 8 Feb 2023 18:49:31 +0900 (JST) Message-ID: Date: Wed, 8 Feb 2023 18:49:30 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] thermal: Remove core header inclusion from drivers To: Daniel Lezcano Cc: rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Guillaume La Roque , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Miquel Raynal , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Konrad Dybcio , Thara Gopinath , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Jonathan Hunter , Masami Hiramatsu , ye xingchen , Ricardo Neri , Srinivas Pandruvada , Haowen Bai , Minghao Chi , "open list:THERMAL DRIVER FOR AMLOGIC SOCS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:ARM/QUALCOMM SUPPORT" , "open list:RENESAS R-CAR THERMAL DRIVERS" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" References: <20230206153432.1017282-1-daniel.lezcano@linaro.org> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: <20230206153432.1017282-1-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi Daniel, On 2023/02/07 0:34, Daniel Lezcano wrote: > As the name states "thermal_core.h" is the header file for the core > components of the thermal framework. > > Too many drivers are including it. Hopefully the recent cleanups > helped to self encapsulate the code a bit more and prevented the > drivers to need this header. > > Remove this inclusion in every place where it is possible. > > Some other drivers did a confusion with the core header and the one > exported in linux/thermal.h. They include the former instead of the > latter. The changes also fix this. > > The tegra/soctherm driver still remains as it uses an internal > function which need to be replaced. > > The Intel HFI driver uses the netlink internal framework core and > should be changed to prevent to deal with the internals. > > No functional changes > > [ Applies to thermal/linux-next or linux-pm/linux-next ] > > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/uniphier_thermal.c | 2 -- For UniPhier: Reviewed-by: Kunihiko Hayashi Thank you, --- Best Regards Kunihiko Hayashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7FB6C636CC for ; Wed, 8 Feb 2023 09:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UqDWMaHZ2S1V19la8Js+hksTnYj2gVcSlJjvpnb9aFI=; b=eRuo6m/gLAbdj3 zV0FJ8HkioeITt26ZJTQae3uyQXWCgp6MxaGLP4hV71tWL7znp3mrHYEMWo/e8TXM82SG6zjyeuOp eq7ImggAUM4hDSWveb59kftUh7Wub+CmSZias29c8qBNONdnuXvGlYJPKKFx1bge9Gxa9wxab4W2Y ieA63Yb3nOdJwxdJhjvUy0/D27we/wneaGyL4xBrd3sGQcGgVYElElIY3MFSyC4XHJs+IwjL0I0CD 1wv1npb56WIp7//Zkc+oOSqYDhtx+b4esmgCKDJc8L2hJplAWR9hNMwUiKuDLE0nGabjjok+r9KOm aPPRP1+YpJfN0bG83iDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPhDL-00F3zC-4y; Wed, 08 Feb 2023 09:58:07 +0000 Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPh58-00Ezyn-05; Wed, 08 Feb 2023 09:49:40 +0000 Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 08 Feb 2023 18:49:32 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 8C54E2083D75; Wed, 8 Feb 2023 18:49:32 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Wed, 8 Feb 2023 18:49:25 +0900 Received: from [10.212.242.61] (unknown [10.212.242.61]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 414167361; Wed, 8 Feb 2023 18:49:31 +0900 (JST) Message-ID: Date: Wed, 8 Feb 2023 18:49:30 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] thermal: Remove core header inclusion from drivers To: Daniel Lezcano Cc: rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Guillaume La Roque , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Miquel Raynal , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Konrad Dybcio , Thara Gopinath , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Jonathan Hunter , Masami Hiramatsu , ye xingchen , Ricardo Neri , Srinivas Pandruvada , Haowen Bai , Minghao Chi , "open list:THERMAL DRIVER FOR AMLOGIC SOCS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:ARM/QUALCOMM SUPPORT" , "open list:RENESAS R-CAR THERMAL DRIVERS" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" References: <20230206153432.1017282-1-daniel.lezcano@linaro.org> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: <20230206153432.1017282-1-daniel.lezcano@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_014938_526228_66C7C348 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Daniel, On 2023/02/07 0:34, Daniel Lezcano wrote: > As the name states "thermal_core.h" is the header file for the core > components of the thermal framework. > > Too many drivers are including it. Hopefully the recent cleanups > helped to self encapsulate the code a bit more and prevented the > drivers to need this header. > > Remove this inclusion in every place where it is possible. > > Some other drivers did a confusion with the core header and the one > exported in linux/thermal.h. They include the former instead of the > latter. The changes also fix this. > > The tegra/soctherm driver still remains as it uses an internal > function which need to be replaced. > > The Intel HFI driver uses the netlink internal framework core and > should be changed to prevent to deal with the internals. > > No functional changes > > [ Applies to thermal/linux-next or linux-pm/linux-next ] > > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/uniphier_thermal.c | 2 -- For UniPhier: Reviewed-by: Kunihiko Hayashi Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74320C05027 for ; Wed, 8 Feb 2023 09:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RFQ/+ACVEuSUQQn+G4OTotmPD/xxgckTjdPP6q71cbc=; b=h2INhyH27haBl5 LCE+xzdCmqqzds2BOXDdHzrfnREks7tiRsKpK0gci72A82e/VsRyowv54J8XjBct+sNQL+BdT5Scl jJ93TJzTqYdqj2/SZw4I1QQsrTLJHQjhb9D7b3V+rZmo/zj75IFYVj9aW42ESFYAXJ/zPbAIodzRC EczHx62tVO0iH7oPHCBWYQlvGyvezvwCriN8iU2NMHk0y2U7O07syaWBlw6xdHsd/CsWVyeEi/5Nu oEuOcRZ+TnO1+z4dtialGEQT2AjUOA4lShstJ5405pi0/yoXkTzjlDR5vjUaP2bUCrBKGAUWLtCG8 y2M0Udd3Ko7qU/Rw9+nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPhDO-00F3zq-4Y; Wed, 08 Feb 2023 09:58:10 +0000 Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPh58-00Ezyn-05; Wed, 08 Feb 2023 09:49:40 +0000 Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 08 Feb 2023 18:49:32 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 8C54E2083D75; Wed, 8 Feb 2023 18:49:32 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Wed, 8 Feb 2023 18:49:25 +0900 Received: from [10.212.242.61] (unknown [10.212.242.61]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 414167361; Wed, 8 Feb 2023 18:49:31 +0900 (JST) Message-ID: Date: Wed, 8 Feb 2023 18:49:30 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] thermal: Remove core header inclusion from drivers To: Daniel Lezcano Cc: rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Guillaume La Roque , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Miquel Raynal , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Konrad Dybcio , Thara Gopinath , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Jonathan Hunter , Masami Hiramatsu , ye xingchen , Ricardo Neri , Srinivas Pandruvada , Haowen Bai , Minghao Chi , "open list:THERMAL DRIVER FOR AMLOGIC SOCS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:ARM/QUALCOMM SUPPORT" , "open list:RENESAS R-CAR THERMAL DRIVERS" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" References: <20230206153432.1017282-1-daniel.lezcano@linaro.org> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: <20230206153432.1017282-1-daniel.lezcano@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230208_014938_526228_66C7C348 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On 2023/02/07 0:34, Daniel Lezcano wrote: > As the name states "thermal_core.h" is the header file for the core > components of the thermal framework. > > Too many drivers are including it. Hopefully the recent cleanups > helped to self encapsulate the code a bit more and prevented the > drivers to need this header. > > Remove this inclusion in every place where it is possible. > > Some other drivers did a confusion with the core header and the one > exported in linux/thermal.h. They include the former instead of the > latter. The changes also fix this. > > The tegra/soctherm driver still remains as it uses an internal > function which need to be replaced. > > The Intel HFI driver uses the netlink internal framework core and > should be changed to prevent to deal with the internals. > > No functional changes > > [ Applies to thermal/linux-next or linux-pm/linux-next ] > > Signed-off-by: Daniel Lezcano > --- > drivers/thermal/uniphier_thermal.c | 2 -- For UniPhier: Reviewed-by: Kunihiko Hayashi Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel