From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2BF8C433F5 for ; Fri, 18 Feb 2022 11:42:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54A0A10EA27; Fri, 18 Feb 2022 11:42:16 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id E18D210EA27 for ; Fri, 18 Feb 2022 11:42:14 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nL1eP-0006RH-DK; Fri, 18 Feb 2022 12:42:13 +0100 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nL1eP-00HO5Z-De; Fri, 18 Feb 2022 12:42:12 +0100 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1nL1eN-00058b-Lu; Fri, 18 Feb 2022 12:42:11 +0100 Message-ID: Subject: Re: [PATCH 09/22] drm/imx: Use drm_mode_duplicate() From: Philipp Zabel To: Ville Syrjala , dri-devel@lists.freedesktop.org Date: Fri, 18 Feb 2022 12:42:11 +0100 In-Reply-To: <20220218100403.7028-10-ville.syrjala@linux.intel.com> References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-10-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 2022-02-18 at 12:03 +0200, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 >=20 > Replace the hand rolled drm_mode_duplicate() with the > real thing. >=20 > @is_dup@ > @@ > drm_mode_duplicate(...) > { ... } >=20 > @depends on !is_dup@ > expression dev, oldmode; > identifier newmode; > @@ > - newmode =3D drm_mode_create(dev); > + newmode =3D drm_mode_duplicate(dev, oldmode); > =C2=A0 ... > - drm_mode_copy(newmode, oldmode); >=20 > Cc: Philipp Zabel > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Philipp Zabel regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 698F5C433FE for ; Fri, 18 Feb 2022 11:42:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 086BF10ED26; Fri, 18 Feb 2022 11:42:17 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7203110ECFB for ; Fri, 18 Feb 2022 11:42:16 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nL1eP-0006RH-DK; Fri, 18 Feb 2022 12:42:13 +0100 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nL1eP-00HO5Z-De; Fri, 18 Feb 2022 12:42:12 +0100 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1nL1eN-00058b-Lu; Fri, 18 Feb 2022 12:42:11 +0100 Message-ID: From: Philipp Zabel To: Ville Syrjala , dri-devel@lists.freedesktop.org Date: Fri, 18 Feb 2022 12:42:11 +0100 In-Reply-To: <20220218100403.7028-10-ville.syrjala@linux.intel.com> References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-10-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH 09/22] drm/imx: Use drm_mode_duplicate() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 2022-02-18 at 12:03 +0200, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 >=20 > Replace the hand rolled drm_mode_duplicate() with the > real thing. >=20 > @is_dup@ > @@ > drm_mode_duplicate(...) > { ... } >=20 > @depends on !is_dup@ > expression dev, oldmode; > identifier newmode; > @@ > - newmode =3D drm_mode_create(dev); > + newmode =3D drm_mode_duplicate(dev, oldmode); > =C2=A0 ... > - drm_mode_copy(newmode, oldmode); >=20 > Cc: Philipp Zabel > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Reviewed-by: Philipp Zabel regards Philipp