All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [PATCH 2/4] Do not include hw/boards.h if it's not really necessary
Date: Fri, 16 Apr 2021 19:53:21 +0200	[thread overview]
Message-ID: <e55a2cf6-2994-5318-0fa5-9a9057457e84@redhat.com> (raw)
In-Reply-To: <20210416171314.2074665-3-thuth@redhat.com>

Hi Thomas,

On 4/16/21 7:13 PM, Thomas Huth wrote:
> Stop including hw/boards.h in files that don't need it.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  accel/tcg/tcg-accel-ops-icount.c | 1 -
>  accel/tcg/tcg-accel-ops-rr.c     | 1 -
>  accel/tcg/tcg-accel-ops.c        | 1 -
>  hw/acpi/cpu.c                    | 1 -
>  hw/acpi/memory_hotplug.c         | 1 -
>  hw/alpha/typhoon.c               | 1 -
>  hw/arm/aspeed.c                  | 1 -

It requires the macros declared by:

OBJECT_DECLARE_TYPE(MachineState, MachineClass, MACHINE)

>  hw/arm/omap1.c                   | 1 -
>  hw/arm/omap2.c                   | 1 -
>  hw/arm/strongarm.c               | 1 -
>  hw/arm/virt.c                    | 1 -

Ditto.

>  hw/avr/arduino.c                 | 1 -

Ditto.

>  hw/avr/atmega.c                  | 1 -
>  hw/display/next-fb.c             | 1 -
>  hw/hppa/machine.c                | 1 -

Ditto.

>  hw/i386/acpi-build.c             | 1 -
>  hw/i386/acpi-microvm.c           | 1 -
>  hw/i386/intel_iommu.c            | 1 -
>  hw/i386/pc.c                     | 1 -

Ditto (MACHINE_CLASS macro).

>  hw/i386/x86-iommu.c              | 1 -
>  hw/intc/sifive_plic.c            | 1 -
>  hw/mips/loongson3_virt.c         | 1 -

Ditto.

(skipping the rest).

>  hw/ppc/e500.c                    | 1 -
>  hw/ppc/mac_newworld.c            | 1 -
>  hw/ppc/mac_oldworld.c            | 1 -
>  hw/ppc/pnv.c                     | 1 -
>  hw/ppc/ppc4xx_devs.c             | 1 -
>  hw/ppc/rs6000_mc.c               | 1 -
>  hw/ppc/spapr.c                   | 1 -
>  hw/ppc/spapr_rtas.c              | 1 -
>  hw/remote/iohub.c                | 1 -
>  hw/s390x/s390-virtio-ccw.c       | 2 --
>  hw/tricore/tc27x_soc.c           | 1 -
>  hw/tricore/triboard.c            | 1 -
>  softmmu/vl.c                     | 1 -
>  35 files changed, 36 deletions(-)



  reply	other threads:[~2021-04-16 18:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 17:13 [PATCH for-6.1 0/4] Remove more superfluous include statements Thomas Huth
2021-04-16 17:13 ` [PATCH 1/4] Do not include sysemu/sysemu.h if it's not really necessary Thomas Huth
2021-04-30 15:59   ` Laurent Vivier
2021-04-16 17:13 ` [PATCH 2/4] Do not include hw/boards.h " Thomas Huth
2021-04-16 17:53   ` Philippe Mathieu-Daudé [this message]
2021-04-16 18:04     ` Thomas Huth
2021-04-17  9:50       ` Markus Armbruster
2021-04-30 15:59   ` Laurent Vivier
2021-04-16 17:13 ` [PATCH 3/4] Do not include cpu.h " Thomas Huth
2021-04-30 15:59   ` Laurent Vivier
2021-04-16 17:13 ` [PATCH 4/4] Do not include exec/address-spaces.h " Thomas Huth
2021-04-30 15:59   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e55a2cf6-2994-5318-0fa5-9a9057457e84@redhat.com \
    --to=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.