From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4446CC4743C for ; Sat, 5 Jun 2021 01:35:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0E3C613AC for ; Sat, 5 Jun 2021 01:35:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0E3C613AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpLE7-0001CZ-PR for qemu-devel@archiver.kernel.org; Fri, 04 Jun 2021 21:35:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpLDI-0000Dz-QB for qemu-devel@nongnu.org; Fri, 04 Jun 2021 21:35:00 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]:34571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpLDD-0005Vd-NM for qemu-devel@nongnu.org; Fri, 04 Jun 2021 21:35:00 -0400 Received: by mail-pg1-x52b.google.com with SMTP id l1so9242124pgm.1 for ; Fri, 04 Jun 2021 18:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OU50V3pTHSUQcQ9LG58F9/C5JTGxP15zI5nz4AAJpGU=; b=ccqEWlA8XgqWY4GMRNGDlnfLc2lGFKlz4sr3Cz1+JFyBLbLjH0gsIWlvB+c8ILqDsX GrsdQEdLJ0FCjhxfi+gsdGquOmbGMy0RA88T9E/XYsYWdNoWcnDoFGvHFq+OM1KIvy7d OkBTHhcLcIur68SyqXGIxzHPKUKiW7KThJbhzvyHWTp3ynPbbRDA+5tBruX5dbya++fc oE6UAKesZ9K/lblQ80Lq+/Pnyv3YyKrovCtk7+Y1stRnJy2KP1LVDhPCx14mRw2aSZ35 fUvkbJr5I0gB8ROU2FLwTiw17GoGJS9aFX7jrR3Q74L7LOpV6CyYKpbE4SCR/dWS+uux wWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OU50V3pTHSUQcQ9LG58F9/C5JTGxP15zI5nz4AAJpGU=; b=N27iOsNWpCdScY+OFFZ+kyzbNs9JfV+w6BIhWuqNbUHi+OYQZQV/CqRGsyzdhH9B7N EdsXSXAdjEPQSB17mItiVqEDotPqDF6maDNywAz6S1QYStgKFvjmxBaDebfqHqBmBLdb CXBYo0Yh/VQFW70CUPbhuUL8V6J9rw1Snyk9mSSCipaBNWIUnHpfaGMhxnJegiqvXslR yzg49/fvIOMpJq48WtoiR/2+RHRb/Ho0XJM7qEkChnXh88dY8tor+bcLZL0Rm9JRScJI DJMig8vLzGJuvkW+Jc2GBz0YSV8gcO1Zh1e08A2UIeDFxOXOSvNJ/dV5OFoNuFu5W9gX RS7Q== X-Gm-Message-State: AOAM532ESoPotEcpzkeudzCXgJfrRugnlU/pXHTqjbZxosHseEA3oBfI FDQ5yFl0avBruI6RTcsNGOh8cg== X-Google-Smtp-Source: ABdhPJzCjPmWMU3XOHwvQ7XFp8nzDK57fF8iy7tMTzf9an3BavjVq/36egk4d6m+waoAW1q2ZTjx7Q== X-Received: by 2002:a62:2987:0:b029:2de:b564:648d with SMTP id p129-20020a6229870000b02902deb564648dmr7141673pfp.48.1622856893783; Fri, 04 Jun 2021 18:34:53 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id q23sm3049827pgj.61.2021.06.04.18.34.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 18:34:53 -0700 (PDT) Subject: Re: [PATCH v16 49/99] target/arm: make further preparation for the exception code to move To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20210604155312.15902-1-alex.bennee@linaro.org> <20210604155312.15902-50-alex.bennee@linaro.org> From: Richard Henderson Message-ID: Date: Fri, 4 Jun 2021 18:34:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210604155312.15902-50-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52b.google.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.59, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Claudio Fontana Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/4/21 8:52 AM, Alex Bennée wrote: > From: Claudio Fontana > > the exception code in tcg/ needs some adjustment before being exposed > to KVM-only builds. We need to call arm_rebuild_hflags only when > TCG is enabled, or we will error out. > > The direct call to helper_rebuild_hflags_a64(env, new_el) will not > be possible when extracting out to common code, > it seems safe to replace it with a call to arm_rebuild_hflags, since > the write to pstate is already done. > > Also, some CONFIG_TCG needs to be extended further, so that all > the tcg-only code is marked as such. > > Signed-off-by: Claudio Fontana > Signed-off-by: Alex Bennée > --- > target/arm/tcg/helper.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~