From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 6/7] eal: add struct rte_vdev_device Date: Wed, 15 Feb 2017 17:11:40 +0000 Message-ID: References: <1487152929-23627-1-git-send-email-jblunck@infradead.org> <1487152929-23627-7-git-send-email-jblunck@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: shreyansh.jain@nxp.com To: Jan Blunck , dev@dpdk.org Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BA5F569C5 for ; Wed, 15 Feb 2017 18:11:42 +0100 (CET) In-Reply-To: <1487152929-23627-7-git-send-email-jblunck@infradead.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/15/2017 10:02 AM, Jan Blunck wrote: > This adds the rte_vdev_device structure which embeds a generic rte_device. > > Signed-off-by: Jan Blunck <...> > > +struct rte_vdev_device { > + TAILQ_ENTRY(rte_vdev_device) next; /**< Next attached vdev */ > + struct rte_device device; /**< Inherit core device */ What do you think adding a name field here ? "dev->device.devargs->virt.drv_name" used a few times, since probing virtual devices done based on name. This is device name, and accessing it via "devargs->virt.drv_name" is not that clear. It is possible to create a name field here, set it during probe or init to point devargs field and use it wherever required, does it make sense? > +}; > + > /** Double linked list of virtual device drivers. */ > TAILQ_HEAD(vdev_driver_list, rte_vdev_driver); > >