All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Greg KH <gregkh@linuxfoundation.org>, Jonas Blixt <jonas.blixt@actia.se>
Cc: shuah@kernel.org, valentina.manea.m@gmail.com,
	stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] USB: usbip: fix stub_dev hub disconnect
Date: Thu, 5 Oct 2023 08:33:54 -0600	[thread overview]
Message-ID: <e56353b2-a814-4a81-9516-63736d12abba@linuxfoundation.org> (raw)
In-Reply-To: <2023100548-kleenex-deceased-624e@gregkh>

On 10/5/23 01:22, Greg KH wrote:
> On Thu, Jun 15, 2023 at 11:28:10AM +0200, Jonas Blixt wrote:
>> If a hub is disconnected that has device(s) that's attached to the usbip layer
>> the disconnect function might fail because it tries to release the port
>> on an already disconnected hub.
>>
>> Fixes: 6080cd0e9239 ("staging: usbip: claim ports used by shared devices")
>> Signed-off-by: Jonas Blixt <jonas.blixt@actia.se>
>> ---
>> v2:
>>   - Clarify comment
>> v1:
>>   Link to v1: https://lore.kernel.org/linux-usb/20230615092205.GA1212960@W388ANL/T/#m575e37dc404067797eadf4444857366c73ba3420
>> ---
>>   drivers/usb/usbip/stub_dev.c | 9 +++++++--
>>   1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/usbip/stub_dev.c b/drivers/usb/usbip/stub_dev.c
>> index 2305d425e6c9..2170c95c8dab 100644
>> --- a/drivers/usb/usbip/stub_dev.c
>> +++ b/drivers/usb/usbip/stub_dev.c
>> @@ -427,8 +427,13 @@ static void stub_disconnect(struct usb_device *udev)
>>   	/* release port */
>>   	rc = usb_hub_release_port(udev->parent, udev->portnum,
>>   				  (struct usb_dev_state *) udev);
>> -	if (rc) {
>> -		dev_dbg(&udev->dev, "unable to release port\n");
>> +	/*
>> +	 * NOTE: If a HUB disconnect triggered disconnect of the down stream
>> +	 * device usb_hub_release_port will return -ENODEV so we can safely ignore
>> +	 * that error here.
>> +	 */
>> +	if (rc && (rc != -ENODEV)) {
>> +		dev_dbg(&udev->dev, "unable to release port (%i)\n", rc);
>>   		return;
>>   	}
>>   
>> -- 
>> 2.25.1
>>
> 
> Shuah, what ever happened to this change, is it correct or was something
> else applied to fix it?
> 

Sorry for the delay. I thought I took care of acking this one. :(

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah


      reply	other threads:[~2023-10-05 15:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15  9:28 [PATCH v2] USB: usbip: fix stub_dev hub disconnect Jonas Blixt
2023-10-05  7:22 ` Greg KH
2023-10-05 14:33   ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e56353b2-a814-4a81-9516-63736d12abba@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonas.blixt@actia.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.