From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA1FC282CD for ; Wed, 30 Jan 2019 04:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A3472184D for ; Wed, 30 Jan 2019 04:18:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B3xv6Hpg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730138AbfA3ESc (ORCPT ); Tue, 29 Jan 2019 23:18:32 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:46660 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727720AbfA3ESc (ORCPT ); Tue, 29 Jan 2019 23:18:32 -0500 Received: by mail-pl1-f196.google.com with SMTP id t13so10426457ply.13 for ; Tue, 29 Jan 2019 20:18:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1ZrjWliB2u4jgwR2mCdfgS6WJNMsH31k0WOY2n1ohGo=; b=B3xv6HpgVtMIxWqL5c9cHPq9UxH4D2CGYjFJ1UVL0zU1+i4bUs3Civ4tGTFfoM5ekN w6xZtFQTiNBPOjiZ38PFxspDW2oMggFnY6unpYXnIsrRgbKlBB6bHlNyfs2ah4ogFusv +1WdgfKzewKoi9hgggjos7BiTzol6yUU/34X5AvSBEfRIwB1ODKDOCfnlPDknp0nuebo t/UaWYDXtUkGBBWI2OeK77UyUIRuIectrQcg9ulhp2Wau79pody4uIkIV90eYJ0UnQ7v +fnfDetiyy4yYanX1sy0xP/iLaDyXmd52F31mAptgUDmsW/K1Rac96x3QXPvDvBEkV6y Yc/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1ZrjWliB2u4jgwR2mCdfgS6WJNMsH31k0WOY2n1ohGo=; b=VOslC3eHHl+FprZ+eUIUFYzNoRiPYIimSbjCkt2FbOoXckypTezcfsMNTdJwITEuZc 37hnQVGw5faX6nV4yFME7QPoddd8Vr+tSEGdQyULTOMyk87nHeE9kOY4MuDi0GnfYLQB qpHaoISjDS6kZhr71DM+axKK6IEc9A6CQzqMwCpDV9Vnd2RTa0m9cf1Wm0hpL3seSB2g srQvhh8AzM4YNOySc2vTx8NlPPYCRD4A2GhvaV0uahhovvqmsrgiVNMqw5jcz+/7qbQ1 oHgGqJpg8jmCavPkWymrd39+jxbCiozSBINkfidjIH61PxIO8UW9cT044c8BBpBHti/m nwrA== X-Gm-Message-State: AJcUukc2DV7Topz2da/4d/qVg+Ql6wEO8x+PMgdGY9iCZY+v/DVtkfC6 vzKHGnSC0Gmf/bn68fSRJWc= X-Google-Smtp-Source: ALg8bN48kq992R2/UHpV4+Gqte3VBFXVeiRGMrJYb3n2Kz8Bkt+WdZOwsXhfmMEDbEK6KPhpH67WWg== X-Received: by 2002:a17:902:b406:: with SMTP id x6mr27539608plr.329.1548821911739; Tue, 29 Jan 2019 20:18:31 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:edc4:6e9f:eba1:f2a3? ([2601:282:800:fd80:edc4:6e9f:eba1:f2a3]) by smtp.googlemail.com with ESMTPSA id r12sm340210pgv.83.2019.01.29.20.18.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 20:18:30 -0800 (PST) Subject: Re: [RFC 03/14] net: hstats: add basic/core functionality To: Jakub Kicinski , davem@davemloft.net Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, jiri@resnulli.us, f.fainelli@gmail.com, andrew@lunn.ch, mkubecek@suse.cz, simon.horman@netronome.com, jesse.brandeburg@intel.com, maciejromanfijalkowski@gmail.com, vasundhara-v.volam@broadcom.com, michael.chan@broadcom.com, shalomt@mellanox.com, idosch@mellanox.com References: <20190128234507.32028-1-jakub.kicinski@netronome.com> <20190128234507.32028-4-jakub.kicinski@netronome.com> From: David Ahern Message-ID: Date: Tue, 29 Jan 2019 21:18:28 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190128234507.32028-4-jakub.kicinski@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/28/19 4:44 PM, Jakub Kicinski wrote: > @@ -4946,6 +4964,9 @@ static size_t if_nlmsg_stats_size(const struct net_device *dev, > rcu_read_unlock(); > } > > + if (stats_attr_valid(filter_mask, IFLA_STATS_LINK_HSTATS, 0)) filter_mask is populated by RTEXT_FILTER_ from include/uapi/linux/rtnetlink.h > + size += rtnl_get_link_hstats_size(dev); rtnl_get_link_hstats_size == __rtnl_get_link_hstats can return < 0. > + > return size; > } > >