From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] soc/tegra: flowctrl: Fix error handling Date: Tue, 11 Apr 2017 08:15:02 +0100 Message-ID: References: <20170411034041.18662-1-christophe.jaillet@wanadoo.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170411034041.18662-1-christophe.jaillet@wanadoo.fr> Sender: linux-kernel-owner@vger.kernel.org To: Christophe JAILLET , thierry.reding@gmail.com Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-tegra@vger.kernel.org On 11/04/17 04:40, Christophe JAILLET wrote: > It is likely that returning returned by 'devm_ioremap_resource()' is > expected here instead of something related to 'base' which should be a > valid pointer at this point. > > Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver") > > Signed-off-by: Christophe JAILLET > --- > drivers/soc/tegra/flowctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c > index 0e345c05fc65..5433cc7a043e 100644 > --- a/drivers/soc/tegra/flowctrl.c > +++ b/drivers/soc/tegra/flowctrl.c > @@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(tegra_flowctrl_base)) > - return PTR_ERR(base); > + return PTR_ERR(tegra_flowctrl_base); > > iounmap(base); Oops! Thanks for the fix. Acked-by: Jon Hunter Cheers Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753827AbdDKHPu (ORCPT ); Tue, 11 Apr 2017 03:15:50 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:10134 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbdDKHPs (ORCPT ); Tue, 11 Apr 2017 03:15:48 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 11 Apr 2017 00:15:47 -0700 Subject: Re: [PATCH] soc/tegra: flowctrl: Fix error handling To: Christophe JAILLET , References: <20170411034041.18662-1-christophe.jaillet@wanadoo.fr> CC: , , From: Jon Hunter Message-ID: Date: Tue, 11 Apr 2017 08:15:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170411034041.18662-1-christophe.jaillet@wanadoo.fr> X-Originating-IP: [10.26.11.77] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To drukmail101.nvidia.com (10.25.59.19) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/17 04:40, Christophe JAILLET wrote: > It is likely that returning returned by 'devm_ioremap_resource()' is > expected here instead of something related to 'base' which should be a > valid pointer at this point. > > Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver") > > Signed-off-by: Christophe JAILLET > --- > drivers/soc/tegra/flowctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c > index 0e345c05fc65..5433cc7a043e 100644 > --- a/drivers/soc/tegra/flowctrl.c > +++ b/drivers/soc/tegra/flowctrl.c > @@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(tegra_flowctrl_base)) > - return PTR_ERR(base); > + return PTR_ERR(tegra_flowctrl_base); > > iounmap(base); Oops! Thanks for the fix. Acked-by: Jon Hunter Cheers Jon -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Date: Tue, 11 Apr 2017 07:15:02 +0000 Subject: Re: [PATCH] soc/tegra: flowctrl: Fix error handling Message-Id: List-Id: References: <20170411034041.18662-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20170411034041.18662-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET , thierry.reding@gmail.com Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 11/04/17 04:40, Christophe JAILLET wrote: > It is likely that returning returned by 'devm_ioremap_resource()' is > expected here instead of something related to 'base' which should be a > valid pointer at this point. > > Fixes: 841fd94c43a4 ("soc/tegra: flowctrl: Add basic platform driver") > > Signed-off-by: Christophe JAILLET > --- > drivers/soc/tegra/flowctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/tegra/flowctrl.c b/drivers/soc/tegra/flowctrl.c > index 0e345c05fc65..5433cc7a043e 100644 > --- a/drivers/soc/tegra/flowctrl.c > +++ b/drivers/soc/tegra/flowctrl.c > @@ -157,7 +157,7 @@ static int tegra_flowctrl_probe(struct platform_device *pdev) > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > tegra_flowctrl_base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(tegra_flowctrl_base)) > - return PTR_ERR(base); > + return PTR_ERR(tegra_flowctrl_base); > > iounmap(base); Oops! Thanks for the fix. Acked-by: Jon Hunter Cheers Jon -- nvpublic