All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/9] efi_loader: rework bootefi/bootmgr
Date: Tue, 23 Apr 2019 06:57:17 +0200	[thread overview]
Message-ID: <e57ff872-4381-48bd-5616-fc7be456bb82@gmx.de> (raw)
In-Reply-To: <CAB5YjtDfJ1WF2-=E8sx6LmDVb0jcp=p7t4sg5Jnj_mg+HLDRrQ@mail.gmail.com>

On 4/23/19 2:24 AM, AKASHI, Takahiro wrote:
> Heinrich,
>
> On Tue, 23 Apr 2019 at 03:16, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>
>> On 4/19/19 5:22 AM, AKASHI Takahiro wrote:
>>> There are several reasons that I want to rework/refactor bootefi command
>>> as well as bootmgr:
>>> * Some previous commits on bootefi.c have made the code complicated
>>>    and a bit hard to understand.
>>>
>>> * do_bootefi_exec() would better be implemented using load_image() along
>>>    with start_image() to be aligned with UEFI interfaces.
>>>
>>> * Contrary to the other part, efi_selftest part of the code is unusual
>>>    in terms of loading/execution path in do_bootefi().
>>>
>>> * When we will support "secure boot" in the future, EFI Boot Manager
>>>    is expected to be invoked as a standalone command without any arguments
>>>    to mitigate security surfaces.
>>>
>>> In this patch set,
>>> Patch#1 to #7 are preparatory patches for patch#8.
>>> Patch#8 is a core part of reworking.
>>> Patch#9 is for standalone boot manager.
>>
>> Hello Takahiro,
>>
>> your patches 1-8 are now (with some modifications) in the efi-2019-07
>> branch. I have added some more patches.
>>
>> https://github.com/xypron2/u-boot/commits/efi-2019-07
>>
>> Travis CI testing was ok:
>> https://travis-ci.org/xypron2/u-boot/builds/522947698
>>
>> I have tested on real hardware without error:
>> * TinkerBoard (32 bit) boot via GRUB
>> * Pine64 A64 LTS (64 bit) boot via iPXE and GRUB
>> * Odroid C2 (64 bit) boot via GRUB
>>
>> If you are ok with the adjustments to your patch series I will create a
>> pull request.
>
> Thank you for the merge.
> One question: how did you fix a grub error that you reported before?

I fixed the issue that iPXE could not find a chained script via
efi_loader: correctly split device path of loaded image
https://lists.denx.de/pipermail/u-boot/2019-April/365907.html

Furthermore I fixed a bug in Debian's QEMU by applying Alex's
https://github.com/qemu/qemu/commit/2d2a4549cc29850aab891495685a7b31f5254b12

Best regards

Heinrich

>
> -Takahiro Akashi
>
>
>> Best regards
>>
>> Heinrich
>

  reply	other threads:[~2019-04-23  4:57 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19  3:22 [U-Boot] [PATCH 0/9] efi_loader: rework bootefi/bootmgr AKASHI Takahiro
2019-04-19  3:22 ` [U-Boot] [PATCH 1/9] cmd: bootefi: rework set_load_options() AKASHI Takahiro
2019-04-19  3:37   ` Heinrich Schuchardt
2019-04-19  3:22 ` [U-Boot] [PATCH 2/9] cmd: bootefi: carve out fdt handling from do_bootefi() AKASHI Takahiro
2019-04-19  3:43   ` Heinrich Schuchardt
2019-04-19  3:22 ` [U-Boot] [PATCH 3/9] cmd: bootefi: merge efi_install_fdt() and efi_process_fdt() AKASHI Takahiro
2019-04-19  4:06   ` Heinrich Schuchardt
2019-04-19  4:42     ` AKASHI Takahiro
2019-04-19  3:22 ` [U-Boot] [PATCH 4/9] cmd: bootefi: carve out efi_selftest code from do_bootefi() AKASHI Takahiro
2019-04-20  6:57   ` Heinrich Schuchardt
2019-04-19  3:22 ` [U-Boot] [PATCH 5/9] cmd: bootefi: move do_bootefi_bootmgr_exec() forward AKASHI Takahiro
2019-04-19  3:22 ` [U-Boot] [PATCH 6/9] cmd: bootefi: carve out bootmgr code from do_bootefi() AKASHI Takahiro
2019-04-20  7:47   ` Heinrich Schuchardt
2019-04-19  3:22 ` [U-Boot] [PATCH 7/9] cmd: bootefi: carve out do_bootefi_image() " AKASHI Takahiro
2019-04-19  3:22 ` [U-Boot] [PATCH 8/9] efi_loader: rework bootmgr/bootefi using load_image API AKASHI Takahiro
2019-04-20  8:07   ` Heinrich Schuchardt
2019-04-22  0:44     ` AKASHI Takahiro
2019-04-20  8:37   ` Heinrich Schuchardt
2019-04-20 17:37     ` Heinrich Schuchardt
2019-04-22  0:36       ` AKASHI Takahiro
2019-04-20 18:24     ` Heinrich Schuchardt
2019-04-22  1:05     ` AKASHI Takahiro
2019-04-21  7:02   ` Heinrich Schuchardt
2019-04-19  3:22 ` [U-Boot] [PATCH 9/9] cmd: add efibootmgr command AKASHI Takahiro
2019-04-20  8:49   ` Heinrich Schuchardt
2019-04-22 18:16 ` [U-Boot] [PATCH 0/9] efi_loader: rework bootefi/bootmgr Heinrich Schuchardt
2019-04-23  0:24   ` AKASHI, Takahiro
2019-04-23  4:57     ` Heinrich Schuchardt [this message]
2019-04-23  5:08       ` AKASHI, Takahiro
2020-01-03  0:17 ` Heinrich Schuchardt
2020-01-06  1:42   ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e57ff872-4381-48bd-5616-fc7be456bb82@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.