From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6C85C433F5 for ; Tue, 11 Jan 2022 10:39:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E930B82C6D; Tue, 11 Jan 2022 11:39:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="BucwJMqH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CF2328142A; Tue, 11 Jan 2022 11:39:00 +0100 (CET) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4E5D080FD5 for ; Tue, 11 Jan 2022 11:38:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20220111103846epoutp02838e059a77cead3a23061e78f9a10328~JMRnRUjU01572715727epoutp02A for ; Tue, 11 Jan 2022 10:38:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20220111103846epoutp02838e059a77cead3a23061e78f9a10328~JMRnRUjU01572715727epoutp02A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1641897526; bh=9TML2oBJbXrUsrPFBk+jVosBagYQbzytJotDUycuEvI=; h=Subject:To:From:Date:In-Reply-To:References:From; b=BucwJMqHxzzhAqTCLgaJgNx9odvTlXr0M+vPbj2WMgYTMKT80bOM3BsYGxAic5aa5 kIV/oD/uV0mVy54PmJMjIvJ29s84uea+uShi0LeDvqgfaObgBSDeUVep1BX3gKixux 8L8qP9erd8BBoK0Oq+YWVPdf9rp94Y8jniWDbhSw= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20220111103845epcas1p295e6ce3de3bc08447f81e7de86176715~JMRmieMPL3251632516epcas1p2P; Tue, 11 Jan 2022 10:38:45 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.38.236]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4JY6cK2hZbz4x9Q9; Tue, 11 Jan 2022 10:38:41 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 62.A4.08277.13E5DD16; Tue, 11 Jan 2022 19:38:41 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20220111103840epcas1p3238b62a48ab87a4abc5bfc6dd57c1f8c~JMRieWgx30933309333epcas1p32; Tue, 11 Jan 2022 10:38:40 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220111103840epsmtrp19774b24f45434e9f6fe5e9095a9324fd~JMRidtSB50463104631epsmtrp10; Tue, 11 Jan 2022 10:38:40 +0000 (GMT) X-AuditID: b6c32a36-203ff70000002055-41-61dd5e31deeb Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 13.93.29871.03E5DD16; Tue, 11 Jan 2022 19:38:40 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220111103840epsmtip20fb8d70925d76f9f79ab1ff53f2dac5f~JMRiNA2A32940929409epsmtip2i; Tue, 11 Jan 2022 10:38:40 +0000 (GMT) Subject: Re: [PATCH] mmc: dw_mmc: Fixes timeout issue for FIFO mode To: hmz007 , peng.fan@nxp.com, ley.foon.tan@intel.com, u-boot@lists.denx.de From: Jaehoon Chung Message-ID: Date: Tue, 11 Jan 2022 19:39:23 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220111102411.16666-1-hmz007@gmail.com> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnk+LIzCtJLcpLzFFi42LZdlhTT9cw7m6iQctTUYsHL3ayWNzf3cho 8WPVF1aLt3s72R1YPHbOusvusXjPSyaPs3d2MHpsfLeDKYAlKtsmIzUxJbVIITUvOT8lMy/d Vsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2inkkJZYk4pUCggsbhYSd/Opii/tCRV ISO/uMRWKbUgJafAtECvODG3uDQvXS8vtcTK0MDAyBSoMCE7486P76wFv7gqVjQvZW9gPMnR xcjJISFgIvHvwxfWLkYuDiGBHYwSZ9Z9YIFwPjFKHPr+BCrzjVHi9sPJ7DAtO56uZodI7GWU uPnqNVTVe0aJF42rGEGqhAWcJfbsbwbrEBGIl9g7fw1YnE1AR2L7t+NMXYwcHLwCdhJ/tyiB hFkEVCXmrt8KVi4qEClx/8dyMJtXQFDi5MwnLCA2p4CZxIa/P5lBbGYBcYlbT+YzQdjyEtvf zmEGuUFC4CW7xN49/WwQl7pIfL/2gBHCFpZ4dXwL1AdSEi/729ghGpYxSty5/ZcNwlnPKHFg +xKobmOJ/Usng13KLKApsX6XPkRYUWLn77mMEJv5JN597WEFKZEQ4JXoaBOCKFGRuPT6JRPM rrtP/rNC2B4Sc89ehQZWJ6PEhT2n2CYwKsxC8ugsJM/NQvLcLIQrFjCyrGIUSy0ozk1PLTYs MILHd3J+7iZGcIrUMtvBOOntB71DjEwcjIcYJTiYlUR4y2LuJgrxpiRWVqUW5ccXleakFh9i NAUG/URmKdHkfGCSziuJNzSxNDAxMzI2sTA0M1QS51017XSikEB6YklqdmpqQWoRTB8TB6dU A1NpYk/Tf70pgvu3WYTcmvxEKDv0hsdxiSd6qnJ5k3tn795n5v+0IVye+az01StLvLtkDaYl 5Pzb9ublj90s6t9U6jsPshYteSFhEBSbqvKW+VHzxU+cUiqym5z4o/4fM9ZbUyMVyxuy/foe niKmU4Epsb1m1pbL5+pNPhzBGj7JOSzT5ucZ1Xcv6lfcvK14b1ZH/1+OTh3jJ9bmrFmTPm2f Kjbps1LbkwD5kJcPG2KebGhMNnd4ZMl98KFsZYRTl/GCmyeOvZ34+d08+SWKe4//3fTkz8lf a51VNCsvvD0QvLml56LQIimXFVeeCXLfWrBPuG5PoEF35KW9vxruRM3kufL4Y3jrzGsBy9yK 7vMpsRRnJBpqMRcVJwIAeBTq9xoEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsWy7bCSvK5B3N1Eg1UdxhYPXuxksbi/u5HR 4seqL6wWb/d2sjuweOycdZfdY/Gel0weZ+/sYPTY+G4HUwBLFJdNSmpOZllqkb5dAlfGnR/f WQt+cVWsaF7K3sB4kqOLkZNDQsBEYsfT1exdjFwcQgK7GSX2rHzOCJGQkvj8dCpbFyMHkC0s cfhwMUTNW0aJf5N/MIHUCAs4S+zZ38wOYosIxEs8ar8BNaiTUWLdu3NgRWwCOhLbvx1nAhnE K2An8XeLEkiYRUBVYu76rWC9ogKREuuOLwOzeQUEJU7OfMICYnMKmEls+PuTGcRmFlCX+DPv EpQtLnHryXwmCFteYvvbOcwTGAVnIWmfhaRlFpKWWUhaFjCyrGKUTC0ozk3PLTYsMMxLLdcr TswtLs1L10vOz93ECA57Lc0djNtXfdA7xMjEwXiIUYKDWUmEtyzmbqIQb0piZVVqUX58UWlO avEhRmkOFiVx3gtdJ+OFBNITS1KzU1MLUotgskwcnFINTAa+Bvts11t7db1WKfl89EW6QcLW 1Q+k15V4l0VdrDNbHv2+6eWyg9lbnMWYBCOy7BcvKYk98zag5vjp1913WpR+5/Iu6fzF4tAT UWrwW3GfWMSciTf2l7BrLz+u93HTzzBFb9aMkzEsmknHtl01Ur9/+taUS8KN0fMkP/OxLbjE wuVhNO3hU85bk9eE7XprVBT/vo/7yPd+izfrlv3dpbRq+aqoyvkcV96Jt51e1x3wWnJFmwGj byav64KeaeuXmL/rmKOwz2qfFv+O1ltcN0ye+Z7c4V/EVjJF7dT5VM/2N/LKbR2ldizq+g6b l1Xv2uLif/3JPYHIbnfjeyunzH/zyGL2z7Xf//U0LXUvbFRiKc5INNRiLipOBACm2g266gIA AA== X-CMS-MailID: 20220111103840epcas1p3238b62a48ab87a4abc5bfc6dd57c1f8c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220111102419epcas1p17569dac08e8ccb4e3a07e74e70d83023 References: <20220111102411.16666-1-hmz007@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, On 1/11/22 7:24 PM, hmz007 wrote: > Clearing the DTO interrupt should be unnecessary, and it would > potentially result in never receiving this interrupt again. > > Do power-on or reset from uboot for a while can reproduce the issue: > dwmci_data_transfer: Timeout waiting for data! > mmc_load_image_raw_sector: mmc block read error Which board did you test? When you do power-on, is it reproduced every time? > > Tested on NanoPi R4S with SanDisk Extreme PRO 32GB. > > Fixes: 8cb9d3ed3a ("mmc: dw_mmc: Fixes data read when receiving DTO interrupt in FIFO mode") > Signed-off-by: hmz007 Could you change from your ID to your name? Best Regards, Jaehoon Chung > --- > drivers/mmc/dw_mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c > index a949dad574..8fa26b340b 100644 > --- a/drivers/mmc/dw_mmc.c > +++ b/drivers/mmc/dw_mmc.c > @@ -168,7 +168,7 @@ static int dwmci_data_transfer(struct dwmci_host *host, struct mmc_data *data) > if (data->flags == MMC_DATA_READ && > (mask & (DWMCI_INTMSK_RXDR | DWMCI_INTMSK_DTO))) { > dwmci_writel(host, DWMCI_RINTSTS, > - DWMCI_INTMSK_RXDR | DWMCI_INTMSK_DTO); > + DWMCI_INTMSK_RXDR); > while (size) { > ret = dwmci_fifo_ready(host, > DWMCI_FIFO_EMPTY, >