From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 04/22] drm/i915: Hold a ref to the ring while retiring Date: Mon, 18 Mar 2019 13:25:37 +0000 Message-ID: References: <20190318095204.9913-1-chris@chris-wilson.co.uk> <20190318095204.9913-4-chris@chris-wilson.co.uk> <3187f2b5-b5a4-8b9d-54cf-e2b8914e1193@linux.intel.com> <155290544484.4168.2554450930128320701@skylake-alporthouse-com> <178d3bdf-4964-a210-49fa-d840ff2ddaa5@linux.intel.com> <155290659007.4168.7317835572037859614@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAEE9898C8 for ; Mon, 18 Mar 2019 13:25:39 +0000 (UTC) In-Reply-To: <155290659007.4168.7317835572037859614@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzAzLzIwMTkgMTA6NTYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTE4IDEwOjQ2OjI4KQo+Pgo+PiBPbiAxOC8wMy8yMDE5IDEwOjM3 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE5LTAz LTE4IDEwOjMxOjU3KQo+Pj4+Cj4+Pj4gT24gMTgvMDMvMjAxOSAwOTo1MSwgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBBcyB0aGUgZmluYWwgcmVxdWVzdCBvbiBhIHJpbmcgbWF5IGhvbGQgdGhl IHJlZmVyZW5jZSB0byB0aGlzIHJpbmcgKHZpYQo+Pj4+PiByZXRpcmluZyB0aGUgbGFzdCBwaW5u ZWQgY29udGV4dCksIHdlIG1heSBmaW5kIG91cnNlbHZlcyBjaGFzaW5nIGEKPj4+Pj4gZGFuZ2xp bmcgcG9pbnRlciBvbiBjb21wbGV0aW9uIG9mIHRoZSBsaXN0Lgo+Pj4+Pgo+Pj4+PiBBIHF1aWNr IHNvbHV0aW9uIGlzIHRvIGhvbGQgYSByZWZlcmVuY2UgdG8gdGhlIHJpbmcgaXRzZWxmIGFzIHdl IHJldGlyZQo+Pj4+PiBhbG9uZyBpdCBzbyB0aGF0IHdlIG9ubHkgZnJlZSBpdCBhZnRlciB3ZSBz dG9wIGRlcmVmZXJlbmNpbmcgaXQuCj4+Pj4KPj4+PiBJcyB0aGVyZSBhIGd1aWx0eSBjb21taXQg dG8gcmVmZXJlbmNlIGFzIEZpeGVzOiA/Cj4+Pgo+Pj4gSXQgb25seSBiZWNvbWVzIGEgcHJvYmxl bSB3aXRoIHZlbmcgYXMgd2UgZ2FpbiBhbiBpbW1lZGlhdGUgZnJlZSBwYXRoLAo+Pj4gd2hlcmVh cyBhdCB0aGUgbW9tZW50LCBjb250ZXh0IGZyZWVzIGFyZSBkZWZlcnJlZCB1bnRpbCB0aGV5IGNh biBhY3F1aXJlCj4+PiB0aGUgc3RydWN0X211dGV4LiBXZSBjYW5ub3QgaGl0IHRoaXMgcGF0aCBh dCB0aGUgbW9tZW50LCBidXQgdGhhdCB3ZSBoYWQKPj4+IHRvIHVzZSB0aGUgc2FmZSBpdGVyYXRv ciBpbXBsaWVzIHRoYXQgd2Ugd2VyZSBhd2FyZSB0aGF0IHRoZSByaW5nIGl0c2VsZgo+Pj4gY291 bGQgZGlzYXBwZWFyLiBJZiB5b3Ugd2FudGVkIHRvIHBpbiBpdCBvbiBzb21ldGhpbmcsCj4+Pgo+ Pj4gUmVmZXJlbmNlczogYjg4N2Q2MTU0NjI0ICgiZHJtL2k5MTU6IFJldGlyZSByZXF1ZXN0cyBh bG9uZyByaW5ncyIpCj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlz QGNocmlzLXdpbHNvbi5jby51az4KPj4+Pj4gLS0tCj4+Pj4+ICAgICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3JlcXVlc3QuYyAgICAgICAgICB8ICA2ICsrKysrLQo+Pj4+PiAgICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX3R5cGVzLmggICAgfCAgMiArKwo+Pj4+PiAgICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAgICAgICAgICAgfCAgNCArKy0tCj4+ Pj4+ICAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgICAgICB8ICA5 ICsrKysrLS0tLQo+Pj4+PiAgICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl ci5oICAgICAgfCAxMyArKysrKysrKysrKystCj4+Pj4+ICAgICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9zZWxmdGVzdHMvbW9ja19lbmdpbmUuYyB8ICAxICsKPj4+Pj4gICAgIDYgZmlsZXMgY2hhbmdl ZCwgMjcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9yZXF1ZXN0LmMKPj4+Pj4gaW5kZXggOTUzM2E4NWNiMGIzLi4wYTNkOTQ1MTdk MGEgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5j Cj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jCj4+Pj4+IEBA IC0xMzMyLDggKzEzMzIsMTIgQEAgdm9pZCBpOTE1X3JldGlyZV9yZXF1ZXN0cyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqaTkxNSkKPj4+Pj4gICAgICAgICBpZiAoIWk5MTUtPmd0LmFjdGl2ZV9y ZXF1ZXN0cykKPj4+Pj4gICAgICAgICAgICAgICAgIHJldHVybjsKPj4+Pj4gICAgIAo+Pj4+PiAt ICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUocmluZywgdG1wLCAmaTkxNS0+Z3QuYWN0aXZl X3JpbmdzLCBhY3RpdmVfbGluaykKPj4+Pj4gKyAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZl KHJpbmcsIHRtcCwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZpOTE1LT5n dC5hY3RpdmVfcmluZ3MsIGFjdGl2ZV9saW5rKSB7Cj4+Pj4+ICsgICAgICAgICAgICAgaW50ZWxf cmluZ19nZXQocmluZyk7IC8qIGxhc3QgcnEgaG9sZHMgcmVmZXJlbmNlISAqLwo+Pj4+PiAgICAg ICAgICAgICAgICAgcmluZ19yZXRpcmVfcmVxdWVzdHMocmluZyk7Cj4+Pj4+ICsgICAgICAgICAg ICAgaW50ZWxfcmluZ19wdXQocmluZyk7Cj4+Pj4+ICsgICAgIH0KPj4+Pgo+Pj4+IFdoZXJlIGRv ZXMgaXQgY2hhc2UgYSBkYW5nbGluZyBwb2ludGVyPyBJdCB1c2VkIHRoZSBzYWZlIGl0ZXJhdG9y IGFscmVhZHkuCj4+Pgo+Pj4gSW5zaWRlIHJpbmdfcmV0aXJlX3JlcXVlc3RzKCk7IHRoZSB1c2Ug b2YgX3NhZmUgaGVyZSBhY3R1YWxseSBpbXBsaWVzIHdlCj4+PiBtZXQgdGhpcyBwcm9ibGVtIGFs cmVhZHkgOikKPj4KPj4gSSBnZXQgaXQsIHRoZSBpc3N1ZSBpcyBkdXJpbmcgcmluZy0+cmVxdWVz dF9saXN0IGl0ZXJhdGlvbiBpbgo+PiByaW5nX3JldGlyZV9yZXF1ZXN0cy4gSG93IGFib3V0IG1v dmUgcmluZyBwaW5uaW5nIGluIHRoZXJlIHNvIGl0IGlzIGNsZWFyZXI/Cj4gCj4gSXQncyBvbmx5 IHRoaXMgcGF0aCB0aGF0IGlzIGFmZmVjdGVkLiBUaGF0IG1heWUgYmVjb21lcyBjbGVhcmVyIHdo ZW4gd2UKPiByZXRpcmUgYWxvbmcgdGltZWxpbmVzIGFuZCBub3QgcmluZ3MsIHdoaWNoIGlzIHRo ZSBwYXRjaHNldCBJIHdhbnRlZCB0bwo+IGxhbmQgdG8gZml4IHRoaXMsIGJ1dCBmaWd1cmVkIHRo aXMgd2FzIGEgdGlueSBmaXggZm9yIG5vdy4KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKSSBmYWlsZWQgdG8gZmluZCBhIHNob3J0IGFuZCBj bGVhciBzdWdnZXN0aW9uIGZvciBtYWtpbmcgdGhlIGNvbW1lbnQgCm1vcmUgcHJlY2lzZS4KClJl Z2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4