From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fB6Sl-0004Ut-Lu for qemu-devel@nongnu.org; Tue, 24 Apr 2018 18:31:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fB6Si-00062F-GT for qemu-devel@nongnu.org; Tue, 24 Apr 2018 18:31:03 -0400 References: <20180424214550.32549-1-lersek@redhat.com> <20180424214550.32549-2-lersek@redhat.com> From: Eric Blake Message-ID: Date: Tue, 24 Apr 2018 17:30:51 -0500 MIME-Version: 1.0 In-Reply-To: <20180424214550.32549-2-lersek@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VLTeZgxgjZmzHeAksju4JsE2rjRYkTO3t" Subject: Re: [Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini , Peter Crosthwaite , Richard Henderson , qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VLTeZgxgjZmzHeAksju4JsE2rjRYkTO3t From: Eric Blake To: Laszlo Ersek , qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini , Peter Crosthwaite , Richard Henderson , qemu-stable@nongnu.org Message-ID: Subject: Re: [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast References: <20180424214550.32549-1-lersek@redhat.com> <20180424214550.32549-2-lersek@redhat.com> In-Reply-To: <20180424214550.32549-2-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/24/2018 04:45 PM, Laszlo Ersek wrote: > Commit ca230ff33f89 added added the @arch field to @CpuInfoFast, but it= s/added added/added/ > failed to set the new field in qmp_query_cpus_fast(), when TARGET_S390X= > was not defined. The updated @query-cpus-fast example in > "qapi-schema.json" showed "arch":"x86" only because qmp_query_cpus_fast= () > calls g_malloc0() to allocate CpuInfoFast, and the CPU_INFO_ARCH_X86 en= um > constant is generated with value 0. >=20 > All @arch values other than @s390 implied the @CpuInfoOther sub-struct = for > @CpuInfoFast -- at the time of writing the patch --, thus no fields oth= er > than @arch needed to be set when TARGET_S390X was not defined. Set @arc= h > now, by copying the corresponding assignments from qmp_query_cpus(). Perhaps worth mentioning that the riscv architecture shows up as 'other' in this patch? (But that gets cleaned up in the next one, so no big deal= ) >=20 > Cc: Eric Blake > Cc: Markus Armbruster > Cc: Paolo Bonzini > Cc: Peter Crosthwaite > Cc: Richard Henderson > Cc: qemu-stable@nongnu.org > Fixes: ca230ff33f89bf7102cbfbc2328716da6750aaed > Signed-off-by: Laszlo Ersek > --- >=20 Reviewed-by: Eric Blake --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org --VLTeZgxgjZmzHeAksju4JsE2rjRYkTO3t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEzBAEBCAAdFiEEccLMIrHEYCkn0vOqp6FrSiUnQ2oFAlrfsBsACgkQp6FrSiUn Q2pJsggAgjM9bO26B/Kw0YrOQrV4kWDSq3guy/ksBy+3nUcsVxbkut88kqYV7Ghy sBr8SDFKXUlkkMFG28QrTkJauI8/OkE/wcSiTmkf0+NoiWgimxFSIIzIjrexVtbC 1uvCp1yKJL1IAtKUj+3SCr+LFrg0Ht0rh2lZOZ6ZtZV5c20xStY3pWQkB+7taXn4 bUBSu0P18nnVdvK3ou+3vsFOl+nMZlYzV9VVbMhm7hkwpcafTMAxKaOKifAbNVSG g+pdJMEIJgdZGVzPSeypTkIi9a0rxYLJQPFCOEHCdGeWDVZQfQ/AV78KvkP7AEev Bw4Jyv1CFwKppzXJBmYSIBueSusxFQ== =nwJy -----END PGP SIGNATURE----- --VLTeZgxgjZmzHeAksju4JsE2rjRYkTO3t--