From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C40C433EF for ; Sat, 21 May 2022 16:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343525AbiEUQiI (ORCPT ); Sat, 21 May 2022 12:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245753AbiEUQiD (ORCPT ); Sat, 21 May 2022 12:38:03 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E0DC62A19 for ; Sat, 21 May 2022 09:38:02 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id s5so12624564ljd.10 for ; Sat, 21 May 2022 09:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=WXL0Kr6NJlPCFE6AkYnbXRqpsriCeDIrboyr2mKYIIo=; b=azl0IXyBsAkxqX4vnBtqgFslhmNTs6lzDHtxK88VAXLucBey8Th1FgJxUa7U3KmkKX a2cSakrrd3z88D0GZSsfoNCi+sxTt7Cs1SfxFhkIEMrifezGXM/r9N8lfLaGjdnMrnbS lxJ6kBnqXJk8dTeheK+GNRV0GcO697RcNQXy8Rh1czDZ+fZQV/SnLAWYNvakQ6NNyqxI 2mqNYy+/djuO3FLdUA/Qtk90HJNw/IseTJqpAm8vYbpT8jO1zHtXLaI1SjfUbas0SsY+ sHpo/9jWTXqp52j71o/GX18cDRYXA9Q4eqP/cXswFRq2wO9pAWMI6JaDPuxCUeyCjq7E 0ROQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=WXL0Kr6NJlPCFE6AkYnbXRqpsriCeDIrboyr2mKYIIo=; b=TGE9RQzN9iaAoXj4j1hYY52WiJTLI+fN4wEuQ3DA/paDjm5GUoasD+ztIwNU3Gmmpw v6rwOHlZO7IS5X5x3U4L5b1hW36+Xn0ngwDhXyjWS+8COoM51+kRHNh8mQ+Fzo0L0wUe 0bWG3hXHw5OEDoFLjofNn4E8vcqwPyyD9jtoFtlrV5gBpSOj+N88hd1b+Y94McKLywUO xCACEYO3K+VNcfQlIMjyCf4znDiReBNYsM5HqGDk0SurMw0axt4ba0AEtiwaEvit1m5d djSffHLFL+rsA2SegwuapBB0IQWqyMwuwYRNGUsyhRnUdfPUNuDxzGstKWjXqbPTsIv2 /HmQ== X-Gm-Message-State: AOAM531RWKoxoRIk/yuP20h6jlFKgxIVWfXPcS58y0m+vMDQtY5XNBV/ 5+iAtaxwUetzH8vPCffD3/sItQ== X-Google-Smtp-Source: ABdhPJz9guAKE14vLO2t185SB1774V0K9APnw2MBpEnkasC6qr9TkZkPhtlY2NCcTThOGAH/Yv6RAQ== X-Received: by 2002:a05:651c:890:b0:248:5819:b949 with SMTP id d16-20020a05651c089000b002485819b949mr8442007ljq.476.1653151080713; Sat, 21 May 2022 09:38:00 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.185]) by smtp.gmail.com with ESMTPSA id d19-20020a2e3313000000b0024b14fa6061sm772690ljc.1.2022.05.21.09.37.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 May 2022 09:38:00 -0700 (PDT) Message-ID: Date: Sat, 21 May 2022 19:37:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 From: Vasily Averin Subject: [PATCH mm v2 3/9] memcg: enable accounting for kernfs iattrs To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , cgroups@vger.kernel.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernfs nodes are quite small kernel objects, however there are few scenarios where it consumes significant piece of all allocated memory: 1) creating a new netdevice allocates ~50Kb of memory, where ~10Kb was allocated for 80+ kernfs nodes. 2) cgroupv2 mkdir allocates ~60Kb of memory, ~10Kb of them are kernfs structures. 3) Shakeel Butt reports that Google has workloads which create 100s of subcontainers and they have observed high system overhead without memcg accounting of kernfs. Usually new kernfs node creates few other objects: Allocs Alloc Allocation number size -------------------------------------------- 1 + 128 (__kernfs_new_node+0x4d) kernfs node 1 + 88 (__kernfs_iattrs+0x57) kernfs iattrs 1 + 96 (simple_xattr_alloc+0x28) simple_xattr, can grow over 4Kb 1 32 (simple_xattr_set+0x59) 1 8 (__kernfs_new_node+0x30) '+' -- to be accounted This patch enables accounting for kernfs_iattrs_cache slab cache Signed-off-by: Vasily Averin Reviewed-by: Roman Gushchin Reviewed-by: Michal Koutný Acked-by: Shakeel Butt --- fs/kernfs/mount.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c index 3ac4191b1c40..40e896c7c86b 100644 --- a/fs/kernfs/mount.c +++ b/fs/kernfs/mount.c @@ -397,5 +397,6 @@ void __init kernfs_init(void) /* Creates slab cache for kernfs inode attributes */ kernfs_iattrs_cache = kmem_cache_create("kernfs_iattrs_cache", sizeof(struct kernfs_iattrs), - 0, SLAB_PANIC, NULL); + 0, SLAB_PANIC | SLAB_ACCOUNT, + NULL); } -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: [PATCH mm v2 3/9] memcg: enable accounting for kernfs iattrs Date: Sat, 21 May 2022 19:37:59 +0300 Message-ID: References: Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=WXL0Kr6NJlPCFE6AkYnbXRqpsriCeDIrboyr2mKYIIo=; b=azl0IXyBsAkxqX4vnBtqgFslhmNTs6lzDHtxK88VAXLucBey8Th1FgJxUa7U3KmkKX a2cSakrrd3z88D0GZSsfoNCi+sxTt7Cs1SfxFhkIEMrifezGXM/r9N8lfLaGjdnMrnbS lxJ6kBnqXJk8dTeheK+GNRV0GcO697RcNQXy8Rh1czDZ+fZQV/SnLAWYNvakQ6NNyqxI 2mqNYy+/djuO3FLdUA/Qtk90HJNw/IseTJqpAm8vYbpT8jO1zHtXLaI1SjfUbas0SsY+ sHpo/9jWTXqp52j71o/GX18cDRYXA9Q4eqP/cXswFRq2wO9pAWMI6JaDPuxCUeyCjq7E 0ROQ== Content-Language: en-US In-Reply-To: List-ID: Content-Type: text/plain; charset="macroman" To: Andrew Morton Cc: kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org a2VybmZzIG5vZGVzIGFyZSBxdWl0ZSBzbWFsbCBrZXJuZWwgb2JqZWN0cywgaG93ZXZlciB0aGVy ZSBhcmUgZmV3CnNjZW5hcmlvcyB3aGVyZSBpdCBjb25zdW1lcyBzaWduaWZpY2FudCBwaWVjZSBv ZiBhbGwgYWxsb2NhdGVkIG1lbW9yeToKCjEpIGNyZWF0aW5nIGEgbmV3IG5ldGRldmljZSBhbGxv Y2F0ZXMgfjUwS2Igb2YgbWVtb3J5LCB3aGVyZSB+MTBLYgogICB3YXMgYWxsb2NhdGVkIGZvciA4 MCsga2VybmZzIG5vZGVzLgoKMikgY2dyb3VwdjIgbWtkaXIgYWxsb2NhdGVzIH42MEtiIG9mIG1l bW9yeSwgfjEwS2Igb2YgdGhlbSBhcmUga2VybmZzCiAgIHN0cnVjdHVyZXMuCgozKSBTaGFrZWVs IEJ1dHQgcmVwb3J0cyB0aGF0IEdvb2dsZSBoYXMgd29ya2xvYWRzIHdoaWNoIGNyZWF0ZSAxMDBz CiAgIG9mIHN1YmNvbnRhaW5lcnMgYW5kIHRoZXkgaGF2ZSBvYnNlcnZlZCBoaWdoIHN5c3RlbSBv dmVyaGVhZAogICB3aXRob3V0IG1lbWNnIGFjY291bnRpbmcgb2Yga2VybmZzLgoKVXN1YWxseSBu ZXcga2VybmZzIG5vZGUgY3JlYXRlcyBmZXcgb3RoZXIgb2JqZWN0czoKCkFsbG9jcyAgQWxsb2Mg ICAgQWxsb2NhdGlvbgpudW1iZXIgIHNpemUKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KMSAgICsgIDEyOCAgICAgIChfX2tlcm5mc19uZXdfbm9kZSsweDRkKSAg ICAgICAga2VybmZzIG5vZGUKMSAgICsgICA4OCAgICAgIChfX2tlcm5mc19pYXR0cnMrMHg1Nykg ICAgICAgICAga2VybmZzIGlhdHRycwoxICAgKyAgIDk2ICAgICAgKHNpbXBsZV94YXR0cl9hbGxv YysweDI4KSAgICAgICBzaW1wbGVfeGF0dHIsIGNhbiBncm93IG92ZXIgNEtiCjEgICAgICAgMzIg ICAgICAoc2ltcGxlX3hhdHRyX3NldCsweDU5KQoxICAgICAgIDggICAgICAgKF9fa2VybmZzX25l d19ub2RlKzB4MzApCgonKycgLS0gdG8gYmUgYWNjb3VudGVkCgpUaGlzIHBhdGNoIGVuYWJsZXMg YWNjb3VudGluZyBmb3Iga2VybmZzX2lhdHRyc19jYWNoZSBzbGFiIGNhY2hlCgpTaWduZWQtb2Zm LWJ5OiBWYXNpbHkgQXZlcmluIDx2dnMtR0VGQVF6Wlg3cjhkbm0reVJPZkUwQUBwdWJsaWMuZ21h bmUub3JnPgpSZXZpZXdlZC1ieTogUm9tYW4gR3VzaGNoaW4gPHJvbWFuLmd1c2hjaGluLWZ4VVZY ZnRJRkRueUcxekVPYlh0ZkFAcHVibGljLmdtYW5lLm9yZz4KUmV2aWV3ZWQtYnk6IE1pY2hhbCBL b3V0bsO9IDxta291dG55LUlCaTlSRy9iNjdrQHB1YmxpYy5nbWFuZS5vcmc+CkFja2VkLWJ5OiBT aGFrZWVsIEJ1dHQgPHNoYWtlZWxiLWhwSXFzRDRBS2xmUVQwZFpSK0FsZkFAcHVibGljLmdtYW5l Lm9yZz4KLS0tCiBmcy9rZXJuZnMvbW91bnQuYyB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZnMva2VybmZzL21vdW50 LmMgYi9mcy9rZXJuZnMvbW91bnQuYwppbmRleCAzYWM0MTkxYjFjNDAuLjQwZTg5NmM3Yzg2YiAx MDA2NDQKLS0tIGEvZnMva2VybmZzL21vdW50LmMKKysrIGIvZnMva2VybmZzL21vdW50LmMKQEAg LTM5Nyw1ICszOTcsNiBAQCB2b2lkIF9faW5pdCBrZXJuZnNfaW5pdCh2b2lkKQogCS8qIENyZWF0 ZXMgc2xhYiBjYWNoZSBmb3Iga2VybmZzIGlub2RlIGF0dHJpYnV0ZXMgKi8KIAlrZXJuZnNfaWF0 dHJzX2NhY2hlICA9IGttZW1fY2FjaGVfY3JlYXRlKCJrZXJuZnNfaWF0dHJzX2NhY2hlIiwKIAkJ CQkJICAgICAgc2l6ZW9mKHN0cnVjdCBrZXJuZnNfaWF0dHJzKSwKLQkJCQkJICAgICAgMCwgU0xB Ql9QQU5JQywgTlVMTCk7CisJCQkJCSAgICAgIDAsIFNMQUJfUEFOSUMgfCBTTEFCX0FDQ09VTlQs CisJCQkJCSAgICAgIE5VTEwpOwogfQotLSAKMi4zNi4xCgo=