From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output Date: Thu, 20 Apr 2017 10:55:34 +0100 Message-ID: References: <20170416103546.3021-1-contact@paulk.fr> <1492443526.12267.4.camel@paulk.fr> <1492505196.2014.0.camel@paulk.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1492505196.2014.0.camel-W9ppeneeCTY@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Kocialkowski , Geert Uytterhoeven Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Thierry Reding , Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , Linux PWM List , Linux Fbdev development list , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 18/04/17 09:46, Paul Kocialkowski wrote: > Hi, > > Le lundi 17 avril 2017 à 21:36 +0200, Geert Uytterhoeven a écrit : >> On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski wrote: >>> Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit : >>>> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski >>>> wrote: >>>>> The move to a dedicated pwm_backlight_initial_power_state function in >>>>> commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition >>>>> to set the enable gpio as output. This breaks specific use cases using >>>>> that GPIO, such as tegra124-based nyan Chromebooks where backlight >>>>> stopped working. >>>>> >>>>> This puts the condition back to the way it was before the move. >>>>> >>>>> Signed-off-by: Paul Kocialkowski >>>> >>>> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented >>>> .get_direction()" >>>> (https://lkml.org/lkml/2017/4/4/225) fix your issue? >>> >>> This definitely solves the issue! >>> >>> Since this fixes broken backlight (that, in turn, makes systems unusable), >>> perhaps this should be included in the next rc cycle? >> >> You mean v4.11 final, as there probably won't be another rc? >> Yes! > > I'm all for it! Thanks for keeping our attention on this. I sent a PR yesterday (and hope my GPG key has attracted enough signatures). Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030744AbdDTJzk (ORCPT ); Thu, 20 Apr 2017 05:55:40 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36582 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S944175AbdDTJzh (ORCPT ); Thu, 20 Apr 2017 05:55:37 -0400 Subject: Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output To: Paul Kocialkowski , Geert Uytterhoeven References: <20170416103546.3021-1-contact@paulk.fr> <1492443526.12267.4.camel@paulk.fr> <1492505196.2014.0.camel@paulk.fr> Cc: "linux-kernel@vger.kernel.org" , Thierry Reding , Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , Linux PWM List , Linux Fbdev development list , linux-tegra@vger.kernel.org From: Daniel Thompson Message-ID: Date: Thu, 20 Apr 2017 10:55:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1492505196.2014.0.camel@paulk.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/04/17 09:46, Paul Kocialkowski wrote: > Hi, > > Le lundi 17 avril 2017 à 21:36 +0200, Geert Uytterhoeven a écrit : >> On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski wrote: >>> Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit : >>>> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski >>>> wrote: >>>>> The move to a dedicated pwm_backlight_initial_power_state function in >>>>> commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition >>>>> to set the enable gpio as output. This breaks specific use cases using >>>>> that GPIO, such as tegra124-based nyan Chromebooks where backlight >>>>> stopped working. >>>>> >>>>> This puts the condition back to the way it was before the move. >>>>> >>>>> Signed-off-by: Paul Kocialkowski >>>> >>>> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented >>>> .get_direction()" >>>> (https://lkml.org/lkml/2017/4/4/225) fix your issue? >>> >>> This definitely solves the issue! >>> >>> Since this fixes broken backlight (that, in turn, makes systems unusable), >>> perhaps this should be included in the next rc cycle? >> >> You mean v4.11 final, as there probably won't be another rc? >> Yes! > > I'm all for it! Thanks for keeping our attention on this. I sent a PR yesterday (and hope my GPG key has attracted enough signatures). Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Date: Thu, 20 Apr 2017 09:55:34 +0000 Subject: Re: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output Message-Id: List-Id: References: <20170416103546.3021-1-contact@paulk.fr> <1492443526.12267.4.camel@paulk.fr> <1492505196.2014.0.camel@paulk.fr> In-Reply-To: <1492505196.2014.0.camel-W9ppeneeCTY@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Paul Kocialkowski , Geert Uytterhoeven Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Thierry Reding , Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , Linux PWM List , Linux Fbdev development list , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 18/04/17 09:46, Paul Kocialkowski wrote: > Hi, > > Le lundi 17 avril 2017 à 21:36 +0200, Geert Uytterhoeven a écrit : >> On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski wrote: >>> Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit : >>>> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski >>>> wrote: >>>>> The move to a dedicated pwm_backlight_initial_power_state function in >>>>> commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition >>>>> to set the enable gpio as output. This breaks specific use cases using >>>>> that GPIO, such as tegra124-based nyan Chromebooks where backlight >>>>> stopped working. >>>>> >>>>> This puts the condition back to the way it was before the move. >>>>> >>>>> Signed-off-by: Paul Kocialkowski >>>> >>>> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented >>>> .get_direction()" >>>> (https://lkml.org/lkml/2017/4/4/225) fix your issue? >>> >>> This definitely solves the issue! >>> >>> Since this fixes broken backlight (that, in turn, makes systems unusable), >>> perhaps this should be included in the next rc cycle? >> >> You mean v4.11 final, as there probably won't be another rc? >> Yes! > > I'm all for it! Thanks for keeping our attention on this. I sent a PR yesterday (and hope my GPG key has attracted enough signatures). Daniel.