All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Parant <C.Parant@phytec.fr>
To: "linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"s.trumtrar@pengutronix.de" <s.trumtrar@pengutronix.de>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"upstream@lists.phytec.de" <upstream@lists.phytec.de>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
	"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v9 10/10] ARM: dts: stm32: add STM32MP1-based Phytec board
Date: Tue, 23 May 2023 14:58:15 +0000	[thread overview]
Message-ID: <e5b4ef445160ac0ddbaa25f12118a253ad21542a.camel@phytec.fr> (raw)
In-Reply-To: <20230505060158.16516-11-s.trumtrar@pengutronix.de>

Hi Steffen,

Thank you for upstreaming our phyBOARD-Sargas device tree. We were also
planing to work on that too.
If this patch is not applied upstream yet, would it be possible to
rename the .dts file ?

In the beginning, we named the dts files after our Yocto machines,
which is probably the version you got. But now we renamed them after
our baseboard names, like with our other platforms.
So it would make sense to have the stm32 baseboard named the same way,
changing "stm32mp157c-phycore-stm32mp1-3.dts" to "stm32mp157c-phyboard-
sargas-rdk-emmc.dts".

"model" and "compatible" can also be modified this way with this naming
convention :

/ {
    model = "PHYTEC phyBOARD-Sargas STM32MP157C with eMMC";
    compatible = "phytec,stm32mp157c-phyboard-sargas-rdk-emmc",
             "phytec,stm32mp157c-phycore-som", "st,stm32mp157";
};

Thanks.

Best regards,
Christophe Parant

Le vendredi 05 mai 2023 à 08:01 +0200, Steffen Trumtrar a écrit :
> Add the Phytec STM32MP1-3 Dev board. The devboard uses a Phytec
> stm32m157c-som.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> 
> Notes:
>     Changes since v7:
>        - remove secure-status for sdmmc
> 
>  arch/arm/boot/dts/Makefile                    |  3 +-
>  .../dts/stm32mp157c-phycore-stm32mp1-3.dts    | 60
> +++++++++++++++++++
>  2 files changed, 62 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-
> 3.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index efe4152e5846..dfa9a7477c82 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1252,7 +1252,8 @@ dtb-$(CONFIG_ARCH_STM32) += \
>         stm32mp157c-ev1.dtb \
>         stm32mp157c-ev1-scmi.dtb \
>         stm32mp157c-lxa-mc1.dtb \
> -       stm32mp157c-odyssey.dtb
> +       stm32mp157c-odyssey.dtb \
> +       stm32mp157c-phycore-stm32mp1-3.dtb
>  dtb-$(CONFIG_MACH_SUN4I) += \
>         sun4i-a10-a1000.dtb \
>         sun4i-a10-ba10-tvbox.dtb \
> diff --git a/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts
> b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts
> new file mode 100644
> index 000000000000..28d7203264ce
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts
> @@ -0,0 +1,60 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * Copyright (C) Phytec GmbH 2019-2020 - All Rights Reserved
> + * Author: Dom VOVARD <dom.vovard@linrt.com>.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/pinctrl/stm32-pinfunc.h>
> +#include "stm32mp157.dtsi"
> +#include "stm32mp15xc.dtsi"
> +#include "stm32mp15xxac-pinctrl.dtsi"
> +#include "stm32mp157c-phycore-stm32mp15-som.dtsi"
> +
> +/ {
> +       model = "PHYTEC phyCORE-STM32MP1-3 Dev Board";
> +       compatible = "phytec,phycore-stm32mp1-3",
> +                    "phytec,phycore-stm32mp157c-som",
> "st,stm32mp157";
> +
> +       aliases {
> +               mmc0 = &sdmmc1;
> +               mmc1 = &sdmmc2;
> +               mmc2 = &sdmmc3;
> +               serial0 = &uart4;
> +               serial1 = &usart3;
> +               serial2 = &usart1;
> +       };
> +};
> +
> +&cryp1 {
> +       status = "okay";
> +};
> +
> +&dts {
> +       status = "okay";
> +};
> +
> +&fmc {
> +       status = "disabled";
> +};
> +
> +&gpu {
> +       status = "okay";
> +};
> +
> +&i2c4_eeprom {
> +       status = "okay";
> +};
> +
> +&i2c4_rtc {
> +       status = "okay";
> +};
> +
> +&qspi {
> +       status = "okay";
> +};
> +
> +&sdmmc2 {
> +       status = "okay";
> +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Christophe Parant <C.Parant@phytec.fr>
To: "linux-stm32@st-md-mailman.stormreply.com" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	"s.trumtrar@pengutronix.de" <s.trumtrar@pengutronix.de>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"upstream@lists.phytec.de" <upstream@lists.phytec.de>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
	"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v9 10/10] ARM: dts: stm32: add STM32MP1-based Phytec board
Date: Tue, 23 May 2023 14:58:15 +0000	[thread overview]
Message-ID: <e5b4ef445160ac0ddbaa25f12118a253ad21542a.camel@phytec.fr> (raw)
In-Reply-To: <20230505060158.16516-11-s.trumtrar@pengutronix.de>

Hi Steffen,

Thank you for upstreaming our phyBOARD-Sargas device tree. We were also
planing to work on that too.
If this patch is not applied upstream yet, would it be possible to
rename the .dts file ?

In the beginning, we named the dts files after our Yocto machines,
which is probably the version you got. But now we renamed them after
our baseboard names, like with our other platforms.
So it would make sense to have the stm32 baseboard named the same way,
changing "stm32mp157c-phycore-stm32mp1-3.dts" to "stm32mp157c-phyboard-
sargas-rdk-emmc.dts".

"model" and "compatible" can also be modified this way with this naming
convention :

/ {
    model = "PHYTEC phyBOARD-Sargas STM32MP157C with eMMC";
    compatible = "phytec,stm32mp157c-phyboard-sargas-rdk-emmc",
             "phytec,stm32mp157c-phycore-som", "st,stm32mp157";
};

Thanks.

Best regards,
Christophe Parant

Le vendredi 05 mai 2023 à 08:01 +0200, Steffen Trumtrar a écrit :
> Add the Phytec STM32MP1-3 Dev board. The devboard uses a Phytec
> stm32m157c-som.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> 
> Notes:
>     Changes since v7:
>        - remove secure-status for sdmmc
> 
>  arch/arm/boot/dts/Makefile                    |  3 +-
>  .../dts/stm32mp157c-phycore-stm32mp1-3.dts    | 60
> +++++++++++++++++++
>  2 files changed, 62 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-
> 3.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index efe4152e5846..dfa9a7477c82 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1252,7 +1252,8 @@ dtb-$(CONFIG_ARCH_STM32) += \
>         stm32mp157c-ev1.dtb \
>         stm32mp157c-ev1-scmi.dtb \
>         stm32mp157c-lxa-mc1.dtb \
> -       stm32mp157c-odyssey.dtb
> +       stm32mp157c-odyssey.dtb \
> +       stm32mp157c-phycore-stm32mp1-3.dtb
>  dtb-$(CONFIG_MACH_SUN4I) += \
>         sun4i-a10-a1000.dtb \
>         sun4i-a10-ba10-tvbox.dtb \
> diff --git a/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts
> b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts
> new file mode 100644
> index 000000000000..28d7203264ce
> --- /dev/null
> +++ b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp1-3.dts
> @@ -0,0 +1,60 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
> +/*
> + * Copyright (C) Phytec GmbH 2019-2020 - All Rights Reserved
> + * Author: Dom VOVARD <dom.vovard@linrt.com>.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/pinctrl/stm32-pinfunc.h>
> +#include "stm32mp157.dtsi"
> +#include "stm32mp15xc.dtsi"
> +#include "stm32mp15xxac-pinctrl.dtsi"
> +#include "stm32mp157c-phycore-stm32mp15-som.dtsi"
> +
> +/ {
> +       model = "PHYTEC phyCORE-STM32MP1-3 Dev Board";
> +       compatible = "phytec,phycore-stm32mp1-3",
> +                    "phytec,phycore-stm32mp157c-som",
> "st,stm32mp157";
> +
> +       aliases {
> +               mmc0 = &sdmmc1;
> +               mmc1 = &sdmmc2;
> +               mmc2 = &sdmmc3;
> +               serial0 = &uart4;
> +               serial1 = &usart3;
> +               serial2 = &usart1;
> +       };
> +};
> +
> +&cryp1 {
> +       status = "okay";
> +};
> +
> +&dts {
> +       status = "okay";
> +};
> +
> +&fmc {
> +       status = "disabled";
> +};
> +
> +&gpu {
> +       status = "okay";
> +};
> +
> +&i2c4_eeprom {
> +       status = "okay";
> +};
> +
> +&i2c4_rtc {
> +       status = "okay";
> +};
> +
> +&qspi {
> +       status = "okay";
> +};
> +
> +&sdmmc2 {
> +       status = "okay";
> +};

  reply	other threads:[~2023-05-23 14:58 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  6:01 [PATCH v9 00/10] ARM: stm32: add support for Phycore STM32MP1 Steffen Trumtrar
2023-05-05  6:01 ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 01/10] ARM: dts: stm32: Add alternate pinmux for ethernet Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 02/10] ARM: dts: stm32: Add alternate pinmux for sai2b Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 03/10] ARM: dts: stm32: Add new pinmux for sdmmc1_b4 Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 04/10] ARM: dts: stm32: Add new pinmux for sdmmc2_d47 Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 05/10] ARM: dts: stm32: Add pinmux for USART1 pins Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 06/10] ARM: dts: stm32: Add idle/sleep pinmux for USART3 Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 07/10] ARM: dts: stm32: Add sleep pinmux for SPI1 pins_a Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 08/10] dt-bindings: arm: stm32: Add Phytec STM32MP1 board Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 09/10] ARM: dts: stm32: add STM32MP1-based Phytec SoM Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-05  6:01 ` [PATCH v9 10/10] ARM: dts: stm32: add STM32MP1-based Phytec board Steffen Trumtrar
2023-05-05  6:01   ` Steffen Trumtrar
2023-05-23 14:58   ` Christophe Parant [this message]
2023-05-23 14:58     ` Christophe Parant
2023-06-23  8:59     ` Christophe Parant
2023-06-23  8:59       ` Christophe Parant
2023-06-23 10:39       ` Alexandre TORGUE
2023-06-23 10:39         ` Alexandre TORGUE
2023-05-16 15:16 ` [PATCH v9 00/10] ARM: stm32: add support for Phycore STM32MP1 Alexandre TORGUE
2023-05-16 15:16   ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5b4ef445160ac0ddbaa25f12118a253ad21542a.camel@phytec.fr \
    --to=c.parant@phytec.fr \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=s.trumtrar@pengutronix.de \
    --cc=upstream@lists.phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.