From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8655FC07E99 for ; Sat, 10 Jul 2021 02:53:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 643E2613BE for ; Sat, 10 Jul 2021 02:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231896AbhGJC4d (ORCPT ); Fri, 9 Jul 2021 22:56:33 -0400 Received: from relay.sw.ru ([185.231.240.75]:37668 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230317AbhGJC4c (ORCPT ); Fri, 9 Jul 2021 22:56:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:From: Subject; bh=DvvjK9wvjret8pU1Pj5Lq7SIL4y20uZLc1aae0vdGec=; b=DICbeliw9gTCfmXZ6 umqBTcFC6y0z4aLCHjZmYIoFqQvlqz+AFm5DePt69Xp/wwE8WE4p2vLK1z+sun2ewR3KPNZcW9kXq gYEZzINKkFr5fRrNoNX8mP+K9DKzBwe+xyGpSqh+apJ06q4HjcKAOXsEzF4HgS3t2VIEVdXs+OPBw =; Received: from [10.93.0.56] by relay.sw.ru with esmtp (Exim 4.94.2) (envelope-from ) id 1m237g-003W99-5k; Sat, 10 Jul 2021 05:53:44 +0300 Subject: Re: [PATCH IPV6 v2 1/4] ipv6: allocate enough headroom in ip6_finish_output2() To: David Miller Cc: yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1cbf3c7b-455e-f3a5-cc2c-c18ce8be4ce1@gmail.com> <4f6a2b28-a137-2e19-bf62-5a8767d0d0ac@virtuozzo.com> <20210709.105847.2246373390622335461.davem@davemloft.net> From: Vasily Averin Message-ID: Date: Sat, 10 Jul 2021 05:53:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210709.105847.2246373390622335461.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear David, I'm happy to hear you again. On 7/9/21 8:58 PM, David Miller wrote: > Please do not use inline in foo.c files, let the compiler decde. Thank you for the hint, I did not know it, and will follow him next time. This time I'm going to move this helper somewhere anyway: either to net/core/skbuff.c as exported function where it will lost inline anyway, or to include/linux/skbuff.h where inline is (it seems?) acceptable. Could you please help me to find better name for this helper? I would like to change its current name: 'skb_expand_head' looks very similar to widely used 'pskb_expand_head' but have different semantic. I afraid they can be accidentally misused in future. Thank you, Vasily Averin.