From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 955B6C433ED for ; Fri, 9 Apr 2021 06:07:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E86E61168 for ; Fri, 9 Apr 2021 06:07:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231440AbhDIGHX (ORCPT ); Fri, 9 Apr 2021 02:07:23 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:53001 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230219AbhDIGHX (ORCPT ); Fri, 9 Apr 2021 02:07:23 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 6DB6F5806D9; Fri, 9 Apr 2021 02:07:10 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Fri, 09 Apr 2021 02:07:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=xv1zETl1iB5irtIRE5Ue6naQ2DCplT+ Qow5AJr+u6Gs=; b=pEb+ianfzwAfRDEaTJOMTUMGKZNZYn8XI6eeOcIkxBcld2V 0M0yMx7Ah9L4jojZhSlx4UtoSkAxW2Sr+BMNKvQoO7YIfRSTdGy4sR1AD21Szs27 QrM2oVZsX3Hwf7vdRudLdaGCs3savGhxKWLevdjJW/FMWR3BhLFt/MVWSE8ZrEQb M7Ar/Xi5NIVYWVhuK4+UoezUSbdQMEd4CIvReWCPtK6ofhCoqeq2cvkIT3IWt9tA tUiSZukAr+mAJTCB3BZqxOOx7PtBUlQ96Kz85MV7TUq+8kx0Q4QD0SHKW213E4IG 3O2KyER/4YH6taX4pASQVGSZbCYopHNoKiipe7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xv1zET l1iB5irtIRE5Ue6naQ2DCplT+Qow5AJr+u6Gs=; b=LNxNQJGg/cAvzOj+gc1zjg bHwAZiLz6xx66pPDxqS3TOkm0gm/sRfbipxCup5hkiDOUVcGUm2taLQSKiCnGnXw ffv+D+EFJ/AuG1YlKvGL8vt5GekgU1VTKNE6jede9OVirWADAt/VMB8v0Tm61ez3 bWXhr6yOU3iQJPogaShBTLD5Cv9eTPuurqMskW6QZOJXvqIY6E7iCBkHyJkkBqo2 OxcKxvUy0xfCQADymsmWW/N6JbD+zCXI0ScTFLMBLCScEqRaAtZKvPwW5OE+2ruR m+z9FbTHN1XUHLvR/KVtcAb6RQBRcW5Z5dZIHx00NIS2fUCV2V3Ax/Uaqp67dcVA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudektddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtf frrghtthgvrhhnpedutddtkeeugeegvddttdeukeeiuddtgfeuuddtfeeiueetfeeileet tedvtdfhieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7C074A0007C; Fri, 9 Apr 2021 02:07:09 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20210319062752.145730-1-andrew@aj.id.au> <20210319062752.145730-11-andrew@aj.id.au> Date: Fri, 09 Apr 2021 15:36:48 +0930 From: "Andrew Jeffery" To: "Zev Weiss" Cc: "openipmi-developer@lists.sourceforge.net" , "openbmc@lists.ozlabs.org" , "Corey Minyard" , "devicetree@vger.kernel.org" , "Ryan Chen" , "Tomer Maimon" , "linux-aspeed@lists.ozlabs.org" , "Avi Fishman" , "Patrick Venture" , "Linus Walleij" , "linux-kernel@vger.kernel.org" , "Tali Perry" , "linux-gpio@vger.kernel.org" , "Rob Herring" , "Lee Jones" , "Chia-Wei, Wang" , "linux-arm-kernel@lists.infradead.org" , "Benjamin Fair" Subject: =?UTF-8?Q?Re:_[PATCH_v2_11/21]_ipmi:_kcs=5Fbmc:_Split_headers_into_devic?= =?UTF-8?Q?e_and_client?= Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, 9 Apr 2021, at 13:31, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:42AM CDT, Andrew Jeffery wrote: > >Strengthen the distinction between code that abstracts the > >implementation of the KCS behaviours (device drivers) and code that > >exploits KCS behaviours (clients). Neither needs to know about the APIs > >required by the other, so provide separate headers. > > > >Signed-off-by: Andrew Jeffery > >--- > > drivers/char/ipmi/kcs_bmc.c | 21 ++++++++++----- > > drivers/char/ipmi/kcs_bmc.h | 30 ++++++++++----------- > > drivers/char/ipmi/kcs_bmc_aspeed.c | 20 +++++++++----- > > drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 39 ++++++++++++++++++--------- > > drivers/char/ipmi/kcs_bmc_client.h | 29 ++++++++++++++++++++ > > drivers/char/ipmi/kcs_bmc_device.h | 19 +++++++++++++ > > drivers/char/ipmi/kcs_bmc_npcm7xx.c | 20 +++++++++----- > > 7 files changed, 129 insertions(+), 49 deletions(-) > > create mode 100644 drivers/char/ipmi/kcs_bmc_client.h > > create mode 100644 drivers/char/ipmi/kcs_bmc_device.h > > > >diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c > >index 709b6bdec165..1046ce2bbefc 100644 > >--- a/drivers/char/ipmi/kcs_bmc.c > >+++ b/drivers/char/ipmi/kcs_bmc.c > >@@ -1,46 +1,52 @@ > > // SPDX-License-Identifier: GPL-2.0 > > /* > > * Copyright (c) 2015-2018, Intel Corporation. > >+ * Copyright (c) 2021, IBM Corp. > > */ > > > > #include > > > > #include "kcs_bmc.h" > > > >+/* Implement both the device and client interfaces here */ > >+#include "kcs_bmc_device.h" > >+#include "kcs_bmc_client.h" > >+ > >+/* Consumer data access */ > >+ > > u8 kcs_bmc_read_data(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc->io_inputb(kcs_bmc, kcs_bmc->ioreg.idr); > >+ return kcs_bmc->ops->io_inputb(kcs_bmc, kcs_bmc->ioreg.idr); > > } > > EXPORT_SYMBOL(kcs_bmc_read_data); > > > > void kcs_bmc_write_data(struct kcs_bmc *kcs_bmc, u8 data) > > { > >- kcs_bmc->io_outputb(kcs_bmc, kcs_bmc->ioreg.odr, data); > >+ kcs_bmc->ops->io_outputb(kcs_bmc, kcs_bmc->ioreg.odr, data); > > } > > EXPORT_SYMBOL(kcs_bmc_write_data); > > > > u8 kcs_bmc_read_status(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc->io_inputb(kcs_bmc, kcs_bmc->ioreg.str); > >+ return kcs_bmc->ops->io_inputb(kcs_bmc, kcs_bmc->ioreg.str); > > } > > EXPORT_SYMBOL(kcs_bmc_read_status); > > > > void kcs_bmc_write_status(struct kcs_bmc *kcs_bmc, u8 data) > > { > >- kcs_bmc->io_outputb(kcs_bmc, kcs_bmc->ioreg.str, data); > >+ kcs_bmc->ops->io_outputb(kcs_bmc, kcs_bmc->ioreg.str, data); > > } > > EXPORT_SYMBOL(kcs_bmc_write_status); > > > > void kcs_bmc_update_status(struct kcs_bmc *kcs_bmc, u8 mask, u8 val) > > { > >- kcs_bmc->io_updateb(kcs_bmc, kcs_bmc->ioreg.str, mask, val); > >+ kcs_bmc->ops->io_updateb(kcs_bmc, kcs_bmc->ioreg.str, mask, val); > > } > > EXPORT_SYMBOL(kcs_bmc_update_status); > > > >-int kcs_bmc_ipmi_event(struct kcs_bmc *kcs_bmc); > > int kcs_bmc_handle_event(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc_ipmi_event(kcs_bmc); > >+ return kcs_bmc->client.ops->event(&kcs_bmc->client); > > } > > EXPORT_SYMBOL(kcs_bmc_handle_event); > > > >@@ -60,4 +66,5 @@ EXPORT_SYMBOL(kcs_bmc_remove_device); > > > > MODULE_LICENSE("GPL v2"); > > MODULE_AUTHOR("Haiyue Wang "); > >+MODULE_AUTHOR("Andrew Jeffery "); > > MODULE_DESCRIPTION("KCS BMC to handle the IPMI request from system software"); > >diff --git a/drivers/char/ipmi/kcs_bmc.h b/drivers/char/ipmi/kcs_bmc.h > >index bf0ae327997f..a1350e567723 100644 > >--- a/drivers/char/ipmi/kcs_bmc.h > >+++ b/drivers/char/ipmi/kcs_bmc.h > >@@ -8,6 +8,15 @@ > > > > #include > > > >+#include "kcs_bmc_client.h" > >+ > >+#define KCS_BMC_EVENT_NONE 0 > >+#define KCS_BMC_EVENT_HANDLED 1 > > Is there a particular reason we're introducing these macros and using an > int return type for kcs_bmc_client_ops.event instead of just having it > be irqreturn_t? Other event types or outcomes we're anticipating needing > to handle maybe? In earlier iterations of the patches I was doing some extra work in the event handling path and felt it was useful at the time. However I've refactored things a little and this may have outlived its usefulness. I'll reasses! > > >+ > >+#define KCS_BMC_STR_OBF BIT(0) > >+#define KCS_BMC_STR_IBF BIT(1) > >+#define KCS_BMC_STR_CMD_DAT BIT(3) > > The first two of these macros are used later in the series, but the third > doesn't end up used at all I think? I think I just added it as documentation as the hardware-defined bits aren't contiguous. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3491FC433B4 for ; Fri, 9 Apr 2021 06:07:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C89F61168 for ; Fri, 9 Apr 2021 06:07:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C89F61168 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FGnjQ0qs9z30KH for ; Fri, 9 Apr 2021 16:07:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.a=rsa-sha256 header.s=fm2 header.b=pEb+ianf; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=LNxNQJGg; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aj.id.au (client-ip=66.111.4.230; helo=new4-smtp.messagingengine.com; envelope-from=andrew@aj.id.au; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.a=rsa-sha256 header.s=fm2 header.b=pEb+ianf; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm2 header.b=LNxNQJGg; dkim-atps=neutral Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FGnhw4C7Pz2xdN; Fri, 9 Apr 2021 16:07:12 +1000 (AEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 6DB6F5806D9; Fri, 9 Apr 2021 02:07:10 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Fri, 09 Apr 2021 02:07:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=xv1zETl1iB5irtIRE5Ue6naQ2DCplT+ Qow5AJr+u6Gs=; b=pEb+ianfzwAfRDEaTJOMTUMGKZNZYn8XI6eeOcIkxBcld2V 0M0yMx7Ah9L4jojZhSlx4UtoSkAxW2Sr+BMNKvQoO7YIfRSTdGy4sR1AD21Szs27 QrM2oVZsX3Hwf7vdRudLdaGCs3savGhxKWLevdjJW/FMWR3BhLFt/MVWSE8ZrEQb M7Ar/Xi5NIVYWVhuK4+UoezUSbdQMEd4CIvReWCPtK6ofhCoqeq2cvkIT3IWt9tA tUiSZukAr+mAJTCB3BZqxOOx7PtBUlQ96Kz85MV7TUq+8kx0Q4QD0SHKW213E4IG 3O2KyER/4YH6taX4pASQVGSZbCYopHNoKiipe7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xv1zET l1iB5irtIRE5Ue6naQ2DCplT+Qow5AJr+u6Gs=; b=LNxNQJGg/cAvzOj+gc1zjg bHwAZiLz6xx66pPDxqS3TOkm0gm/sRfbipxCup5hkiDOUVcGUm2taLQSKiCnGnXw ffv+D+EFJ/AuG1YlKvGL8vt5GekgU1VTKNE6jede9OVirWADAt/VMB8v0Tm61ez3 bWXhr6yOU3iQJPogaShBTLD5Cv9eTPuurqMskW6QZOJXvqIY6E7iCBkHyJkkBqo2 OxcKxvUy0xfCQADymsmWW/N6JbD+zCXI0ScTFLMBLCScEqRaAtZKvPwW5OE+2ruR m+z9FbTHN1XUHLvR/KVtcAb6RQBRcW5Z5dZIHx00NIS2fUCV2V3Ax/Uaqp67dcVA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudektddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtf frrghtthgvrhhnpedutddtkeeugeegvddttdeukeeiuddtgfeuuddtfeeiueetfeeileet tedvtdfhieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7C074A0007C; Fri, 9 Apr 2021 02:07:09 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20210319062752.145730-1-andrew@aj.id.au> <20210319062752.145730-11-andrew@aj.id.au> Date: Fri, 09 Apr 2021 15:36:48 +0930 From: "Andrew Jeffery" To: "Zev Weiss" Subject: =?UTF-8?Q?Re:_[PATCH_v2_11/21]_ipmi:_kcs=5Fbmc:_Split_headers_into_devic?= =?UTF-8?Q?e_and_client?= Content-Type: text/plain X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "Chia-Wei, Wang" , Ryan Chen , Tomer Maimon , Corey Minyard , Avi Fishman , Patrick Venture , "openbmc@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Tali Perry , "linux-gpio@vger.kernel.org" , Rob Herring , "linux-arm-kernel@lists.infradead.org" , "openipmi-developer@lists.sourceforge.net" , Lee Jones , Linus Walleij , "linux-aspeed@lists.ozlabs.org" , Benjamin Fair Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, 9 Apr 2021, at 13:31, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:42AM CDT, Andrew Jeffery wrote: > >Strengthen the distinction between code that abstracts the > >implementation of the KCS behaviours (device drivers) and code that > >exploits KCS behaviours (clients). Neither needs to know about the APIs > >required by the other, so provide separate headers. > > > >Signed-off-by: Andrew Jeffery > >--- > > drivers/char/ipmi/kcs_bmc.c | 21 ++++++++++----- > > drivers/char/ipmi/kcs_bmc.h | 30 ++++++++++----------- > > drivers/char/ipmi/kcs_bmc_aspeed.c | 20 +++++++++----- > > drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 39 ++++++++++++++++++--------- > > drivers/char/ipmi/kcs_bmc_client.h | 29 ++++++++++++++++++++ > > drivers/char/ipmi/kcs_bmc_device.h | 19 +++++++++++++ > > drivers/char/ipmi/kcs_bmc_npcm7xx.c | 20 +++++++++----- > > 7 files changed, 129 insertions(+), 49 deletions(-) > > create mode 100644 drivers/char/ipmi/kcs_bmc_client.h > > create mode 100644 drivers/char/ipmi/kcs_bmc_device.h > > > >diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c > >index 709b6bdec165..1046ce2bbefc 100644 > >--- a/drivers/char/ipmi/kcs_bmc.c > >+++ b/drivers/char/ipmi/kcs_bmc.c > >@@ -1,46 +1,52 @@ > > // SPDX-License-Identifier: GPL-2.0 > > /* > > * Copyright (c) 2015-2018, Intel Corporation. > >+ * Copyright (c) 2021, IBM Corp. > > */ > > > > #include > > > > #include "kcs_bmc.h" > > > >+/* Implement both the device and client interfaces here */ > >+#include "kcs_bmc_device.h" > >+#include "kcs_bmc_client.h" > >+ > >+/* Consumer data access */ > >+ > > u8 kcs_bmc_read_data(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc->io_inputb(kcs_bmc, kcs_bmc->ioreg.idr); > >+ return kcs_bmc->ops->io_inputb(kcs_bmc, kcs_bmc->ioreg.idr); > > } > > EXPORT_SYMBOL(kcs_bmc_read_data); > > > > void kcs_bmc_write_data(struct kcs_bmc *kcs_bmc, u8 data) > > { > >- kcs_bmc->io_outputb(kcs_bmc, kcs_bmc->ioreg.odr, data); > >+ kcs_bmc->ops->io_outputb(kcs_bmc, kcs_bmc->ioreg.odr, data); > > } > > EXPORT_SYMBOL(kcs_bmc_write_data); > > > > u8 kcs_bmc_read_status(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc->io_inputb(kcs_bmc, kcs_bmc->ioreg.str); > >+ return kcs_bmc->ops->io_inputb(kcs_bmc, kcs_bmc->ioreg.str); > > } > > EXPORT_SYMBOL(kcs_bmc_read_status); > > > > void kcs_bmc_write_status(struct kcs_bmc *kcs_bmc, u8 data) > > { > >- kcs_bmc->io_outputb(kcs_bmc, kcs_bmc->ioreg.str, data); > >+ kcs_bmc->ops->io_outputb(kcs_bmc, kcs_bmc->ioreg.str, data); > > } > > EXPORT_SYMBOL(kcs_bmc_write_status); > > > > void kcs_bmc_update_status(struct kcs_bmc *kcs_bmc, u8 mask, u8 val) > > { > >- kcs_bmc->io_updateb(kcs_bmc, kcs_bmc->ioreg.str, mask, val); > >+ kcs_bmc->ops->io_updateb(kcs_bmc, kcs_bmc->ioreg.str, mask, val); > > } > > EXPORT_SYMBOL(kcs_bmc_update_status); > > > >-int kcs_bmc_ipmi_event(struct kcs_bmc *kcs_bmc); > > int kcs_bmc_handle_event(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc_ipmi_event(kcs_bmc); > >+ return kcs_bmc->client.ops->event(&kcs_bmc->client); > > } > > EXPORT_SYMBOL(kcs_bmc_handle_event); > > > >@@ -60,4 +66,5 @@ EXPORT_SYMBOL(kcs_bmc_remove_device); > > > > MODULE_LICENSE("GPL v2"); > > MODULE_AUTHOR("Haiyue Wang "); > >+MODULE_AUTHOR("Andrew Jeffery "); > > MODULE_DESCRIPTION("KCS BMC to handle the IPMI request from system software"); > >diff --git a/drivers/char/ipmi/kcs_bmc.h b/drivers/char/ipmi/kcs_bmc.h > >index bf0ae327997f..a1350e567723 100644 > >--- a/drivers/char/ipmi/kcs_bmc.h > >+++ b/drivers/char/ipmi/kcs_bmc.h > >@@ -8,6 +8,15 @@ > > > > #include > > > >+#include "kcs_bmc_client.h" > >+ > >+#define KCS_BMC_EVENT_NONE 0 > >+#define KCS_BMC_EVENT_HANDLED 1 > > Is there a particular reason we're introducing these macros and using an > int return type for kcs_bmc_client_ops.event instead of just having it > be irqreturn_t? Other event types or outcomes we're anticipating needing > to handle maybe? In earlier iterations of the patches I was doing some extra work in the event handling path and felt it was useful at the time. However I've refactored things a little and this may have outlived its usefulness. I'll reasses! > > >+ > >+#define KCS_BMC_STR_OBF BIT(0) > >+#define KCS_BMC_STR_IBF BIT(1) > >+#define KCS_BMC_STR_CMD_DAT BIT(3) > > The first two of these macros are used later in the series, but the third > doesn't end up used at all I think? I think I just added it as documentation as the hardware-defined bits aren't contiguous. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43AD2C433ED for ; Fri, 9 Apr 2021 06:09:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93D2F6113A for ; Fri, 9 Apr 2021 06:09:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93D2F6113A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References:In-Reply-To: Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pU5LE9p8oSpAR/N11lTq4KtnbGtlTg4nPK54LnpmRQs=; b=Zh+q36F3WwzShRDfPZYQVXO9t 3wxaFylL8VPQadCFXlLKxblM2fAAu/qnuEbO0awUIoZJvrbzU2opwufm1xgqvRHfEXqIwBn004CQF DOP7vYNcX88T446QtHQrRFg4teUL/2ZZ3i+fn9BR9myao3PfdVLLSmVazyZVuotJw+foSybIWvaZV QDl4PaTMtvCwz9cT0ebCSO9gcIjKB7fHdrXWQyrfBKrpRSa2iq8eaeqwoP4Sj+bM8DPQxBuC3VmKU b24kg+PhSqDg2JPlWd89I2MG3f24rtZZrzxmGhxJhZYRs6JF5vKLOEDdmY18IoZ5QY1zuoLlqnzm5 sWmUgR+Kw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUkIe-00AFum-0E; Fri, 09 Apr 2021 06:07:24 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUkIR-00AFsS-O8 for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 06:07:17 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 6DB6F5806D9; Fri, 9 Apr 2021 02:07:10 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Fri, 09 Apr 2021 02:07:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm2; bh=xv1zETl1iB5irtIRE5Ue6naQ2DCplT+ Qow5AJr+u6Gs=; b=pEb+ianfzwAfRDEaTJOMTUMGKZNZYn8XI6eeOcIkxBcld2V 0M0yMx7Ah9L4jojZhSlx4UtoSkAxW2Sr+BMNKvQoO7YIfRSTdGy4sR1AD21Szs27 QrM2oVZsX3Hwf7vdRudLdaGCs3savGhxKWLevdjJW/FMWR3BhLFt/MVWSE8ZrEQb M7Ar/Xi5NIVYWVhuK4+UoezUSbdQMEd4CIvReWCPtK6ofhCoqeq2cvkIT3IWt9tA tUiSZukAr+mAJTCB3BZqxOOx7PtBUlQ96Kz85MV7TUq+8kx0Q4QD0SHKW213E4IG 3O2KyER/4YH6taX4pASQVGSZbCYopHNoKiipe7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xv1zET l1iB5irtIRE5Ue6naQ2DCplT+Qow5AJr+u6Gs=; b=LNxNQJGg/cAvzOj+gc1zjg bHwAZiLz6xx66pPDxqS3TOkm0gm/sRfbipxCup5hkiDOUVcGUm2taLQSKiCnGnXw ffv+D+EFJ/AuG1YlKvGL8vt5GekgU1VTKNE6jede9OVirWADAt/VMB8v0Tm61ez3 bWXhr6yOU3iQJPogaShBTLD5Cv9eTPuurqMskW6QZOJXvqIY6E7iCBkHyJkkBqo2 OxcKxvUy0xfCQADymsmWW/N6JbD+zCXI0ScTFLMBLCScEqRaAtZKvPwW5OE+2ruR m+z9FbTHN1XUHLvR/KVtcAb6RQBRcW5Z5dZIHx00NIS2fUCV2V3Ax/Uaqp67dcVA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudektddguddtvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedftehn ughrvgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtf frrghtthgvrhhnpedutddtkeeugeegvddttdeukeeiuddtgfeuuddtfeeiueetfeeileet tedvtdfhieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7C074A0007C; Fri, 9 Apr 2021 02:07:09 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-273-g8500d2492d-fm-20210323.002-g8500d249 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20210319062752.145730-1-andrew@aj.id.au> <20210319062752.145730-11-andrew@aj.id.au> Date: Fri, 09 Apr 2021 15:36:48 +0930 From: "Andrew Jeffery" To: "Zev Weiss" Cc: "openipmi-developer@lists.sourceforge.net" , "openbmc@lists.ozlabs.org" , "Corey Minyard" , "devicetree@vger.kernel.org" , "Ryan Chen" , "Tomer Maimon" , "linux-aspeed@lists.ozlabs.org" , "Avi Fishman" , "Patrick Venture" , "Linus Walleij" , "linux-kernel@vger.kernel.org" , "Tali Perry" , "linux-gpio@vger.kernel.org" , "Rob Herring" , "Lee Jones" , "Chia-Wei, Wang" , "linux-arm-kernel@lists.infradead.org" , "Benjamin Fair" Subject: =?UTF-8?Q?Re:_[PATCH_v2_11/21]_ipmi:_kcs=5Fbmc:_Split_headers_into_devic?= =?UTF-8?Q?e_and_client?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_070712_468641_E3B93015 X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 9 Apr 2021, at 13:31, Zev Weiss wrote: > On Fri, Mar 19, 2021 at 01:27:42AM CDT, Andrew Jeffery wrote: > >Strengthen the distinction between code that abstracts the > >implementation of the KCS behaviours (device drivers) and code that > >exploits KCS behaviours (clients). Neither needs to know about the APIs > >required by the other, so provide separate headers. > > > >Signed-off-by: Andrew Jeffery > >--- > > drivers/char/ipmi/kcs_bmc.c | 21 ++++++++++----- > > drivers/char/ipmi/kcs_bmc.h | 30 ++++++++++----------- > > drivers/char/ipmi/kcs_bmc_aspeed.c | 20 +++++++++----- > > drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 39 ++++++++++++++++++--------- > > drivers/char/ipmi/kcs_bmc_client.h | 29 ++++++++++++++++++++ > > drivers/char/ipmi/kcs_bmc_device.h | 19 +++++++++++++ > > drivers/char/ipmi/kcs_bmc_npcm7xx.c | 20 +++++++++----- > > 7 files changed, 129 insertions(+), 49 deletions(-) > > create mode 100644 drivers/char/ipmi/kcs_bmc_client.h > > create mode 100644 drivers/char/ipmi/kcs_bmc_device.h > > > >diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c > >index 709b6bdec165..1046ce2bbefc 100644 > >--- a/drivers/char/ipmi/kcs_bmc.c > >+++ b/drivers/char/ipmi/kcs_bmc.c > >@@ -1,46 +1,52 @@ > > // SPDX-License-Identifier: GPL-2.0 > > /* > > * Copyright (c) 2015-2018, Intel Corporation. > >+ * Copyright (c) 2021, IBM Corp. > > */ > > > > #include > > > > #include "kcs_bmc.h" > > > >+/* Implement both the device and client interfaces here */ > >+#include "kcs_bmc_device.h" > >+#include "kcs_bmc_client.h" > >+ > >+/* Consumer data access */ > >+ > > u8 kcs_bmc_read_data(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc->io_inputb(kcs_bmc, kcs_bmc->ioreg.idr); > >+ return kcs_bmc->ops->io_inputb(kcs_bmc, kcs_bmc->ioreg.idr); > > } > > EXPORT_SYMBOL(kcs_bmc_read_data); > > > > void kcs_bmc_write_data(struct kcs_bmc *kcs_bmc, u8 data) > > { > >- kcs_bmc->io_outputb(kcs_bmc, kcs_bmc->ioreg.odr, data); > >+ kcs_bmc->ops->io_outputb(kcs_bmc, kcs_bmc->ioreg.odr, data); > > } > > EXPORT_SYMBOL(kcs_bmc_write_data); > > > > u8 kcs_bmc_read_status(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc->io_inputb(kcs_bmc, kcs_bmc->ioreg.str); > >+ return kcs_bmc->ops->io_inputb(kcs_bmc, kcs_bmc->ioreg.str); > > } > > EXPORT_SYMBOL(kcs_bmc_read_status); > > > > void kcs_bmc_write_status(struct kcs_bmc *kcs_bmc, u8 data) > > { > >- kcs_bmc->io_outputb(kcs_bmc, kcs_bmc->ioreg.str, data); > >+ kcs_bmc->ops->io_outputb(kcs_bmc, kcs_bmc->ioreg.str, data); > > } > > EXPORT_SYMBOL(kcs_bmc_write_status); > > > > void kcs_bmc_update_status(struct kcs_bmc *kcs_bmc, u8 mask, u8 val) > > { > >- kcs_bmc->io_updateb(kcs_bmc, kcs_bmc->ioreg.str, mask, val); > >+ kcs_bmc->ops->io_updateb(kcs_bmc, kcs_bmc->ioreg.str, mask, val); > > } > > EXPORT_SYMBOL(kcs_bmc_update_status); > > > >-int kcs_bmc_ipmi_event(struct kcs_bmc *kcs_bmc); > > int kcs_bmc_handle_event(struct kcs_bmc *kcs_bmc) > > { > >- return kcs_bmc_ipmi_event(kcs_bmc); > >+ return kcs_bmc->client.ops->event(&kcs_bmc->client); > > } > > EXPORT_SYMBOL(kcs_bmc_handle_event); > > > >@@ -60,4 +66,5 @@ EXPORT_SYMBOL(kcs_bmc_remove_device); > > > > MODULE_LICENSE("GPL v2"); > > MODULE_AUTHOR("Haiyue Wang "); > >+MODULE_AUTHOR("Andrew Jeffery "); > > MODULE_DESCRIPTION("KCS BMC to handle the IPMI request from system software"); > >diff --git a/drivers/char/ipmi/kcs_bmc.h b/drivers/char/ipmi/kcs_bmc.h > >index bf0ae327997f..a1350e567723 100644 > >--- a/drivers/char/ipmi/kcs_bmc.h > >+++ b/drivers/char/ipmi/kcs_bmc.h > >@@ -8,6 +8,15 @@ > > > > #include > > > >+#include "kcs_bmc_client.h" > >+ > >+#define KCS_BMC_EVENT_NONE 0 > >+#define KCS_BMC_EVENT_HANDLED 1 > > Is there a particular reason we're introducing these macros and using an > int return type for kcs_bmc_client_ops.event instead of just having it > be irqreturn_t? Other event types or outcomes we're anticipating needing > to handle maybe? In earlier iterations of the patches I was doing some extra work in the event handling path and felt it was useful at the time. However I've refactored things a little and this may have outlived its usefulness. I'll reasses! > > >+ > >+#define KCS_BMC_STR_OBF BIT(0) > >+#define KCS_BMC_STR_IBF BIT(1) > >+#define KCS_BMC_STR_CMD_DAT BIT(3) > > The first two of these macros are used later in the series, but the third > doesn't end up used at all I think? I think I just added it as documentation as the hardware-defined bits aren't contiguous. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel