From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68AB6C433ED for ; Mon, 10 May 2021 04:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3891C61437 for ; Mon, 10 May 2021 04:34:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbhEJEfs (ORCPT ); Mon, 10 May 2021 00:35:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37683 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbhEJEfr (ORCPT ); Mon, 10 May 2021 00:35:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620621283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5uXhSn/w6CZf/GcmcktyqqIlCH6uf+CBfk9ICAipjiM=; b=IHcBFy2SbDAvl98zl7RTGCFOWV11fu7H2elgpvqrD+IIX1IhRjfVWIXNQ9v+ZBwnNPRna0 +oJBKV/IYm+IrYPRjpejDufjDq6cr47QUUuk/xjtoVYcU2GsDtF/Kyg/7F3Wy3q3cuLmZD IS01ASJ8pqOwO9i1k8pWkP8Baeo+XfY= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-ZqjRI7o2NpaobhRTmnllxw-1; Mon, 10 May 2021 00:34:41 -0400 X-MC-Unique: ZqjRI7o2NpaobhRTmnllxw-1 Received: by mail-pl1-f199.google.com with SMTP id l18-20020a170902e2d2b02900eefb0acd12so4975423plc.18 for ; Sun, 09 May 2021 21:34:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5uXhSn/w6CZf/GcmcktyqqIlCH6uf+CBfk9ICAipjiM=; b=qECIILs0xgbSaH+pie0xmB6Nr0ddkbjXGFSulupp+DxnToUnp6oNx2KD0o8WdFs3NS NOByWi/DgqO/DoWfWo1Ape9IIaOmuFuo6TblDrWcwDJAWHNgsSLYGz3dbeU+ln8K7mRX 8pclafuyew/5aA/4HOc1PIgxYqegfvl3PY1wPPnqjR2AthF41NVi5G+G/BuCjDEzz8DW 85lhzo7J4UjT0seJut47+JXidJuUyeqVFEhdFpEIVzU5a0wLPf9tY4qrKX3p6/GqgqpO H0HEpClrjLflZd7h9g/3tmVOtscGsKNsBEOKmpS3MazTqNeYN47zG5r8nAr4roX93+3g JtUw== X-Gm-Message-State: AOAM531d/osQuItE1z6FhxCEZQNpqg/8aFMIqVbfR38/k/3rHtt4oIhD tO0c4hyTsVgiBsVTpP3pTyXxnz8RJWZajnIpVwHLd5mhwdIU3omwV3FKQAkaJPrw+4g1RMJL73s yOs37vwO67DH0nmQ59VJ00L+f3QtHuHJPfBePBzLGSu46v3dg5aUIfAdZ9A9FLWkDgSzb X-Received: by 2002:a63:4512:: with SMTP id s18mr23457208pga.275.1620621277380; Sun, 09 May 2021 21:34:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygmSy3Fdas8cpmiqmQfqfLtuCoMdKjuVFbGs0UxKU35ro+F/44i5Shmvs9MQ/0/XJwJ1PxMg== X-Received: by 2002:a63:4512:: with SMTP id s18mr23457181pga.275.1620621277002; Sun, 09 May 2021 21:34:37 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id h36sm10483782pgh.63.2021.05.09.21.34.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 May 2021 21:34:35 -0700 (PDT) Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: "Zhu, Lingshan" , mst@redhat.com, maz@kernel.org, alex.williamson@redhat.com Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org References: <20210508071152.722425-1-lingshan.zhu@intel.com> From: Jason Wang Message-ID: Date: Mon, 10 May 2021 12:34:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 在 2021/5/10 上午11:00, Zhu, Lingshan 写道: > > > On 5/10/2021 10:43 AM, Jason Wang wrote: >> >> 在 2021/5/8 下午3:11, Zhu Lingshan 写道: >>> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. >>> >>> The reverted commit may cause VM freeze on arm64 platform. >>> Because on arm64 platform, stop a consumer will suspend the VM, >>> the VM will freeze without a start consumer >>> >>> Signed-off-by: Zhu Lingshan >> >> >> Acked-by: Jason Wang >> >> Please resubmit with the formal process of stable >> (stable-kernel-rules.rst). > sure, I will re-submit it to stable kernel once it is merged into > Linus tree. > > Thanks I think it's better to resubmit (option 1), see how stable-kernel-rules.rst said: "" :ref:`option_1` is **strongly** preferred, is the easiest and most common. :ref:`option_2` and :ref:`option_3` are more useful if the patch isn't deemed worthy at the time it is applied to a public git tree (for instance, because it deserves more regression testing first). """ Thanks >> >> Thanks >> >> >>> --- >>>   virt/lib/irqbypass.c | 16 ++++++---------- >>>   1 file changed, 6 insertions(+), 10 deletions(-) >>> >>> diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c >>> index c9bb3957f58a..28fda42e471b 100644 >>> --- a/virt/lib/irqbypass.c >>> +++ b/virt/lib/irqbypass.c >>> @@ -40,21 +40,17 @@ static int __connect(struct irq_bypass_producer >>> *prod, >>>       if (prod->add_consumer) >>>           ret = prod->add_consumer(prod, cons); >>>   -    if (ret) >>> -        goto err_add_consumer; >>> - >>> -    ret = cons->add_producer(cons, prod); >>> -    if (ret) >>> -        goto err_add_producer; >>> +    if (!ret) { >>> +        ret = cons->add_producer(cons, prod); >>> +        if (ret && prod->del_consumer) >>> +            prod->del_consumer(prod, cons); >>> +    } >>>         if (cons->start) >>>           cons->start(cons); >>>       if (prod->start) >>>           prod->start(prod); >>> -err_add_producer: >>> -    if (prod->del_consumer) >>> -        prod->del_consumer(prod, cons); >>> -err_add_consumer: >>> + >>>       return ret; >>>   } >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99F73C433B4 for ; Mon, 10 May 2021 07:51:19 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 1B8776143C for ; Mon, 10 May 2021 07:51:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B8776143C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A577D4B254; Mon, 10 May 2021 03:51:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lKnBA63arnwY; Mon, 10 May 2021 03:51:17 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2FDF84B3BF; Mon, 10 May 2021 03:51:15 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 52F604B4EF for ; Mon, 10 May 2021 00:34:42 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fm9HjiTMQCQv for ; Mon, 10 May 2021 00:34:41 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 288684B3CC for ; Mon, 10 May 2021 00:34:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620621280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5uXhSn/w6CZf/GcmcktyqqIlCH6uf+CBfk9ICAipjiM=; b=OboNuuOZRZHL8sNJC95aOMWlFV6tpbKlugYyeU5zJ0GtxsTSPZXmsYVGW8IAyDPblCfTsL TqkqwTmzxkwMEKP5glUzr4gAlWKF45W2U4XN3Fq9imy2//G7LPkVlgRDlnCUxRVS573b/R rbmlclDWauIl1EOK2HLf81weeWRS5fY= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-222-Yc4M7mgcNYuNtdcv3A8eww-1; Mon, 10 May 2021 00:34:38 -0400 X-MC-Unique: Yc4M7mgcNYuNtdcv3A8eww-1 Received: by mail-pf1-f198.google.com with SMTP id g144-20020a6252960000b029023d959faca6so10026076pfb.9 for ; Sun, 09 May 2021 21:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5uXhSn/w6CZf/GcmcktyqqIlCH6uf+CBfk9ICAipjiM=; b=M3Ej+WPKOFA5gQCN+5EO3vbwrBRzJGisryWPXqhbPyYdbauF2FdLk2WRKB3WiPThhp eWOg6K7MqvBgJ4ke4wP6s9DDWrNEa7zwK5W9+i2/RnPk+gXKFYg+akBTNMX1KvqNgxSu IYv85FF0UDtPvsCjX2JrpyTmUrJGzQi2Pw5XXFDrLCM8eNDsWE4iwxomKXuanidNiE1w DpPC8IhoFOqAkxUOhWCYBg6YEZZUf2Asp76ZALKJgNp9D0+ixVJM6G95+qC1dtTi7Z93 AsJI7BwTYwZfOrNGEgld8RPUw1AWhDEFA2zYCvFpgh3WFkzt/mdQNUWLVWv5Ss8w95l2 EEuQ== X-Gm-Message-State: AOAM5336NQYsU2gDRWoYs79CRiym64Uirb5+VMm4xyDO5JGlTODhhqcx sQ5aVR6vU7AvWEIaxyfDN6XjxJvJxG5+B6AVtL65pDOpGllY92h17ioXAASFOBDecaaZZyhD+Tv ZXjeGMzE87A0wHsZUOpAT1jWU X-Received: by 2002:a63:4512:: with SMTP id s18mr23457197pga.275.1620621277260; Sun, 09 May 2021 21:34:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygmSy3Fdas8cpmiqmQfqfLtuCoMdKjuVFbGs0UxKU35ro+F/44i5Shmvs9MQ/0/XJwJ1PxMg== X-Received: by 2002:a63:4512:: with SMTP id s18mr23457181pga.275.1620621277002; Sun, 09 May 2021 21:34:37 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id h36sm10483782pgh.63.2021.05.09.21.34.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 May 2021 21:34:35 -0700 (PDT) Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: "Zhu, Lingshan" , mst@redhat.com, maz@kernel.org, alex.williamson@redhat.com References: <20210508071152.722425-1-lingshan.zhu@intel.com> From: Jason Wang Message-ID: Date: Mon, 10 May 2021 12:34:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Mailman-Approved-At: Mon, 10 May 2021 03:51:13 -0400 Cc: stable@vger.kernel.org, cohuck@redhat.com, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu CuWcqCAyMDIxLzUvMTAg5LiK5Y2IMTE6MDAsIFpodSwgTGluZ3NoYW4g5YaZ6YGTOgo+Cj4KPiBP biA1LzEwLzIwMjEgMTA6NDMgQU0sIEphc29uIFdhbmcgd3JvdGU6Cj4+Cj4+IOWcqCAyMDIxLzUv OCDkuIvljYgzOjExLCBaaHUgTGluZ3NoYW4g5YaZ6YGTOgo+Pj4gVGhpcyByZXZlcnRzIGNvbW1p dCBhOTc5YTZhYTAwOWYzYzk5Njg5NDMyZTBjZGI1NDAyYTQ0NjNmYjg4Lgo+Pj4KPj4+IFRoZSBy ZXZlcnRlZCBjb21taXQgbWF5IGNhdXNlIFZNIGZyZWV6ZSBvbiBhcm02NCBwbGF0Zm9ybS4KPj4+ IEJlY2F1c2Ugb24gYXJtNjQgcGxhdGZvcm0sIHN0b3AgYSBjb25zdW1lciB3aWxsIHN1c3BlbmQg dGhlIFZNLAo+Pj4gdGhlIFZNIHdpbGwgZnJlZXplIHdpdGhvdXQgYSBzdGFydCBjb25zdW1lcgo+ Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFpodSBMaW5nc2hhbiA8bGluZ3NoYW4uemh1QGludGVsLmNv bT4KPj4KPj4KPj4gQWNrZWQtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4+ Cj4+IFBsZWFzZSByZXN1Ym1pdCB3aXRoIHRoZSBmb3JtYWwgcHJvY2VzcyBvZiBzdGFibGUgCj4+ IChzdGFibGUta2VybmVsLXJ1bGVzLnJzdCkuCj4gc3VyZSwgSSB3aWxsIHJlLXN1Ym1pdCBpdCB0 byBzdGFibGUga2VybmVsIG9uY2UgaXQgaXMgbWVyZ2VkIGludG8gCj4gTGludXMgdHJlZS4KPgo+ IFRoYW5rcwoKCkkgdGhpbmsgaXQncyBiZXR0ZXIgdG8gcmVzdWJtaXQgKG9wdGlvbiAxKSwgc2Vl IGhvdyAKc3RhYmxlLWtlcm5lbC1ydWxlcy5yc3Qgc2FpZDoKCiIiCgo6cmVmOmBvcHRpb25fMWAg aXMgKipzdHJvbmdseSoqIHByZWZlcnJlZCwgaXMgdGhlIGVhc2llc3QgYW5kIG1vc3QgY29tbW9u Lgo6cmVmOmBvcHRpb25fMmAgYW5kIDpyZWY6YG9wdGlvbl8zYCBhcmUgbW9yZSB1c2VmdWwgaWYg dGhlIHBhdGNoIGlzbid0IApkZWVtZWQKd29ydGh5IGF0IHRoZSB0aW1lIGl0IGlzIGFwcGxpZWQg dG8gYSBwdWJsaWMgZ2l0IHRyZWUgKGZvciBpbnN0YW5jZSwgYmVjYXVzZQppdCBkZXNlcnZlcyBt b3JlIHJlZ3Jlc3Npb24gdGVzdGluZyBmaXJzdCkuCgoiIiIKClRoYW5rcwoKCj4+Cj4+IFRoYW5r cwo+Pgo+Pgo+Pj4gLS0tCj4+PiDCoCB2aXJ0L2xpYi9pcnFieXBhc3MuYyB8IDE2ICsrKysrKy0t LS0tLS0tLS0KPj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEwIGRlbGV0 aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS92aXJ0L2xpYi9pcnFieXBhc3MuYyBiL3ZpcnQv bGliL2lycWJ5cGFzcy5jCj4+PiBpbmRleCBjOWJiMzk1N2Y1OGEuLjI4ZmRhNDJlNDcxYiAxMDA2 NDQKPj4+IC0tLSBhL3ZpcnQvbGliL2lycWJ5cGFzcy5jCj4+PiArKysgYi92aXJ0L2xpYi9pcnFi eXBhc3MuYwo+Pj4gQEAgLTQwLDIxICs0MCwxNyBAQCBzdGF0aWMgaW50IF9fY29ubmVjdChzdHJ1 Y3QgaXJxX2J5cGFzc19wcm9kdWNlciAKPj4+ICpwcm9kLAo+Pj4gwqDCoMKgwqDCoCBpZiAocHJv ZC0+YWRkX2NvbnN1bWVyKQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IHByb2QtPmFkZF9j b25zdW1lcihwcm9kLCBjb25zKTsKPj4+IMKgIC3CoMKgwqAgaWYgKHJldCkKPj4+IC3CoMKgwqDC oMKgwqDCoCBnb3RvIGVycl9hZGRfY29uc3VtZXI7Cj4+PiAtCj4+PiAtwqDCoMKgIHJldCA9IGNv bnMtPmFkZF9wcm9kdWNlcihjb25zLCBwcm9kKTsKPj4+IC3CoMKgwqAgaWYgKHJldCkKPj4+IC3C oMKgwqDCoMKgwqDCoCBnb3RvIGVycl9hZGRfcHJvZHVjZXI7Cj4+PiArwqDCoMKgIGlmICghcmV0 KSB7Cj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0ID0gY29ucy0+YWRkX3Byb2R1Y2VyKGNvbnMsIHBy b2QpOwo+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChyZXQgJiYgcHJvZC0+ZGVsX2NvbnN1bWVyKQo+ Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJvZC0+ZGVsX2NvbnN1bWVyKHByb2QsIGNvbnMp Owo+Pj4gK8KgwqDCoCB9Cj4+PiDCoCDCoMKgwqDCoMKgIGlmIChjb25zLT5zdGFydCkKPj4+IMKg wqDCoMKgwqDCoMKgwqDCoCBjb25zLT5zdGFydChjb25zKTsKPj4+IMKgwqDCoMKgwqAgaWYgKHBy b2QtPnN0YXJ0KQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHByb2QtPnN0YXJ0KHByb2QpOwo+Pj4g LWVycl9hZGRfcHJvZHVjZXI6Cj4+PiAtwqDCoMKgIGlmIChwcm9kLT5kZWxfY29uc3VtZXIpCj4+ PiAtwqDCoMKgwqDCoMKgwqAgcHJvZC0+ZGVsX2NvbnN1bWVyKHByb2QsIGNvbnMpOwo+Pj4gLWVy cl9hZGRfY29uc3VtZXI6Cj4+PiArCj4+PiDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4+PiDCoCB9 Cj4+Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2 bWFybSBtYWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xp c3RzLmNzLmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F11CC433B4 for ; Mon, 10 May 2021 04:37:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F01DF6101E for ; Mon, 10 May 2021 04:37:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F01DF6101E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FXe6yral6+0aMQXLAcqiU28VpGPJUrxZtETtl1j3O7Y=; b=bmPYF22ILfO3J76rl/yCo826R hAQzVYQDr0KkM4nMUIUbNegscqwnMAwoYrNDFjv2Glu/IV1iM6SG5PqBrCF/f3O1iS6erT3kMF02i yP8g6tI3ycGpMBopRsLrGe3/aYNd3Or9AMAfj+4RPmulbd5XusUNknPatUdhaC4gzwzJtpXZxn3Il 2aGe1aVJcqnr+YDugfx+bwhEnpRvqBx9I7gJJj0C91DaNvAhAxF1odTPJUM6eMXABqQImgoH9hU4J jDKgx6UMQtXjNu1CTY2EYJ+np/sC9u0W5DIyV8k9JXHLhr8WGnV+RVVht1vLZhubO9zWW3trs8jBQ nXY1TSGnA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfxd8-00D7U9-V5; Mon, 10 May 2021 04:34:55 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfxd5-00D7U4-5D for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 04:34:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=5uXhSn/w6CZf/GcmcktyqqIlCH6uf+CBfk9ICAipjiM=; b=w0UJtgv40AFxDvlHMQycTgiSXR zrnG+uiEDfUP00nHmq2teUpTZkwexjinfK8rC7ZBYKsDj9rWFqKZnMzwYcxHFKQ1WS6wvzGgqD3qN BV7W5zvuECbnWk4INXBvpB3pMiya5q5pH2bnIMo4qph8DbHw+dE504Mo4jGnBAp4VjqUkrFoEMgDS Vh8jXIm+ZOI3TBa1/vrhSl5SN+U5Ku3MfiWmclRuyZLdG4b+3EIcdu/VeNTNztYOjbAePe1Z6JyuE 26r3kZ19+aWC8NEyBwqdG5RX2NXEsKOqkWyaUNoiAkInkrseI17RboaW9eRB8W6M0n9hah7gGck6A B6T6XUqA==; Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfxd2-008HKk-5Y for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 04:34:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620621282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5uXhSn/w6CZf/GcmcktyqqIlCH6uf+CBfk9ICAipjiM=; b=NFQr+Oga6rWs3uWXBx7s2zc1PfrbCQh7U5gpeXR4Tksau/auFvJ2EPDe01YJjPwlwZEjqs LQtj96l2bJZHVI+AOjFzfnR438S5ZLQJ3jBQSd25x+rPXBASGprWXwR1oLtD94b2yLIqjP 95y01I9rCn+vMYtNlNjovQolgas+9/4= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-Ha5tRZ_nPdeZ5A6btqom4A-1; Mon, 10 May 2021 00:34:38 -0400 X-MC-Unique: Ha5tRZ_nPdeZ5A6btqom4A-1 Received: by mail-pj1-f70.google.com with SMTP id k19-20020a17090aaa13b0290155dbdb3d87so8643605pjq.4 for ; Sun, 09 May 2021 21:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5uXhSn/w6CZf/GcmcktyqqIlCH6uf+CBfk9ICAipjiM=; b=LrxgqPwh6NxBgKXrPgoIKGQa0A+Rgsn74tqG9Np7VC506Xye3u7mP9fSQsg5YuBig1 z46JDAaMQPlowGvTMakOeARwCd9umo94OTqijpqHPUTaKjVE4Gh1toZ7tsVldU+VkVom dEvbBGY2oaBbbuwLAVHYSXQgFeau5FsTK8T5bXwWTt8wTmKhs129Jywfy2XkQit2Mv+V yHDALHZbjXebOMUDVclViLtGztbEq0foZbtYFD8SwwXIKD/f78IhvD9hgnvA1znGOkYE vDgbIjz/w5Q5A66PWB4cS6tIPJH2hR/z6zr5tKRz+QX9BjNcnzqNHhd0LrxeHzZWdsLv skzw== X-Gm-Message-State: AOAM532nZZ7Qm88TNTCwH0PSgVt907HGSm4RUSUTTnS+Ap2bgYc7zD1F lhk4s3XDQzmZd6dmeowUhQhsfMGH5LkcONaPfGLJYHFTOhZWQrkwxdkrZ8beoABbIgRnbvaTgDA jE3ova7XvhtCuV9twp4Suoar4ZGmfhhG1kUg= X-Received: by 2002:a63:4512:: with SMTP id s18mr23457200pga.275.1620621277260; Sun, 09 May 2021 21:34:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygmSy3Fdas8cpmiqmQfqfLtuCoMdKjuVFbGs0UxKU35ro+F/44i5Shmvs9MQ/0/XJwJ1PxMg== X-Received: by 2002:a63:4512:: with SMTP id s18mr23457181pga.275.1620621277002; Sun, 09 May 2021 21:34:37 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id h36sm10483782pgh.63.2021.05.09.21.34.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 May 2021 21:34:35 -0700 (PDT) Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" To: "Zhu, Lingshan" , mst@redhat.com, maz@kernel.org, alex.williamson@redhat.com Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org References: <20210508071152.722425-1-lingshan.zhu@intel.com> From: Jason Wang Message-ID: Date: Mon, 10 May 2021 12:34:25 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210509_213448_317281_DD8B62A1 X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CuWcqCAyMDIxLzUvMTAg5LiK5Y2IMTE6MDAsIFpodSwgTGluZ3NoYW4g5YaZ6YGTOgo+Cj4KPiBP biA1LzEwLzIwMjEgMTA6NDMgQU0sIEphc29uIFdhbmcgd3JvdGU6Cj4+Cj4+IOWcqCAyMDIxLzUv OCDkuIvljYgzOjExLCBaaHUgTGluZ3NoYW4g5YaZ6YGTOgo+Pj4gVGhpcyByZXZlcnRzIGNvbW1p dCBhOTc5YTZhYTAwOWYzYzk5Njg5NDMyZTBjZGI1NDAyYTQ0NjNmYjg4Lgo+Pj4KPj4+IFRoZSBy ZXZlcnRlZCBjb21taXQgbWF5IGNhdXNlIFZNIGZyZWV6ZSBvbiBhcm02NCBwbGF0Zm9ybS4KPj4+ IEJlY2F1c2Ugb24gYXJtNjQgcGxhdGZvcm0sIHN0b3AgYSBjb25zdW1lciB3aWxsIHN1c3BlbmQg dGhlIFZNLAo+Pj4gdGhlIFZNIHdpbGwgZnJlZXplIHdpdGhvdXQgYSBzdGFydCBjb25zdW1lcgo+ Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFpodSBMaW5nc2hhbiA8bGluZ3NoYW4uemh1QGludGVsLmNv bT4KPj4KPj4KPj4gQWNrZWQtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4+ Cj4+IFBsZWFzZSByZXN1Ym1pdCB3aXRoIHRoZSBmb3JtYWwgcHJvY2VzcyBvZiBzdGFibGUgCj4+ IChzdGFibGUta2VybmVsLXJ1bGVzLnJzdCkuCj4gc3VyZSwgSSB3aWxsIHJlLXN1Ym1pdCBpdCB0 byBzdGFibGUga2VybmVsIG9uY2UgaXQgaXMgbWVyZ2VkIGludG8gCj4gTGludXMgdHJlZS4KPgo+ IFRoYW5rcwoKCkkgdGhpbmsgaXQncyBiZXR0ZXIgdG8gcmVzdWJtaXQgKG9wdGlvbiAxKSwgc2Vl IGhvdyAKc3RhYmxlLWtlcm5lbC1ydWxlcy5yc3Qgc2FpZDoKCiIiCgo6cmVmOmBvcHRpb25fMWAg aXMgKipzdHJvbmdseSoqIHByZWZlcnJlZCwgaXMgdGhlIGVhc2llc3QgYW5kIG1vc3QgY29tbW9u Lgo6cmVmOmBvcHRpb25fMmAgYW5kIDpyZWY6YG9wdGlvbl8zYCBhcmUgbW9yZSB1c2VmdWwgaWYg dGhlIHBhdGNoIGlzbid0IApkZWVtZWQKd29ydGh5IGF0IHRoZSB0aW1lIGl0IGlzIGFwcGxpZWQg dG8gYSBwdWJsaWMgZ2l0IHRyZWUgKGZvciBpbnN0YW5jZSwgYmVjYXVzZQppdCBkZXNlcnZlcyBt b3JlIHJlZ3Jlc3Npb24gdGVzdGluZyBmaXJzdCkuCgoiIiIKClRoYW5rcwoKCj4+Cj4+IFRoYW5r cwo+Pgo+Pgo+Pj4gLS0tCj4+PiDCoCB2aXJ0L2xpYi9pcnFieXBhc3MuYyB8IDE2ICsrKysrKy0t LS0tLS0tLS0KPj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDEwIGRlbGV0 aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS92aXJ0L2xpYi9pcnFieXBhc3MuYyBiL3ZpcnQv bGliL2lycWJ5cGFzcy5jCj4+PiBpbmRleCBjOWJiMzk1N2Y1OGEuLjI4ZmRhNDJlNDcxYiAxMDA2 NDQKPj4+IC0tLSBhL3ZpcnQvbGliL2lycWJ5cGFzcy5jCj4+PiArKysgYi92aXJ0L2xpYi9pcnFi eXBhc3MuYwo+Pj4gQEAgLTQwLDIxICs0MCwxNyBAQCBzdGF0aWMgaW50IF9fY29ubmVjdChzdHJ1 Y3QgaXJxX2J5cGFzc19wcm9kdWNlciAKPj4+ICpwcm9kLAo+Pj4gwqDCoMKgwqDCoCBpZiAocHJv ZC0+YWRkX2NvbnN1bWVyKQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IHByb2QtPmFkZF9j b25zdW1lcihwcm9kLCBjb25zKTsKPj4+IMKgIC3CoMKgwqAgaWYgKHJldCkKPj4+IC3CoMKgwqDC oMKgwqDCoCBnb3RvIGVycl9hZGRfY29uc3VtZXI7Cj4+PiAtCj4+PiAtwqDCoMKgIHJldCA9IGNv bnMtPmFkZF9wcm9kdWNlcihjb25zLCBwcm9kKTsKPj4+IC3CoMKgwqAgaWYgKHJldCkKPj4+IC3C oMKgwqDCoMKgwqDCoCBnb3RvIGVycl9hZGRfcHJvZHVjZXI7Cj4+PiArwqDCoMKgIGlmICghcmV0 KSB7Cj4+PiArwqDCoMKgwqDCoMKgwqAgcmV0ID0gY29ucy0+YWRkX3Byb2R1Y2VyKGNvbnMsIHBy b2QpOwo+Pj4gK8KgwqDCoMKgwqDCoMKgIGlmIChyZXQgJiYgcHJvZC0+ZGVsX2NvbnN1bWVyKQo+ Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcHJvZC0+ZGVsX2NvbnN1bWVyKHByb2QsIGNvbnMp Owo+Pj4gK8KgwqDCoCB9Cj4+PiDCoCDCoMKgwqDCoMKgIGlmIChjb25zLT5zdGFydCkKPj4+IMKg wqDCoMKgwqDCoMKgwqDCoCBjb25zLT5zdGFydChjb25zKTsKPj4+IMKgwqDCoMKgwqAgaWYgKHBy b2QtPnN0YXJ0KQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHByb2QtPnN0YXJ0KHByb2QpOwo+Pj4g LWVycl9hZGRfcHJvZHVjZXI6Cj4+PiAtwqDCoMKgIGlmIChwcm9kLT5kZWxfY29uc3VtZXIpCj4+ PiAtwqDCoMKgwqDCoMKgwqAgcHJvZC0+ZGVsX2NvbnN1bWVyKHByb2QsIGNvbnMpOwo+Pj4gLWVy cl9hZGRfY29uc3VtZXI6Cj4+PiArCj4+PiDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4+PiDCoCB9 Cj4+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==