From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v4 2/5] vhost: support selective datapath
Date: Sat, 31 Mar 2018 09:38:18 +0200
Message-ID: <e5e78233-1a20-7bc5-14d4-dadf6411bbdf@redhat.com>
References: <1517614137-62926-1-git-send-email-zhihong.wang@intel.com>
 <20180310100148.12030-1-zhihong.wang@intel.com>
 <20180310100148.12030-3-zhihong.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: jianfeng.tan@intel.com, tiwei.bie@intel.com, yliu@fridaylinux.org,
 cunming.liang@intel.com, xiao.w.wang@intel.com, dan.daly@intel.com
To: Zhihong Wang <zhihong.wang@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 965CA4CBD
 for <dev@dpdk.org>; Sat, 31 Mar 2018 09:38:22 +0200 (CEST)
In-Reply-To: <20180310100148.12030-3-zhihong.wang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 03/10/2018 11:01 AM, Zhihong Wang wrote:
> +		uint64_t *size);
> +/* Device ops */
> +struct rte_vdpa_dev_ops {
> +	vdpa_dev_queue_num_get_t  queue_num_get;
> +	vdpa_dev_feature_get_t    feature_get;
> +	vdpa_dev_feature_get_t    protocol_feature_get;

I would prefer them to be named as in Vhost-user spec:

get_queue_num
get_features
get_protocol_features

Thanks,
Maxime