All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ihar Hrachyshka <ihrachys@redhat.com>
To: davem@davemloft.net, ja@ssi.bg
Cc: Ihar Hrachyshka <ihrachys@redhat.com>, netdev@vger.kernel.org
Subject: [PATCH v2 1/4] arp: fixed error in a comment
Date: Thu, 18 May 2017 12:41:18 -0700	[thread overview]
Message-ID: <e5f5c7e601bbc644f6a42ea1574170f81450ca44.1495136258.git.ihrachys@redhat.com> (raw)
In-Reply-To: <cover.1495136258.git.ihrachys@redhat.com>
In-Reply-To: <cover.1495136258.git.ihrachys@redhat.com>

the is_garp code deals just with gratuitous ARP packets, not every
unsolicited packet.

This patch is a result of a discussion in netdev:
http://marc.info/?l=linux-netdev&m=149506354216994

Suggested-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
---
 net/ipv4/arp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
index d54345a..053492a 100644
--- a/net/ipv4/arp.c
+++ b/net/ipv4/arp.c
@@ -846,7 +846,7 @@ static int arp_process(struct net *net, struct sock *sk, struct sk_buff *skb)
 		 */
 		is_garp = tip == sip && addr_type == RTN_UNICAST;
 
-		/* Unsolicited ARP _replies_ also require target hwaddr to be
+		/* Gratuitous ARP _replies_ also require target hwaddr to be
 		 * the same as source.
 		 */
 		if (is_garp && arp->ar_op == htons(ARPOP_REPLY))
-- 
2.9.3

  reply	other threads:[~2017-05-18 19:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 19:41 [PATCH v2 0/4] arp: always override existing neigh entries with gratuitous ARP Ihar Hrachyshka
2017-05-18 19:41 ` Ihar Hrachyshka [this message]
2017-05-18 19:41 ` [PATCH v2 2/4] arp: decompose is_garp logic into a separate function Ihar Hrachyshka
2017-05-18 20:49   ` Julian Anastasov
2017-05-24 21:38     ` Ihar Hrachyshka
2017-05-18 19:41 ` [PATCH v2 3/4] arp: postpone addr_type calculation to as late as possible Ihar Hrachyshka
2017-05-18 19:41 ` [PATCH v2 4/4] arp: always override existing neigh entries with gratuitous ARP Ihar Hrachyshka
2017-05-21 17:27 ` [PATCH v2 0/4] " David Miller
2017-05-23 20:56 ` Arnd Bergmann
2017-05-24 21:32   ` Ihar Hrachyshka
2017-05-24 21:57     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5f5c7e601bbc644f6a42ea1574170f81450ca44.1495136258.git.ihrachys@redhat.com \
    --to=ihrachys@redhat.com \
    --cc=davem@davemloft.net \
    --cc=ja@ssi.bg \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.