From: Guenter Roeck <linux@roeck-us.net>
To: Corentin Labbe <clabbe@baylibre.com>, jdelvare@suse.com
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v3 2/2] hwmon: acpi_power_meter: convert to hwmon_device_register_with_info
Date: Wed, 11 May 2022 19:10:29 -0700 [thread overview]
Message-ID: <e5f6c712-efed-2126-de2b-9a0d09150e7b@roeck-us.net> (raw)
In-Reply-To: <20220509063010.3878134-3-clabbe@baylibre.com>
Corentin,
On 5/8/22 23:30, Corentin Labbe wrote:
> Booting lead to a hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info().
> So let's convert the driver to use hwmon_device_register_with_info().
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
[ ... ]
> @@ -836,20 +740,20 @@ static void acpi_power_meter_notify(struct acpi_device *device, u32 event)
> if (res)
> break;
>
> - remove_attrs(resource);
> + remove_domain_devices(resource);
> setup_attrs(resource);
Zhang Rui found an interesting problem with this code:
It needs a call to sysfs_update_groups(hwmon_dev->groups)
to update sysfs attribute visibility, probably between
remove_domain_devices() and setup_attrs().
> break;
> case METER_NOTIFY_TRIP:
> - sysfs_notify(&device->dev.kobj, NULL, POWER_AVERAGE_NAME);
> + hwmon_notify_event(&device->dev, hwmon_power, hwmon_power_average, 0);
... which makes realize: The notification device should be the hwmon device.
That would be resource->hwmon_dev, not the acpi device.
Thanks,
Guenter
next prev parent reply other threads:[~2022-05-12 2:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 6:30 [PATCH v3 0/2] hwmon: acpi_power_meter: convert to new hwmon API Corentin Labbe
2022-05-09 6:30 ` [PATCH v3 1/2] hwmon: acpi_power_meter: fix style issue Corentin Labbe
2022-05-10 2:39 ` Guenter Roeck
2022-05-09 6:30 ` [PATCH v3 2/2] hwmon: acpi_power_meter: convert to hwmon_device_register_with_info Corentin Labbe
2022-05-10 3:05 ` Guenter Roeck
2022-05-12 2:10 ` Guenter Roeck [this message]
2022-05-13 8:02 ` LABBE Corentin
2022-05-13 11:33 ` Zhang Rui
2022-05-13 13:03 ` Guenter Roeck
2022-05-15 19:36 ` LABBE Corentin
2022-05-16 0:29 ` Guenter Roeck
2022-05-16 6:21 ` LABBE Corentin
2022-05-16 12:21 ` Guenter Roeck
2022-05-21 13:52 ` Guenter Roeck
2022-05-21 19:16 ` LABBE Corentin
2022-06-30 14:49 ` LABBE Corentin
2022-06-30 15:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f6c712-efed-2126-de2b-9a0d09150e7b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clabbe@baylibre.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.