From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:47480 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbeG0KuE (ORCPT ); Fri, 27 Jul 2018 06:50:04 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Fri, 27 Jul 2018 17:29:00 +0800 From: Wen Gong To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: ath10k@lists.infradead.org, johannes@sipsolutions.net, linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips In-Reply-To: <87zhye1aqg.fsf@toke.dk> References: <1532589677-16428-1-git-send-email-wgong@codeaurora.org> <1532589677-16428-3-git-send-email-wgong@codeaurora.org> <87zhye1aqg.fsf@toke.dk> Message-ID: (sfid-20180727_112905_255460_7DAB6A7D) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-07-26 19:45, Toke Høiland-Jørgensen wrote: > Wen Gong writes: > >> Upstream kernel has an interface to help adjust sk_pacing_shift to >> help >> improve TCP UL throughput. >> The sk_pacing_shift is 8 in mac80211, this is based on test with 11N >> WiFi chips with ath9k. For QCA6174/QCA9377 PCI 11AC chips, the 11AC >> VHT80 TCP UL throughput testing result shows 6 is the optimal. >> Overwrite the sk_pacing_shift to 6 in ath10k driver. > > When I tested this, a pacing shift of 8 was quite close to optimal as > well for ath10k. Why are you getting different results? the default value is still 8 in the patch: https://patchwork.kernel.org/patch/10545361/ In my test, pacing shift 6 is better than 8. The test is for ath10k/11AC WiFi chips. Test result is show in the commit logs before. > >> Tested with QCA6174 PCI with firmware >> WLAN.RM.4.4.1-00109-QCARMSWPZ-1, but this will also affect QCA9377 >> PCI. >> It's not a regression with new firmware releases. >> >> There have 2 test result of different settings: >> >> ARM CPU based device with QCA6174A PCI with different >> sk_pacing_shift: >> >> sk_pacing_shift throughput(Mbps) CPU utilization >> 6 500(-P5) ~75% idle, Focus on CPU1: ~14%idle >> 7 454(-P5) ~80% idle, Focus on CPU1: ~4%idle >> 8 288 ~90% idle, Focus on CPU1: ~35%idle >> 9 ~200 ~92% idle, Focus on CPU1: ~50%idle > > Your tests do not include latency values; please try running a test > that > also measures latency. The tcp_nup test in Flent (https://flent.org) > will do that, for instance. Also, is this a single TCP flow? > It is not a single TCP flow, it is 500Mbps with 5 flows. below is result show in commit log before: 5G TCP UL VTH80 on X86 platform with QCA6174A PCI with sk_packing_shift set to 6: tcp_limit_output_bytes throughput(Mbps) default(262144)+1 Stream 336 default(262144)+2 Streams 558 default(262144)+3 Streams 584 default(262144)+4 Streams 602 default(262144)+5 Streams 598 changed(2621440)+1 Stream 598 changed(2621440)+2 Streams 601 > -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fiz3f-0001C9-UZ for ath10k@lists.infradead.org; Fri, 27 Jul 2018 09:29:13 +0000 MIME-Version: 1.0 Date: Fri, 27 Jul 2018 17:29:00 +0800 From: Wen Gong Subject: Re: [PATCH 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips In-Reply-To: <87zhye1aqg.fsf@toke.dk> References: <1532589677-16428-1-git-send-email-wgong@codeaurora.org> <1532589677-16428-3-git-send-email-wgong@codeaurora.org> <87zhye1aqg.fsf@toke.dk> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOC0wNy0yNiAxOTo0NSwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+IFdl biBHb25nIDx3Z29uZ0Bjb2RlYXVyb3JhLm9yZz4gd3JpdGVzOgo+IAo+PiBVcHN0cmVhbSBrZXJu ZWwgaGFzIGFuIGludGVyZmFjZSB0byBoZWxwIGFkanVzdCBza19wYWNpbmdfc2hpZnQgdG8gCj4+ IGhlbHAKPj4gaW1wcm92ZSBUQ1AgVUwgdGhyb3VnaHB1dC4KPj4gVGhlIHNrX3BhY2luZ19zaGlm dCBpcyA4IGluIG1hYzgwMjExLCB0aGlzIGlzIGJhc2VkIG9uIHRlc3Qgd2l0aCAxMU4KPj4gV2lG aSBjaGlwcyB3aXRoIGF0aDlrLiBGb3IgUUNBNjE3NC9RQ0E5Mzc3IFBDSSAxMUFDIGNoaXBzLCB0 aGUgMTFBQwo+PiBWSFQ4MCBUQ1AgVUwgdGhyb3VnaHB1dCB0ZXN0aW5nIHJlc3VsdCBzaG93cyA2 IGlzIHRoZSBvcHRpbWFsLgo+PiBPdmVyd3JpdGUgdGhlIHNrX3BhY2luZ19zaGlmdCB0byA2IGlu IGF0aDEwayBkcml2ZXIuCj4gCj4gV2hlbiBJIHRlc3RlZCB0aGlzLCBhIHBhY2luZyBzaGlmdCBv ZiA4IHdhcyBxdWl0ZSBjbG9zZSB0byBvcHRpbWFsIGFzCj4gd2VsbCBmb3IgYXRoMTBrLiBXaHkg YXJlIHlvdSBnZXR0aW5nIGRpZmZlcmVudCByZXN1bHRzPwoKdGhlIGRlZmF1bHQgdmFsdWUgaXMg c3RpbGwgOCBpbiB0aGUgcGF0Y2g6Cmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gv MTA1NDUzNjEvCgpJbiBteSB0ZXN0LCBwYWNpbmcgc2hpZnQgNiBpcyBiZXR0ZXIgdGhhbiA4LgpU aGUgdGVzdCBpcyBmb3IgYXRoMTBrLzExQUMgV2lGaSBjaGlwcy4KVGVzdCByZXN1bHQgaXMgc2hv dyBpbiB0aGUgY29tbWl0IGxvZ3MgYmVmb3JlLgo+IAo+PiBUZXN0ZWQgd2l0aCBRQ0E2MTc0IFBD SSB3aXRoIGZpcm13YXJlCj4+IFdMQU4uUk0uNC40LjEtMDAxMDktUUNBUk1TV1BaLTEsIGJ1dCB0 aGlzIHdpbGwgYWxzbyBhZmZlY3QgUUNBOTM3NyAKPj4gUENJLgo+PiBJdCdzIG5vdCBhIHJlZ3Jl c3Npb24gd2l0aCBuZXcgZmlybXdhcmUgcmVsZWFzZXMuCj4+IAo+PiBUaGVyZSBoYXZlIDIgdGVz dCByZXN1bHQgb2YgZGlmZmVyZW50IHNldHRpbmdzOgo+PiAKPj4gQVJNIENQVSBiYXNlZCBkZXZp Y2Ugd2l0aCBRQ0E2MTc0QSBQQ0kgd2l0aCBkaWZmZXJlbnQKPj4gc2tfcGFjaW5nX3NoaWZ0Ogo+ PiAKPj4gIHNrX3BhY2luZ19zaGlmdCAgdGhyb3VnaHB1dChNYnBzKSAgICAgICAgICAgICBDUFUg dXRpbGl6YXRpb24KPj4gICAgICAgICAgNiAgICAgICAgICAgIDUwMCgtUDUpICAgICAgfjc1JSBp ZGxlLCBGb2N1cyBvbiBDUFUxOiB+MTQlaWRsZQo+PiAgICAgICAgICA3ICAgICAgICAgICAgNDU0 KC1QNSkgICAgICB+ODAlIGlkbGUsIEZvY3VzIG9uIENQVTE6IH40JWlkbGUKPj4gICAgICAgICAg OCAgICAgICAgICAgICAgIDI4OCAgICAgICAgfjkwJSBpZGxlLCBGb2N1cyBvbiBDUFUxOiB+MzUl aWRsZQo+PiAgICAgICAgICA5ICAgICAgICAgICAgICB+MjAwICAgICAgICB+OTIlIGlkbGUsIEZv Y3VzIG9uIENQVTE6IH41MCVpZGxlCj4gCj4gWW91ciB0ZXN0cyBkbyBub3QgaW5jbHVkZSBsYXRl bmN5IHZhbHVlczsgcGxlYXNlIHRyeSBydW5uaW5nIGEgdGVzdCAKPiB0aGF0Cj4gYWxzbyBtZWFz dXJlcyBsYXRlbmN5LiBUaGUgdGNwX251cCB0ZXN0IGluIEZsZW50IChodHRwczovL2ZsZW50Lm9y ZykKPiB3aWxsIGRvIHRoYXQsIGZvciBpbnN0YW5jZS4gQWxzbywgaXMgdGhpcyBhIHNpbmdsZSBU Q1AgZmxvdz8KPiAKCkl0IGlzIG5vdCBhIHNpbmdsZSBUQ1AgZmxvdywgaXQgaXMgNTAwTWJwcyB3 aXRoIDUgZmxvd3MuCgpiZWxvdyBpcyByZXN1bHQgc2hvdyBpbiBjb21taXQgbG9nIGJlZm9yZToK NUcgVENQIFVMIFZUSDgwIG9uIFg4NiBwbGF0Zm9ybSB3aXRoIFFDQTYxNzRBIFBDSSB3aXRoIHNr X3BhY2tpbmdfc2hpZnQKc2V0IHRvIDY6CgogICB0Y3BfbGltaXRfb3V0cHV0X2J5dGVzICAgICAg ICAgICAgdGhyb3VnaHB1dChNYnBzKQogIGRlZmF1bHQoMjYyMTQ0KSsxIFN0cmVhbSAgICAgICAg ICAgICAgICAgMzM2CiAgZGVmYXVsdCgyNjIxNDQpKzIgU3RyZWFtcyAgICAgICAgICAgICAgICA1 NTgKICBkZWZhdWx0KDI2MjE0NCkrMyBTdHJlYW1zICAgICAgICAgICAgICAgIDU4NAogIGRlZmF1 bHQoMjYyMTQ0KSs0IFN0cmVhbXMgICAgICAgICAgICAgICAgNjAyCiAgZGVmYXVsdCgyNjIxNDQp KzUgU3RyZWFtcyAgICAgICAgICAgICAgICA1OTgKICBjaGFuZ2VkKDI2MjE0NDApKzEgU3RyZWFt ICAgICAgICAgICAgICAgIDU5OAogIGNoYW5nZWQoMjYyMTQ0MCkrMiBTdHJlYW1zICAgICAgICAg ICAgICAgNjAxCgo+IC1Ub2tlCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg==