From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F97C4332F for ; Mon, 7 Nov 2022 18:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233068AbiKGSDv (ORCPT ); Mon, 7 Nov 2022 13:03:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233278AbiKGSCR (ORCPT ); Mon, 7 Nov 2022 13:02:17 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 23F03248FF for ; Mon, 7 Nov 2022 09:59:03 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4F471FB; Mon, 7 Nov 2022 09:59:08 -0800 (PST) Received: from [10.34.100.128] (pierre123.nice.arm.com [10.34.100.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B0C23F534; Mon, 7 Nov 2022 09:59:01 -0800 (PST) Message-ID: Date: Mon, 7 Nov 2022 18:58:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 06/23] arm64: dts: Update cache properties for broadcom Content-Language: en-US To: Florian Fainelli , "linux-kernel@vger.kernel.org" , Broadcom internal kernel review list , William Zhang , Rob Herring , Krzysztof Kozlowski References: <20221107155825.1644604-1-pierre.gondois@arm.com> <20221107155825.1644604-7-pierre.gondois@arm.com> <8ee17547-30ef-bc85-b163-f0d9efe70fcc@gmail.com> From: Pierre Gondois In-Reply-To: <8ee17547-30ef-bc85-b163-f0d9efe70fcc@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/7/22 18:31, Florian Fainelli wrote: > (way too many recipients, gmail's SMTP server would not allow me to > respond unless I moved most people to BCC now done). > > On 11/7/22 07:56, Pierre Gondois wrote: >> The DeviceTree Specification v0.3 specifies that the cache node >> 'compatible' and 'cache-level' properties are 'required'. Cf. >> s3.8 Multi-level and Shared Cache Nodes >> The 'cache-unified' property should be present if one of the >> properties for unified cache is present ('cache-size', ...). >> >> Update the Device Trees accordingly. >> >> Signed-off-by: Pierre Gondois >> Acked-by: William Zhang > > This looks fine, but incomplete, you seem to have missed: > > - adding 'cache-unified' to all of the cache nodes modified in this > patch set that did not have one already > > - bcm63148.dtsi, bcm63178.dtsi, bcm6756.dtsi, bcm6846.dtsi, > bcm6855.dtsi, bcm6878.dtsi, bcm47622.dtsi > > Thanks I indeed forgot to update some platforms in the broadcom folder. The other folders should be complete. Regards, Pierre