From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: [PATCH 14/35] kvm: Drop return value of kvm_cpu_exec Date: Thu, 6 Jan 2011 15:56:20 -0200 Message-ID: References: Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Jan Kiszka , Marcelo Tosatti To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43772 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752092Ab1AFSDh (ORCPT ); Thu, 6 Jan 2011 13:03:37 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: From: Jan Kiszka It is not used, it is not needed, so let's remove it. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c | 6 ++---- kvm-stub.c | 4 ++-- kvm.h | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 2538283..7518f2c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -850,7 +850,7 @@ void kvm_cpu_synchronize_post_init(CPUState *env) env->kvm_vcpu_dirty = 0; } -int kvm_cpu_exec(CPUState *env) +void kvm_cpu_exec(CPUState *env) { struct kvm_run *run = env->kvm_run; int ret; @@ -943,7 +943,7 @@ int kvm_cpu_exec(CPUState *env) #ifdef KVM_CAP_SET_GUEST_DEBUG if (kvm_arch_debug(&run->debug.arch)) { env->exception_index = EXCP_DEBUG; - return 0; + return; } /* re-enter, this exception was guest-internal */ ret = 1; @@ -960,8 +960,6 @@ int kvm_cpu_exec(CPUState *env) env->exit_request = 0; env->exception_index = EXCP_INTERRUPT; } - - return ret; } int kvm_ioctl(KVMState *s, int type, ...) diff --git a/kvm-stub.c b/kvm-stub.c index 5384a4b..352c6a6 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -79,9 +79,9 @@ void kvm_cpu_synchronize_post_init(CPUState *env) { } -int kvm_cpu_exec(CPUState *env) +void kvm_cpu_exec(CPUState *env) { - abort (); + abort(); } int kvm_has_sync_mmu(void) diff --git a/kvm.h b/kvm.h index 60a9b42..51ad56f 100644 --- a/kvm.h +++ b/kvm.h @@ -46,7 +46,7 @@ int kvm_has_xcrs(void); #ifdef NEED_CPU_H int kvm_init_vcpu(CPUState *env); -int kvm_cpu_exec(CPUState *env); +void kvm_cpu_exec(CPUState *env); #if !defined(CONFIG_USER_ONLY) int kvm_log_start(target_phys_addr_t phys_addr, ram_addr_t size); -- 1.7.2.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=32938 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PauBJ-0003xa-3X for qemu-devel@nongnu.org; Thu, 06 Jan 2011 13:03:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PauBD-0006dj-DB for qemu-devel@nongnu.org; Thu, 06 Jan 2011 13:03:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:10896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PauBD-0006cx-4n for qemu-devel@nongnu.org; Thu, 06 Jan 2011 13:03:19 -0500 From: Marcelo Tosatti Date: Thu, 6 Jan 2011 15:56:20 -0200 Message-Id: In-Reply-To: References: Subject: [Qemu-devel] [PATCH 14/35] kvm: Drop return value of kvm_cpu_exec List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org From: Jan Kiszka It is not used, it is not needed, so let's remove it. Signed-off-by: Jan Kiszka Signed-off-by: Marcelo Tosatti --- kvm-all.c | 6 ++---- kvm-stub.c | 4 ++-- kvm.h | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 2538283..7518f2c 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -850,7 +850,7 @@ void kvm_cpu_synchronize_post_init(CPUState *env) env->kvm_vcpu_dirty = 0; } -int kvm_cpu_exec(CPUState *env) +void kvm_cpu_exec(CPUState *env) { struct kvm_run *run = env->kvm_run; int ret; @@ -943,7 +943,7 @@ int kvm_cpu_exec(CPUState *env) #ifdef KVM_CAP_SET_GUEST_DEBUG if (kvm_arch_debug(&run->debug.arch)) { env->exception_index = EXCP_DEBUG; - return 0; + return; } /* re-enter, this exception was guest-internal */ ret = 1; @@ -960,8 +960,6 @@ int kvm_cpu_exec(CPUState *env) env->exit_request = 0; env->exception_index = EXCP_INTERRUPT; } - - return ret; } int kvm_ioctl(KVMState *s, int type, ...) diff --git a/kvm-stub.c b/kvm-stub.c index 5384a4b..352c6a6 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -79,9 +79,9 @@ void kvm_cpu_synchronize_post_init(CPUState *env) { } -int kvm_cpu_exec(CPUState *env) +void kvm_cpu_exec(CPUState *env) { - abort (); + abort(); } int kvm_has_sync_mmu(void) diff --git a/kvm.h b/kvm.h index 60a9b42..51ad56f 100644 --- a/kvm.h +++ b/kvm.h @@ -46,7 +46,7 @@ int kvm_has_xcrs(void); #ifdef NEED_CPU_H int kvm_init_vcpu(CPUState *env); -int kvm_cpu_exec(CPUState *env); +void kvm_cpu_exec(CPUState *env); #if !defined(CONFIG_USER_ONLY) int kvm_log_start(target_phys_addr_t phys_addr, ram_addr_t size); -- 1.7.2.3