From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB68DC47087 for ; Fri, 28 May 2021 07:22:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98B41613F0 for ; Fri, 28 May 2021 07:22:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98B41613F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.133817.249267 (Exim 4.92) (envelope-from ) id 1lmWoZ-0005iO-0H; Fri, 28 May 2021 07:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 133817.249267; Fri, 28 May 2021 07:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lmWoY-0005iH-T8; Fri, 28 May 2021 07:21:50 +0000 Received: by outflank-mailman (input) for mailman id 133817; Fri, 28 May 2021 07:21:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lmWoX-0005iB-KT for xen-devel@lists.xenproject.org; Fri, 28 May 2021 07:21:49 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 53687a03-1455-4353-bc47-1652cc8b435b; Fri, 28 May 2021 07:21:48 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 63B0E1FD2F; Fri, 28 May 2021 07:21:47 +0000 (UTC) Received: from director2.suse.de (director2.suse-dmz.suse.de [192.168.254.72]) by imap.suse.de (Postfix) with ESMTPSA id 2798911A98; Fri, 28 May 2021 07:21:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53687a03-1455-4353-bc47-1652cc8b435b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1622186507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/k9p3WclJ76DHTPc78htGDW+dmcq4nCb/eORYnSOm2k=; b=IpXWyfTtJEELs8BswrVnUl/yu7s+fRkk8125LHM9D0OK9pynqS8Ff76hWiMQm+lkmNk0nh Qx43Nj+QNCNeSGe4IQF/7OQI6IAbTdp/JmoTW0L6oo8uemZfo2WO2KM3KTqcDSxswRn5gT n4TNnCyR42cXuFBlrbBRkcKuG3LRwuU= Subject: Re: [PATCH v3 1/2] libelf: don't attempt to parse __xen_guest for PVH From: Jan Beulich To: Ian Jackson , Wei Liu Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Roger Pau Monne References: <20210520123012.89855-1-roger.pau@citrix.com> <20210520123012.89855-2-roger.pau@citrix.com> <29ecaaaf-d096-e8af-fc6f-292ff2b3d5ae@suse.com> <6dd3d6fe-04cc-4b9d-e92f-6d4c81785300@suse.com> Message-ID: Date: Fri, 28 May 2021 09:21:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <6dd3d6fe-04cc-4b9d-e92f-6d4c81785300@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 21.05.2021 15:31, Jan Beulich wrote: > On 20.05.2021 14:35, Jan Beulich wrote: >> On 20.05.2021 14:30, Roger Pau Monne wrote: >>> The legacy __xen_guest section doesn't support the PHYS32_ENTRY >>> elfnote, so it's pointless to attempt to parse the elfnotes from that >>> section when called from an hvm container. >>> >>> Suggested-by: Jan Beulich >>> Signed-off-by: Roger Pau Monné >>> --- >>> Changes since v2: >>> - New in this version. >>> --- >>> xen/common/libelf/libelf-dominfo.c | 6 ++---- >>> 1 file changed, 2 insertions(+), 4 deletions(-) >>> >>> diff --git a/xen/common/libelf/libelf-dominfo.c b/xen/common/libelf/libelf-dominfo.c >>> index 69c94b6f3bb..abea1011c18 100644 >>> --- a/xen/common/libelf/libelf-dominfo.c >>> +++ b/xen/common/libelf/libelf-dominfo.c >>> @@ -577,10 +577,8 @@ elf_errorstatus elf_xen_parse(struct elf_binary *elf, >>> >>> } >>> >>> - /* >>> - * Finally fall back to the __xen_guest section. >>> - */ >>> - if ( xen_elfnotes == 0 ) >>> + /* Finally fall back to the __xen_guest section for PV guests only. */ >>> + if ( xen_elfnotes == 0 && !hvm ) >> >> Isn't this depending on the 2nd patch adding the function parameter? >> IOW doesn't this break the build, even if just transiently? With the >> respective hunk from patch 2 moved here >> Reviewed-by: Jan Beulich > > With the intention of committing I did this hunk movement, noticing > that > - it's more than just one hunk, > - a tool stack maintainer ack is actually going to be needed (all > respective hunks are now in the first patch). > I'll keep the massaged patches locally, until the missing ack arrives. I've timed out waiting for an ack and committed the patches, considering the tool stack parts of them are mechanical enough. Jan