From: Jiri Slaby <jirislaby@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tty: n_gsm: clean up indenting in gsm_queue()
Date: Wed, 6 Oct 2021 07:52:03 +0200 [thread overview]
Message-ID: <e614e753-5eec-225e-7437-f2ad650585ba@kernel.org> (raw)
In-Reply-To: <20211004104343.GF25015@kili>
On 04. 10. 21, 12:43, Dan Carpenter wrote:
> These two lines need to be indented one more tab.
Right, the indentation is incorrect (and not the closing brace).
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/tty/n_gsm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 157b51ce9cc0..3bbfcccd79d3 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -1854,8 +1854,8 @@ static void gsm_queue(struct gsm_mux *gsm)
> if (address_tmp == address) {
> for (k = j; k < addr_cnt; k++)
> addr_open[k] = addr_open[k+1];
> - addr_cnt--;
> - break;
> + addr_cnt--;
> + break;
> }
> }
> }
>
--
js
suse labs
prev parent reply other threads:[~2021-10-06 5:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 10:43 [PATCH] tty: n_gsm: clean up indenting in gsm_queue() Dan Carpenter
2021-10-06 5:52 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e614e753-5eec-225e-7437-f2ad650585ba@kernel.org \
--to=jirislaby@kernel.org \
--cc=Zhenguo.Zhao1@unisoc.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.