From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/tap: add support for fixed mac addresses
Date: Tue, 11 Apr 2017 09:31:20 +0100
Message-ID: <e62b36cf-1d4c-3eff-c39d-274bbe846132@intel.com>
References: <20170410181850.44845-1-keith.wiles@intel.com>
 <20170411091851.62ab28ad@paques.dev.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Pascal Mazon <pascal.mazon@6wind.com>, Keith Wiles <keith.wiles@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id BC9575587
 for <dev@dpdk.org>; Tue, 11 Apr 2017 10:31:24 +0200 (CEST)
In-Reply-To: <20170411091851.62ab28ad@paques.dev.6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/11/2017 8:18 AM, Pascal Mazon wrote:
> Hi Keith,
> 
> I have a few comments on your patch, see inline.
> 
> On Mon, 10 Apr 2017 13:18:50 -0500
> Keith Wiles <keith.wiles@intel.com> wrote:
> 
>> Support for a fixed MAC address for testing with the last octet
>> incrementing by one for each interface defined with the new 'mac=fixed'
>> string on the --vdev option. The default option is still to randomize
>> the MAC address for each tap interface.
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>

<...>

>>  RTE_PMD_REGISTER_VDEV(net_tap, pmd_tap_drv);
>>  RTE_PMD_REGISTER_ALIAS(net_tap, eth_tap);
>> -RTE_PMD_REGISTER_PARAM_STRING(net_tap, "iface=<string>,speed=N");
>> +RTE_PMD_REGISTER_PARAM_STRING(net_tap,
>> +			      "iface=<string>,"
>> +			      "speed=N,"
>> +			      "remote=<string>,"
>> +			      "mac=fixed");
> 
> Indeed, I forgot to update that when I introduced the remote!

Hi Pascal,

If you can send a patch for this, it can be quickly merged, so it won't
have to be in this patch.

> 
> That's it for me,
> Thank you.
> 
> Pascal
>