From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0750DC4320A for ; Tue, 27 Jul 2021 00:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD99D60F90 for ; Tue, 27 Jul 2021 00:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234321AbhGZXVU (ORCPT ); Mon, 26 Jul 2021 19:21:20 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:19596 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233770AbhGZXVS (ORCPT ); Mon, 26 Jul 2021 19:21:18 -0400 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16QNvi4m005216; Tue, 27 Jul 2021 00:01:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2021-07-09; bh=bsmhKNCh74dd0jh/AeoLSfM0YVz66eHJHAkqLKDrD84=; b=jBfCeJJlGtbku146rCvjrGG/suI3c58BHeRRV/ericynMq8i++dUwmgKM6OTaNG9vzis TLtkFTFhG8MbpEvMGHQ978D6le4O1b4dW8cssIgJ5A5vokyP4tyE06VWZ565QBqJv3rd mIjg19mCS2gbwswdGQadh450ZfEIZ+NGx1dNe4ruUlWFrj8y/iY7ep+am+lqDzsJ+TWS T+NAWYgtW6DkEKQV3EykPPkVT7UdLF9F7lYhcvv5o7dCibEpU8uaXpWpu0IKKMJvFE5v I9I68o+rW/ukINLi6pz35Hc2L5InOBF1xk/p4M5ZNhD77p/lJfoNz3TWhIfxPNwJIziT qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=bsmhKNCh74dd0jh/AeoLSfM0YVz66eHJHAkqLKDrD84=; b=ZHj7YwW+ZZMlTsMbExIvaNnid4UUXAFxdFJfs0v2r29K/nZvIo0uOsr2/Fc5q2cN2UA1 wh+acTYjwokT6NMD4tQ9pKy+E+cGBaX004CzDpoOCNaG7lsLYRIuETD5ACrXWuIsOywS Q4kIyCuz9j09hNco/vLRZd+G23POJZjC14pSSh2VJon9Appfxxs5NudWabVNAHraSpIi MX9MJD1JGEW2lLfiW0I8QfTtxjyljQXkuOA61uBVJt/Hbg/iW5r62YXKWggP29rbaj0s xU3MyQrDOuop1DvhO5OnAV/7YdwjvMlAXjBGid8WZOD8r9Djg8bbt5QJGI5tEm57eljN rQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3a2356gdnv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jul 2021 00:01:19 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16QLanCD022899; Tue, 27 Jul 2021 00:01:18 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 3a2351v0u5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jul 2021 00:01:18 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.14.4) with ESMTP id 16R01GoL005404; Tue, 27 Jul 2021 00:01:16 GMT Received: from [192.168.0.104] (/49.207.206.224) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Jul 2021 17:01:16 -0700 Subject: Re: [External] : Re: [PATCH] 9p/xen: Fix end of loop tests for list_for_each_entry To: asmadeus@codewreck.org, Stefano Stabellini Cc: ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net, kuba@kernel.org, v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210725175103.56731-1-harshvardhan.jha@oracle.com> From: Harshvardhan Jha Message-ID: Date: Tue, 27 Jul 2021 05:31:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10057 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107260127 X-Proofpoint-ORIG-GUID: 5XAwKEU5GJBgiLuVWttHggUT-JsZLAnW X-Proofpoint-GUID: 5XAwKEU5GJBgiLuVWttHggUT-JsZLAnW Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/07/21 5:29 am, asmadeus@codewreck.org wrote: > Stefano Stabellini wrote on Mon, Jul 26, 2021 at 04:54:29PM -0700: >>>> Yes, I did test it successfully. Aside from the commit messaged to be >>>> reworded: >>> How's this? >>> ===========================BEGIN======================================== >>> 9p/xen: Fix end of loop tests for list_for_each_entry >>> >>> This patch addresses the following problems: >>> - priv can never be NULL, so this part of the check is useless >>> - if the loop ran through the whole list, priv->client is invalid and >>> it is more appropriate and sufficient to check for the end of >>> list_for_each_entry loop condition. >>> >>> Signed-off-by: Harshvardhan Jha > > Will take the patch with this text as commit message later tonight If you want I can resend the patch with this commit message > > >>>> Reviewed-by: Stefano Stabellini >>>> Tested-by: Stefano Stabellini > > Thanks for the test! >