From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3495DC54FCB for ; Wed, 22 Apr 2020 14:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 196E72077D for ; Wed, 22 Apr 2020 14:10:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726909AbgDVOKM (ORCPT ); Wed, 22 Apr 2020 10:10:12 -0400 Received: from foss.arm.com ([217.140.110.172]:50486 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725839AbgDVOKL (ORCPT ); Wed, 22 Apr 2020 10:10:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D03EE30E; Wed, 22 Apr 2020 07:10:10 -0700 (PDT) Received: from [10.37.12.172] (unknown [10.37.12.172]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EE293F68F; Wed, 22 Apr 2020 07:10:07 -0700 (PDT) Subject: Re: [PATCH 01/26] KVM: arm64: Check advertised Stage-2 page size capability To: maz@kernel.org Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, andre.przywara@arm.com, christoffer.dall@arm.com, dave.martin@arm.com, jintack@cs.columbia.edu, alexandru.elisei@arm.com, gcherian@marvell.com, prime.zeng@hisilicon.com, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, james.morse@arm.com, julien.thierry.kdev@gmail.com References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-2-maz@kernel.org> <32cc9a60-1b47-f3f7-d18d-d39db397ea55@arm.com> <06c3b2c9b23beeeb224d263077299039@kernel.org> From: Suzuki K Poulose Message-ID: Date: Wed, 22 Apr 2020 15:14:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <06c3b2c9b23beeeb224d263077299039@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 04/22/2020 03:07 PM, Marc Zyngier wrote: > Hi Suzuki, > > On 2020-04-22 14:40, Suzuki K Poulose wrote: >> Hi Marc, >> >> On 04/22/2020 01:00 PM, Marc Zyngier wrote: >>> With ARMv8.5-GTG, the hardware (or more likely a hypervisor) can >>> advertise the supported Stage-2 page sizes. >>> >>> Let's check this at boot time. >>> >>> Signed-off-by: Marc Zyngier >>> --- >>>   arch/arm64/include/asm/kvm_host.h |  2 +- >>>   arch/arm64/include/asm/sysreg.h   |  3 +++ >>>   arch/arm64/kernel/cpufeature.c    |  8 +++++++ >>>   arch/arm64/kvm/reset.c            | 40 ++++++++++++++++++++++++++++--- >>>   virt/kvm/arm/arm.c                |  4 +--- >>>   5 files changed, 50 insertions(+), 7 deletions(-) >>> >>> diff --git a/arch/arm64/include/asm/kvm_host.h >>> b/arch/arm64/include/asm/kvm_host.h >>> index 32c8a675e5a4a..7dd8fefa6aecd 100644 >>> --- a/arch/arm64/include/asm/kvm_host.h >>> +++ b/arch/arm64/include/asm/kvm_host.h >>> @@ -670,7 +670,7 @@ static inline int kvm_arm_have_ssbd(void) >>>   void kvm_vcpu_load_sysregs(struct kvm_vcpu *vcpu); >>>   void kvm_vcpu_put_sysregs(struct kvm_vcpu *vcpu); >>>   -void kvm_set_ipa_limit(void); >>> +int kvm_set_ipa_limit(void); >>>     #define __KVM_HAVE_ARCH_VM_ALLOC >>>   struct kvm *kvm_arch_alloc_vm(void); >>> diff --git a/arch/arm64/include/asm/sysreg.h >>> b/arch/arm64/include/asm/sysreg.h >>> index ebc6224328318..5d10c9148e844 100644 >>> --- a/arch/arm64/include/asm/sysreg.h >>> +++ b/arch/arm64/include/asm/sysreg.h >>> @@ -686,6 +686,9 @@ >>>   #define ID_AA64ZFR0_SVEVER_SVE2        0x1 >>>     /* id_aa64mmfr0 */ >>> +#define ID_AA64MMFR0_TGRAN4_2_SHIFT    40 >>> +#define ID_AA64MMFR0_TGRAN64_2_SHIFT    36 >>> +#define ID_AA64MMFR0_TGRAN16_2_SHIFT    32 >>>   #define ID_AA64MMFR0_TGRAN4_SHIFT    28 >>>   #define ID_AA64MMFR0_TGRAN64_SHIFT    24 >>>   #define ID_AA64MMFR0_TGRAN16_SHIFT    20 >>> diff --git a/arch/arm64/kernel/cpufeature.c >>> b/arch/arm64/kernel/cpufeature.c >>> index 9fac745aa7bb2..9892a845d06c9 100644 >>> --- a/arch/arm64/kernel/cpufeature.c >>> +++ b/arch/arm64/kernel/cpufeature.c >>> @@ -208,6 +208,14 @@ static const struct arm64_ftr_bits >>> ftr_id_aa64zfr0[] = { >>>   }; >>>     static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] = { >>> +    /* >>> +     * Page size not being supported at Stage-2 are not fatal. You >>> +     * just give up KVM if PAGE_SIZE isn't supported there. Go fix >>> +     * your favourite nesting hypervisor. >>> +     */ >>> +    ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_EXACT, >>> ID_AA64MMFR0_TGRAN4_2_SHIFT, 4, 1), >>> +    ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_EXACT, >>> ID_AA64MMFR0_TGRAN64_2_SHIFT, 4, 1), >>> +    ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_EXACT, >>> ID_AA64MMFR0_TGRAN16_2_SHIFT, 4, 1), >> >> One minor issue with this is, if we get a system with cpus having values >> 0 and 2 (both of which indicates the stage-2 support), we might reset >> the value to 1 for the feature indicating, we don't support and block >> KVM. But, we can blame the nesting hypervisor for not emulating this to >> (2). Do we need a comment to make this explicit here ? > > Sure. How about something like: > > "There is a small corner case where the hypervisor could explicitly > advertise >  a given granule size at Stage-2 (value 2) on some vCPUs, and use the > fallback >  to Stage-1 (value 0) for other vCPUs. Although this is not forbidden > by the >  architecture, it indicates that the hypervisor is being silly (or buggy). >  We make no effort to cope with this and pretend that if these fields are >  inconsistent across vCPUs, then it isn't worth trying to bring KVM up." > Looks fine to me. Reviewed-by: Suzuki K Poulose From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 834C9C55185 for ; Wed, 22 Apr 2020 14:10:16 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 26FA62084D for ; Wed, 22 Apr 2020 14:10:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26FA62084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A15AA4B174; Wed, 22 Apr 2020 10:10:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ov+OkBI1lxN5; Wed, 22 Apr 2020 10:10:14 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7A3524B0BF; Wed, 22 Apr 2020 10:10:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A5DAB4B0BF for ; Wed, 22 Apr 2020 10:10:12 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yikrovxMLz+i for ; Wed, 22 Apr 2020 10:10:11 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 64FFC4B0B8 for ; Wed, 22 Apr 2020 10:10:11 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D03EE30E; Wed, 22 Apr 2020 07:10:10 -0700 (PDT) Received: from [10.37.12.172] (unknown [10.37.12.172]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EE293F68F; Wed, 22 Apr 2020 07:10:07 -0700 (PDT) Subject: Re: [PATCH 01/26] KVM: arm64: Check advertised Stage-2 page size capability To: maz@kernel.org References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-2-maz@kernel.org> <32cc9a60-1b47-f3f7-d18d-d39db397ea55@arm.com> <06c3b2c9b23beeeb224d263077299039@kernel.org> From: Suzuki K Poulose Message-ID: Date: Wed, 22 Apr 2020 15:14:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <06c3b2c9b23beeeb224d263077299039@kernel.org> Content-Language: en-US Cc: kvm@vger.kernel.org, andre.przywara@arm.com, kvmarm@lists.cs.columbia.edu, will@kernel.org, gcherian@marvell.com, prime.zeng@hisilicon.com, catalin.marinas@arm.com, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMDQvMjIvMjAyMCAwMzowNyBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+IEhpIFN1enVraSwK PiAKPiBPbiAyMDIwLTA0LTIyIDE0OjQwLCBTdXp1a2kgSyBQb3Vsb3NlIHdyb3RlOgo+PiBIaSBN YXJjLAo+Pgo+PiBPbiAwNC8yMi8yMDIwIDAxOjAwIFBNLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+ PiBXaXRoIEFSTXY4LjUtR1RHLCB0aGUgaGFyZHdhcmUgKG9yIG1vcmUgbGlrZWx5IGEgaHlwZXJ2 aXNvcikgY2FuCj4+PiBhZHZlcnRpc2UgdGhlIHN1cHBvcnRlZCBTdGFnZS0yIHBhZ2Ugc2l6ZXMu Cj4+Pgo+Pj4gTGV0J3MgY2hlY2sgdGhpcyBhdCBib290IHRpbWUuCj4+Pgo+Pj4gU2lnbmVkLW9m Zi1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPj4+IC0tLQo+Pj4gwqAgYXJjaC9h cm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oIHzCoCAyICstCj4+PiDCoCBhcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL3N5c3JlZy5owqDCoCB8wqAgMyArKysKPj4+IMKgIGFyY2gvYXJtNjQva2VybmVs L2NwdWZlYXR1cmUuY8KgwqDCoCB8wqAgOCArKysrKysrCj4+PiDCoCBhcmNoL2FybTY0L2t2bS9y ZXNldC5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IDQwICsrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0KPj4+IMKgIHZpcnQva3ZtL2FybS9hcm0uY8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCB8wqAgNCArLS0tCj4+PiDCoCA1IGZpbGVzIGNoYW5nZWQsIDUwIGluc2VydGlvbnMo KyksIDcgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvaW5jbHVk ZS9hc20va3ZtX2hvc3QuaCAKPj4+IGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5o Cj4+PiBpbmRleCAzMmM4YTY3NWU1YTRhLi43ZGQ4ZmVmYTZhZWNkIDEwMDY0NAo+Pj4gLS0tIGEv YXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oCj4+PiArKysgYi9hcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL2t2bV9ob3N0LmgKPj4+IEBAIC02NzAsNyArNjcwLDcgQEAgc3RhdGljIGlubGlu ZSBpbnQga3ZtX2FybV9oYXZlX3NzYmQodm9pZCkKPj4+IMKgIHZvaWQga3ZtX3ZjcHVfbG9hZF9z eXNyZWdzKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSk7Cj4+PiDCoCB2b2lkIGt2bV92Y3B1X3B1dF9z eXNyZWdzKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSk7Cj4+PiDCoCAtdm9pZCBrdm1fc2V0X2lwYV9s aW1pdCh2b2lkKTsKPj4+ICtpbnQga3ZtX3NldF9pcGFfbGltaXQodm9pZCk7Cj4+PiDCoMKgwqAg I2RlZmluZSBfX0tWTV9IQVZFX0FSQ0hfVk1fQUxMT0MKPj4+IMKgIHN0cnVjdCBrdm0gKmt2bV9h cmNoX2FsbG9jX3ZtKHZvaWQpOwo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvaW5jbHVkZS9h c20vc3lzcmVnLmggCj4+PiBiL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vc3lzcmVnLmgKPj4+IGlu ZGV4IGViYzYyMjQzMjgzMTguLjVkMTBjOTE0OGU4NDQgMTAwNjQ0Cj4+PiAtLS0gYS9hcmNoL2Fy bTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oCj4+PiArKysgYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNt L3N5c3JlZy5oCj4+PiBAQCAtNjg2LDYgKzY4Niw5IEBACj4+PiDCoCAjZGVmaW5lIElEX0FBNjRa RlIwX1NWRVZFUl9TVkUywqDCoMKgwqDCoMKgwqAgMHgxCj4+PiDCoMKgwqAgLyogaWRfYWE2NG1t ZnIwICovCj4+PiArI2RlZmluZSBJRF9BQTY0TU1GUjBfVEdSQU40XzJfU0hJRlTCoMKgwqAgNDAK Pj4+ICsjZGVmaW5lIElEX0FBNjRNTUZSMF9UR1JBTjY0XzJfU0hJRlTCoMKgwqAgMzYKPj4+ICsj ZGVmaW5lIElEX0FBNjRNTUZSMF9UR1JBTjE2XzJfU0hJRlTCoMKgwqAgMzIKPj4+IMKgICNkZWZp bmUgSURfQUE2NE1NRlIwX1RHUkFONF9TSElGVMKgwqDCoCAyOAo+Pj4gwqAgI2RlZmluZSBJRF9B QTY0TU1GUjBfVEdSQU42NF9TSElGVMKgwqDCoCAyNAo+Pj4gwqAgI2RlZmluZSBJRF9BQTY0TU1G UjBfVEdSQU4xNl9TSElGVMKgwqDCoCAyMAo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva2Vy bmVsL2NwdWZlYXR1cmUuYyAKPj4+IGIvYXJjaC9hcm02NC9rZXJuZWwvY3B1ZmVhdHVyZS5jCj4+ PiBpbmRleCA5ZmFjNzQ1YWE3YmIyLi45ODkyYTg0NWQwNmM5IDEwMDY0NAo+Pj4gLS0tIGEvYXJj aC9hcm02NC9rZXJuZWwvY3B1ZmVhdHVyZS5jCj4+PiArKysgYi9hcmNoL2FybTY0L2tlcm5lbC9j cHVmZWF0dXJlLmMKPj4+IEBAIC0yMDgsNiArMjA4LDE0IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg YXJtNjRfZnRyX2JpdHMgCj4+PiBmdHJfaWRfYWE2NHpmcjBbXSA9IHsKPj4+IMKgIH07Cj4+PiDC oMKgwqAgc3RhdGljIGNvbnN0IHN0cnVjdCBhcm02NF9mdHJfYml0cyBmdHJfaWRfYWE2NG1tZnIw W10gPSB7Cj4+PiArwqDCoMKgIC8qCj4+PiArwqDCoMKgwqAgKiBQYWdlIHNpemUgbm90IGJlaW5n IHN1cHBvcnRlZCBhdCBTdGFnZS0yIGFyZSBub3QgZmF0YWwuIFlvdQo+Pj4gK8KgwqDCoMKgICog anVzdCBnaXZlIHVwIEtWTSBpZiBQQUdFX1NJWkUgaXNuJ3Qgc3VwcG9ydGVkIHRoZXJlLiBHbyBm aXgKPj4+ICvCoMKgwqDCoCAqIHlvdXIgZmF2b3VyaXRlIG5lc3RpbmcgaHlwZXJ2aXNvci4KPj4+ ICvCoMKgwqDCoCAqLwo+Pj4gK8KgwqDCoCBBUk02NF9GVFJfQklUUyhGVFJfSElEREVOLCBGVFJf Tk9OU1RSSUNULCBGVFJfRVhBQ1QsIAo+Pj4gSURfQUE2NE1NRlIwX1RHUkFONF8yX1NISUZULCA0 LCAxKSwKPj4+ICvCoMKgwqAgQVJNNjRfRlRSX0JJVFMoRlRSX0hJRERFTiwgRlRSX05PTlNUUklD VCwgRlRSX0VYQUNULCAKPj4+IElEX0FBNjRNTUZSMF9UR1JBTjY0XzJfU0hJRlQsIDQsIDEpLAo+ Pj4gK8KgwqDCoCBBUk02NF9GVFJfQklUUyhGVFJfSElEREVOLCBGVFJfTk9OU1RSSUNULCBGVFJf RVhBQ1QsIAo+Pj4gSURfQUE2NE1NRlIwX1RHUkFOMTZfMl9TSElGVCwgNCwgMSksCj4+Cj4+IE9u ZSBtaW5vciBpc3N1ZSB3aXRoIHRoaXMgaXMsIGlmIHdlIGdldCBhIHN5c3RlbSB3aXRoIGNwdXMg aGF2aW5nIHZhbHVlcwo+PiAwIGFuZCAyIChib3RoIG9mIHdoaWNoIGluZGljYXRlcyB0aGUgc3Rh Z2UtMiBzdXBwb3J0KSwgd2UgbWlnaHQgcmVzZXQKPj4gdGhlIHZhbHVlIHRvIDEgZm9yIHRoZSBm ZWF0dXJlIGluZGljYXRpbmcsIHdlIGRvbid0IHN1cHBvcnQgYW5kIGJsb2NrCj4+IEtWTS4gQnV0 LCB3ZSBjYW4gYmxhbWUgdGhlIG5lc3RpbmcgaHlwZXJ2aXNvciBmb3Igbm90IGVtdWxhdGluZyB0 aGlzIHRvCj4+ICgyKS4gRG8gd2UgbmVlZCBhIGNvbW1lbnQgdG8gbWFrZSB0aGlzIGV4cGxpY2l0 IGhlcmUgPwo+IAo+IFN1cmUuIEhvdyBhYm91dCBzb21ldGhpbmcgbGlrZToKPiAKPiAiVGhlcmUg aXMgYSBzbWFsbCBjb3JuZXIgY2FzZSB3aGVyZSB0aGUgaHlwZXJ2aXNvciBjb3VsZCBleHBsaWNp dGx5IAo+IGFkdmVydGlzZQo+ICDCoGEgZ2l2ZW4gZ3JhbnVsZSBzaXplIGF0IFN0YWdlLTIgKHZh bHVlIDIpIG9uIHNvbWUgdkNQVXMsIGFuZCB1c2UgdGhlIAo+IGZhbGxiYWNrCj4gIMKgdG8gU3Rh Z2UtMSAodmFsdWUgMCkgZm9yIG90aGVyIHZDUFVzLiBBbHRob3VnaCB0aGlzIGlzIG5vdCBmb3Ji aWRkZW4gCj4gYnkgdGhlCj4gIMKgYXJjaGl0ZWN0dXJlLCBpdCBpbmRpY2F0ZXMgdGhhdCB0aGUg aHlwZXJ2aXNvciBpcyBiZWluZyBzaWxseSAob3IgYnVnZ3kpLgo+ICDCoFdlIG1ha2Ugbm8gZWZm b3J0IHRvIGNvcGUgd2l0aCB0aGlzIGFuZCBwcmV0ZW5kIHRoYXQgaWYgdGhlc2UgZmllbGRzIGFy ZQo+ICDCoGluY29uc2lzdGVudCBhY3Jvc3MgdkNQVXMsIHRoZW4gaXQgaXNuJ3Qgd29ydGggdHJ5 aW5nIHRvIGJyaW5nIEtWTSB1cC4iCj4gCgpMb29rcyBmaW5lIHRvIG1lLgoKUmV2aWV3ZWQtYnk6 IFN1enVraSBLIFBvdWxvc2UgPHN1enVraS5wb3Vsb3NlQGFybS5jb20+Cl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWlsaW5nIGxpc3QKa3Zt YXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNvbHVtYmlhLmVkdS9t YWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABB39C54FCB for ; Wed, 22 Apr 2020 14:10:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 732C92082E for ; Wed, 22 Apr 2020 14:10:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uCjxd8Ax" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 732C92082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Hl0XJj24s8Bdnk/v5ZWd6jrRbJR5ds9mtUi0egzpIsc=; b=uCjxd8Ax6ANXBttzWCMfD0kgE fX1f4Wu5T3dZIbGW5NYfQAkDQil2No54+Rus9XXalrxCtahJP/GAxdJK/hx/QwhV+CpzdJ4huq9IY w2kt5qyVLVX+7KltEn/jjo8ngU+WfafnqLvdDJxTPD4Ve1mc7Vn/iCD5p22mAoZ8OWcKdb5N8f4l1 cw+PKdzyq4oJh0kzQigKFEoTXRnRWo4wpFqvrv356KFHPeRn7d8JPDgFJmIyUm1owSzLCq1uD07ok app28wbvEpIfDQo9EUrBVp0crynsvOXpkOIJJ7vGRsyz3BwApf/t/JjFA9yQfHEYg28MyXBLyzyff Gb2EW3Fjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRG4s-00074T-Os; Wed, 22 Apr 2020 14:10:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRG4p-00071A-Lw for linux-arm-kernel@lists.infradead.org; Wed, 22 Apr 2020 14:10:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D03EE30E; Wed, 22 Apr 2020 07:10:10 -0700 (PDT) Received: from [10.37.12.172] (unknown [10.37.12.172]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EE293F68F; Wed, 22 Apr 2020 07:10:07 -0700 (PDT) Subject: Re: [PATCH 01/26] KVM: arm64: Check advertised Stage-2 page size capability To: maz@kernel.org References: <20200422120050.3693593-1-maz@kernel.org> <20200422120050.3693593-2-maz@kernel.org> <32cc9a60-1b47-f3f7-d18d-d39db397ea55@arm.com> <06c3b2c9b23beeeb224d263077299039@kernel.org> From: Suzuki K Poulose Message-ID: Date: Wed, 22 Apr 2020 15:14:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <06c3b2c9b23beeeb224d263077299039@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200422_071011_808207_98372343 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, kvm@vger.kernel.org, jintack@cs.columbia.edu, andre.przywara@arm.com, christoffer.dall@arm.com, kvmarm@lists.cs.columbia.edu, will@kernel.org, gcherian@marvell.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, prime.zeng@hisilicon.com, catalin.marinas@arm.com, alexandru.elisei@arm.com, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDQvMjIvMjAyMCAwMzowNyBQTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+IEhpIFN1enVraSwK PiAKPiBPbiAyMDIwLTA0LTIyIDE0OjQwLCBTdXp1a2kgSyBQb3Vsb3NlIHdyb3RlOgo+PiBIaSBN YXJjLAo+Pgo+PiBPbiAwNC8yMi8yMDIwIDAxOjAwIFBNLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+ PiBXaXRoIEFSTXY4LjUtR1RHLCB0aGUgaGFyZHdhcmUgKG9yIG1vcmUgbGlrZWx5IGEgaHlwZXJ2 aXNvcikgY2FuCj4+PiBhZHZlcnRpc2UgdGhlIHN1cHBvcnRlZCBTdGFnZS0yIHBhZ2Ugc2l6ZXMu Cj4+Pgo+Pj4gTGV0J3MgY2hlY2sgdGhpcyBhdCBib290IHRpbWUuCj4+Pgo+Pj4gU2lnbmVkLW9m Zi1ieTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVsLm9yZz4KPj4+IC0tLQo+Pj4gwqAgYXJjaC9h cm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oIHzCoCAyICstCj4+PiDCoCBhcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL3N5c3JlZy5owqDCoCB8wqAgMyArKysKPj4+IMKgIGFyY2gvYXJtNjQva2VybmVs L2NwdWZlYXR1cmUuY8KgwqDCoCB8wqAgOCArKysrKysrCj4+PiDCoCBhcmNoL2FybTY0L2t2bS9y ZXNldC5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8IDQwICsrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0KPj4+IMKgIHZpcnQva3ZtL2FybS9hcm0uY8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCB8wqAgNCArLS0tCj4+PiDCoCA1IGZpbGVzIGNoYW5nZWQsIDUwIGluc2VydGlvbnMo KyksIDcgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvaW5jbHVk ZS9hc20va3ZtX2hvc3QuaCAKPj4+IGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5o Cj4+PiBpbmRleCAzMmM4YTY3NWU1YTRhLi43ZGQ4ZmVmYTZhZWNkIDEwMDY0NAo+Pj4gLS0tIGEv YXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oCj4+PiArKysgYi9hcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL2t2bV9ob3N0LmgKPj4+IEBAIC02NzAsNyArNjcwLDcgQEAgc3RhdGljIGlubGlu ZSBpbnQga3ZtX2FybV9oYXZlX3NzYmQodm9pZCkKPj4+IMKgIHZvaWQga3ZtX3ZjcHVfbG9hZF9z eXNyZWdzKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSk7Cj4+PiDCoCB2b2lkIGt2bV92Y3B1X3B1dF9z eXNyZWdzKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSk7Cj4+PiDCoCAtdm9pZCBrdm1fc2V0X2lwYV9s aW1pdCh2b2lkKTsKPj4+ICtpbnQga3ZtX3NldF9pcGFfbGltaXQodm9pZCk7Cj4+PiDCoMKgwqAg I2RlZmluZSBfX0tWTV9IQVZFX0FSQ0hfVk1fQUxMT0MKPj4+IMKgIHN0cnVjdCBrdm0gKmt2bV9h cmNoX2FsbG9jX3ZtKHZvaWQpOwo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvaW5jbHVkZS9h c20vc3lzcmVnLmggCj4+PiBiL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vc3lzcmVnLmgKPj4+IGlu ZGV4IGViYzYyMjQzMjgzMTguLjVkMTBjOTE0OGU4NDQgMTAwNjQ0Cj4+PiAtLS0gYS9hcmNoL2Fy bTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oCj4+PiArKysgYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNt L3N5c3JlZy5oCj4+PiBAQCAtNjg2LDYgKzY4Niw5IEBACj4+PiDCoCAjZGVmaW5lIElEX0FBNjRa RlIwX1NWRVZFUl9TVkUywqDCoMKgwqDCoMKgwqAgMHgxCj4+PiDCoMKgwqAgLyogaWRfYWE2NG1t ZnIwICovCj4+PiArI2RlZmluZSBJRF9BQTY0TU1GUjBfVEdSQU40XzJfU0hJRlTCoMKgwqAgNDAK Pj4+ICsjZGVmaW5lIElEX0FBNjRNTUZSMF9UR1JBTjY0XzJfU0hJRlTCoMKgwqAgMzYKPj4+ICsj ZGVmaW5lIElEX0FBNjRNTUZSMF9UR1JBTjE2XzJfU0hJRlTCoMKgwqAgMzIKPj4+IMKgICNkZWZp bmUgSURfQUE2NE1NRlIwX1RHUkFONF9TSElGVMKgwqDCoCAyOAo+Pj4gwqAgI2RlZmluZSBJRF9B QTY0TU1GUjBfVEdSQU42NF9TSElGVMKgwqDCoCAyNAo+Pj4gwqAgI2RlZmluZSBJRF9BQTY0TU1G UjBfVEdSQU4xNl9TSElGVMKgwqDCoCAyMAo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva2Vy bmVsL2NwdWZlYXR1cmUuYyAKPj4+IGIvYXJjaC9hcm02NC9rZXJuZWwvY3B1ZmVhdHVyZS5jCj4+ PiBpbmRleCA5ZmFjNzQ1YWE3YmIyLi45ODkyYTg0NWQwNmM5IDEwMDY0NAo+Pj4gLS0tIGEvYXJj aC9hcm02NC9rZXJuZWwvY3B1ZmVhdHVyZS5jCj4+PiArKysgYi9hcmNoL2FybTY0L2tlcm5lbC9j cHVmZWF0dXJlLmMKPj4+IEBAIC0yMDgsNiArMjA4LDE0IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qg YXJtNjRfZnRyX2JpdHMgCj4+PiBmdHJfaWRfYWE2NHpmcjBbXSA9IHsKPj4+IMKgIH07Cj4+PiDC oMKgwqAgc3RhdGljIGNvbnN0IHN0cnVjdCBhcm02NF9mdHJfYml0cyBmdHJfaWRfYWE2NG1tZnIw W10gPSB7Cj4+PiArwqDCoMKgIC8qCj4+PiArwqDCoMKgwqAgKiBQYWdlIHNpemUgbm90IGJlaW5n IHN1cHBvcnRlZCBhdCBTdGFnZS0yIGFyZSBub3QgZmF0YWwuIFlvdQo+Pj4gK8KgwqDCoMKgICog anVzdCBnaXZlIHVwIEtWTSBpZiBQQUdFX1NJWkUgaXNuJ3Qgc3VwcG9ydGVkIHRoZXJlLiBHbyBm aXgKPj4+ICvCoMKgwqDCoCAqIHlvdXIgZmF2b3VyaXRlIG5lc3RpbmcgaHlwZXJ2aXNvci4KPj4+ ICvCoMKgwqDCoCAqLwo+Pj4gK8KgwqDCoCBBUk02NF9GVFJfQklUUyhGVFJfSElEREVOLCBGVFJf Tk9OU1RSSUNULCBGVFJfRVhBQ1QsIAo+Pj4gSURfQUE2NE1NRlIwX1RHUkFONF8yX1NISUZULCA0 LCAxKSwKPj4+ICvCoMKgwqAgQVJNNjRfRlRSX0JJVFMoRlRSX0hJRERFTiwgRlRSX05PTlNUUklD VCwgRlRSX0VYQUNULCAKPj4+IElEX0FBNjRNTUZSMF9UR1JBTjY0XzJfU0hJRlQsIDQsIDEpLAo+ Pj4gK8KgwqDCoCBBUk02NF9GVFJfQklUUyhGVFJfSElEREVOLCBGVFJfTk9OU1RSSUNULCBGVFJf RVhBQ1QsIAo+Pj4gSURfQUE2NE1NRlIwX1RHUkFOMTZfMl9TSElGVCwgNCwgMSksCj4+Cj4+IE9u ZSBtaW5vciBpc3N1ZSB3aXRoIHRoaXMgaXMsIGlmIHdlIGdldCBhIHN5c3RlbSB3aXRoIGNwdXMg aGF2aW5nIHZhbHVlcwo+PiAwIGFuZCAyIChib3RoIG9mIHdoaWNoIGluZGljYXRlcyB0aGUgc3Rh Z2UtMiBzdXBwb3J0KSwgd2UgbWlnaHQgcmVzZXQKPj4gdGhlIHZhbHVlIHRvIDEgZm9yIHRoZSBm ZWF0dXJlIGluZGljYXRpbmcsIHdlIGRvbid0IHN1cHBvcnQgYW5kIGJsb2NrCj4+IEtWTS4gQnV0 LCB3ZSBjYW4gYmxhbWUgdGhlIG5lc3RpbmcgaHlwZXJ2aXNvciBmb3Igbm90IGVtdWxhdGluZyB0 aGlzIHRvCj4+ICgyKS4gRG8gd2UgbmVlZCBhIGNvbW1lbnQgdG8gbWFrZSB0aGlzIGV4cGxpY2l0 IGhlcmUgPwo+IAo+IFN1cmUuIEhvdyBhYm91dCBzb21ldGhpbmcgbGlrZToKPiAKPiAiVGhlcmUg aXMgYSBzbWFsbCBjb3JuZXIgY2FzZSB3aGVyZSB0aGUgaHlwZXJ2aXNvciBjb3VsZCBleHBsaWNp dGx5IAo+IGFkdmVydGlzZQo+ICDCoGEgZ2l2ZW4gZ3JhbnVsZSBzaXplIGF0IFN0YWdlLTIgKHZh bHVlIDIpIG9uIHNvbWUgdkNQVXMsIGFuZCB1c2UgdGhlIAo+IGZhbGxiYWNrCj4gIMKgdG8gU3Rh Z2UtMSAodmFsdWUgMCkgZm9yIG90aGVyIHZDUFVzLiBBbHRob3VnaCB0aGlzIGlzIG5vdCBmb3Ji aWRkZW4gCj4gYnkgdGhlCj4gIMKgYXJjaGl0ZWN0dXJlLCBpdCBpbmRpY2F0ZXMgdGhhdCB0aGUg aHlwZXJ2aXNvciBpcyBiZWluZyBzaWxseSAob3IgYnVnZ3kpLgo+ICDCoFdlIG1ha2Ugbm8gZWZm b3J0IHRvIGNvcGUgd2l0aCB0aGlzIGFuZCBwcmV0ZW5kIHRoYXQgaWYgdGhlc2UgZmllbGRzIGFy ZQo+ICDCoGluY29uc2lzdGVudCBhY3Jvc3MgdkNQVXMsIHRoZW4gaXQgaXNuJ3Qgd29ydGggdHJ5 aW5nIHRvIGJyaW5nIEtWTSB1cC4iCj4gCgpMb29rcyBmaW5lIHRvIG1lLgoKUmV2aWV3ZWQtYnk6 IFN1enVraSBLIFBvdWxvc2UgPHN1enVraS5wb3Vsb3NlQGFybS5jb20+CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==