All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/gen-cpuid: Distinguish default vs max in feature annotations
Date: Mon, 11 May 2020 09:43:21 +0200	[thread overview]
Message-ID: <e6380a05-d67a-b3a8-a624-ba5c161a8c53@suse.com> (raw)
In-Reply-To: <20200508152729.14295-1-andrew.cooper3@citrix.com>

On 08.05.2020 17:27, Andrew Cooper wrote:
> @@ -133,9 +134,13 @@ def crunch_numbers(state):
>      state.hvm_shadow_def = state.pv_def | state.raw['S']
>      state.hvm_hap_def = state.hvm_shadow_def | state.raw['H']
>  
> +    # TODO: Ignore def/max split until the toolstack migration logic is fixed
>      state.pv_max = state.pv_def
>      state.hvm_shadow_max = state.hvm_shadow_def
>      state.hvm_hap_max = state.hvm_hap_def
> +    # state.pv_max = state.raw['A'] | state.raw['a']
> +    # state.hvm_shadow_max = state.pv_max | state.raw['S'] | state.raw['s']
> +    # state.hvm_hap_max = state.hvm_shadow_max | state.raw['H'] | state.raw['h']

While in comment form it doesn't matter yet, for actually enabling
this it would seem to me to be more expressive as

    state.pv_max = state.pv_def | state.raw['a']
    state.hvm_shadow_max = state.hvm_shadow_def | state.pv_max | state.raw['s']
    state.hvm_hap_max = state.hvm_hap_def | state.hvm_shadow_max | state.raw['h']

Thoughts?

Jan


  reply	other threads:[~2020-05-11  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 15:27 [PATCH] x86/gen-cpuid: Distinguish default vs max in feature annotations Andrew Cooper
2020-05-11  7:43 ` Jan Beulich [this message]
2020-05-15 13:19   ` Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6380a05-d67a-b3a8-a624-ba5c161a8c53@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.