From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE592C433E6 for ; Tue, 22 Dec 2020 09:22:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB24422B2B for ; Tue, 22 Dec 2020 09:22:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB24422B2B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAEAB6E863; Tue, 22 Dec 2020 09:21:52 +0000 (UTC) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by gabe.freedesktop.org (Postfix) with ESMTPS id 722B26E19C for ; Tue, 22 Dec 2020 08:31:20 +0000 (UTC) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4D0V086qZGzhw8f; Tue, 22 Dec 2020 16:30:32 +0800 (CST) Received: from [127.0.0.1] (10.40.188.144) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 22 Dec 2020 16:31:07 +0800 Subject: Re: [PATCH] drm/hisilicon: Use pcim_enable_device() To: Daniel Vetter References: <1608511522-3100-1-git-send-email-tiantao6@hisilicon.com> From: "tiantao (H)" Message-ID: Date: Tue, 22 Dec 2020 16:31:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.40.188.144] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Tue, 22 Dec 2020 09:21:48 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , dri-devel , Xinliang Liu , Gerd Hoffmann , Thomas Zimmermann , Alex Deucher , Tian Tao , Thomas Gleixner Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" CuWcqCAyMDIwLzEyLzIyIDE2OjI3LCBEYW5pZWwgVmV0dGVyIOWGmemBkzoKPiBPbiBUdWUsIERl YyAyMiwgMjAyMCBhdCAxOjM4IEFNIHRpYW50YW8gKEgpIDx0aWFudGFvNkBodWF3ZWkuY29tPiB3 cm90ZToKPj4KPj4g5ZyoIDIwMjAvMTIvMjIgNjowMiwgRGFuaWVsIFZldHRlciDlhpnpgZM6Cj4+ PiBPbiBNb24sIERlYyAyMSwgMjAyMCBhdCAwODo0NToyMkFNICswODAwLCBUaWFuIFRhbyB3cm90 ZToKPj4+PiBVc2luZyB0aGUgbWFuYWdlZCBmdW5jdGlvbiBzaW1wbGlmaWVzIHRoZSBlcnJvciBo YW5kbGluZy4gQWZ0ZXIKPj4+PiB1bmxvYWRpbmcgdGhlIGRyaXZlciwgdGhlIFBDSSBkZXZpY2Ug c2hvdWxkIG5vdyBnZXQgZGlzYWJsZWQgYXMKPj4+PiB3ZWxsLgo+Pj4+Cj4+Pj4gU2lnbmVkLW9m Zi1ieTogVGlhbiBUYW8gPHRpYW50YW82QGhpc2lsaWNvbi5jb20+Cj4+Pj4gLS0tCj4+Pj4gICAg ZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9oaWJtY19kcm1fZHJ2LmMgfCA2ICsrLS0t LQo+Pj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p Cj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9o aWJtY19kcm1fZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2Ry bV9kcnYuYwo+Pj4+IGluZGV4IDAyZjNiZDEuLjcxNTkwMTggMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2hpc2lsaWNvbi9oaWJtYy9oaWJtY19kcm1fZHJ2LmMKPj4+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaGlzaWxpY29uL2hpYm1jL2hpYm1jX2RybV9kcnYuYwo+Pj4+IEBAIC0z MjksNyArMzI5LDcgQEAgc3RhdGljIGludCBoaWJtY19wY2lfcHJvYmUoc3RydWN0IHBjaV9kZXYg KnBkZXYsCj4+Pj4gICAgICAgZGV2LT5wZGV2ID0gcGRldjsKPj4+PiAgICAgICBwY2lfc2V0X2Ry dmRhdGEocGRldiwgZGV2KTsKPj4+Pgo+Pj4+IC0gICAgcmV0ID0gcGNpX2VuYWJsZV9kZXZpY2Uo cGRldik7Cj4+Pj4gKyAgICByZXQgPSBwY2ltX2VuYWJsZV9kZXZpY2UocGRldik7Cj4+Pj4gICAg ICAgaWYgKHJldCkgewo+Pj4+ICAgICAgICAgICAgICAgZHJtX2VycihkZXYsICJmYWlsZWQgdG8g ZW5hYmxlIHBjaSBkZXZpY2U6ICVkXG4iLCByZXQpOwo+Pj4+ICAgICAgICAgICAgICAgZ290byBl cnJfZnJlZTsKPj4+PiBAQCAtMzM4LDcgKzMzOCw3IEBAIHN0YXRpYyBpbnQgaGlibWNfcGNpX3By b2JlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LAo+Pj4+ICAgICAgIHJldCA9IGhpYm1jX2xvYWQoZGV2 KTsKPj4+PiAgICAgICBpZiAocmV0KSB7Cj4+Pj4gICAgICAgICAgICAgICBkcm1fZXJyKGRldiwg ImZhaWxlZCB0byBsb2FkIGhpYm1jOiAlZFxuIiwgcmV0KTsKPj4+PiAtICAgICAgICAgICAgZ290 byBlcnJfZGlzYWJsZTsKPj4+PiArICAgICAgICAgICAgZ290byBlcnJfZnJlZTsKPj4+PiAgICAg ICB9Cj4+Pj4KPj4+PiAgICAgICByZXQgPSBkcm1fZGV2X3JlZ2lzdGVyKGRldiwgMCk7Cj4+Pj4g QEAgLTM1NCw4ICszNTQsNiBAQCBzdGF0aWMgaW50IGhpYm1jX3BjaV9wcm9iZShzdHJ1Y3QgcGNp X2RldiAqcGRldiwKPj4+Pgo+Pj4+ICAgIGVycl91bmxvYWQ6Cj4+Pj4gICAgICAgaGlibWNfdW5s b2FkKGRldik7Cj4+Pj4gLWVycl9kaXNhYmxlOgo+Pj4+IC0gICAgcGNpX2Rpc2FibGVfZGV2aWNl KHBkZXYpOwo+Pj4+ICAgIGVycl9mcmVlOgo+Pj4+ICAgICAgIGRybV9kZXZfcHV0KGRldik7Cj4+ PiBUaGUgZHJtX2Rldl9wdXQgaGVyZSBhbmQgaW4gaGlibWNfcGNpX3JlbW92ZSBpcyB3cm9uZywg ZGV2bV9kcm1fZGV2X2FsbG9jCj4+PiB0YWtlcyBjYXJlIG9mIHRoYXQgYWxyZWFkeS4gSSdtIGtp bmRhIHN1cHJpc2VkIHlvdSBkb24ndCBoYXZlIGEgcmVmY291bnQKPj4+IHVuZGVycnVuIGFscmVh ZHkgLSBkbyB5b3UgdGVzdCBtb2R1bGUgdW5sb2FkIHdpdGggS0FTQU4gZW5hYmxlZD8KPj4gVGhh bmtzIGZvciBoZWxwaW5nIHRvIHJldmlldyB0aGUgY29kZe+8jGFuZCBraW5kbHkgZ2l2aW5nIG1l IGFkdmljZeOAggo+Pgo+PiB0aGlzIHByb2JsZW0gaGF2ZSBiZWVuIGZpeGVk44CCCj4+Cj4+IGM4 NTVhZjJmOWM1YzYwNzYwZmQxYmVkNzg4OWE4MWJjMzdkMjU5MWQgZHJtL2hpc2lsaWNvbjogRml4 IHVzZS1hZnRlci1mcmVlCj4gU29ycnksIEkgd2FzIG9uIGFuIG9sZGVyIHRyZWUuIE5vdGUgdGhh dCB0aGlzIGZpeCBpcyBpbmNvbXBsZXRlLCB0aGUKPiBkcm1fZGV2X3B1dCBpbiB0aGUgZXJyb3Ig cGF0aCBvZiBoaWJtY19wY2lfcHJvYmUgc3RpbGwgZXhpc3RzLgo+IC1EYW5pZWwKSSBhbHNvIGZv dW5kIHRoZSBwcm9ibGVtLCBoYXMgcmFpc2VkIHRoZSBwYXRjaCBpbiB0aGUgaW50ZXJuYWwgcmV2 aWV3IAphbmQgdGVzdGluZywgdG8gY29uZmlybSB0aGF0IHRoZXJlIGlzIG5vIHByb2JsZW0sIGl0 IHdpbGwgYmUgc2VudCBvdXQuClRoYW5rcyBmb3IgdGhlIHJlbWluZGVyLgo+Pj4gVGhlIHBjaW0g cGF0Y2ggbG9va3Mgb2ssIHNvIFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0 dGVyQGZmd2xsLmNoPgo+Pj4KPj4+IENoZWVycywgRGFuaWVsCj4+Pgo+Pj4+IC0tCj4+Pj4gMi43 LjQKPj4+Pgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK