From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 905F5C433FF for ; Thu, 8 Aug 2019 03:46:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6162520880 for ; Thu, 8 Aug 2019 03:46:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="caNdsK+H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387536AbfHHDqy (ORCPT ); Wed, 7 Aug 2019 23:46:54 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14417 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728167AbfHHDqy (ORCPT ); Wed, 7 Aug 2019 23:46:54 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 07 Aug 2019 20:46:53 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 07 Aug 2019 20:46:51 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 07 Aug 2019 20:46:51 -0700 Received: from ngvpn01-164-84.dyn.scz.us.nvidia.com (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 8 Aug 2019 03:46:50 +0000 Subject: Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites To: Ira Weiny , Michal Hocko CC: Jan Kara , Matthew Wilcox , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Dave Hansen , Jason Gunthorpe , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , LKML , , , , , , , , , , , , , , , , , , , , , , , References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802091244.GD6461@dhcp22.suse.cz> <20190802124146.GL25064@quack2.suse.cz> <20190802142443.GB5597@bombadil.infradead.org> <20190802145227.GQ25064@quack2.suse.cz> <076e7826-67a5-4829-aae2-2b90f302cebd@nvidia.com> <20190807083726.GA14658@quack2.suse.cz> <20190807084649.GQ11812@dhcp22.suse.cz> <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: Date: Wed, 7 Aug 2019 20:46:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1565236013; bh=oa/UlzMF1BY8hfwSUK2E34E4BK86wv0rI2GL87o8kWQ=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=caNdsK+H718e8IaMHboxAo7N5kSDjdO0aPPP7qMD/uXC6LIuseTU5yocCYztoyhLS A8theOeNn9DFbaKSyltNZVy/0B3VPZPEr/7HwHnfipqBI1W9E/1RXgk4cYboMCcd2v K1AubOjDxM7RJmlTd1q1ZO/DARZkbUQqfdDa7AtzCGn8CgjUMfboXlhtit5supcfVJ t3SF5BlWoOZ+ktHQ+Gy0QbysjhXaepl4K0zI9Pv3YsYauPp0cOOqMsTfKIdJYZp847 qDjXLEk745BEl9a58mwF6yYg4Z7StCZBL718mfzBDBCPCwNZsIoTbJbWCkazTDd50+ NvHzitKycTv2g== Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 8/7/19 7:36 PM, Ira Weiny wrote: > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: >> On Wed 07-08-19 10:37:26, Jan Kara wrote: >>> On Fri 02-08-19 12:14:09, John Hubbard wrote: >>>> On 8/2/19 7:52 AM, Jan Kara wrote: >>>>> On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: >>>>>> On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: >>>>>>> On Fri 02-08-19 11:12:44, Michal Hocko wrote: >>>>>>>> On Thu 01-08-19 19:19:31, john.hubbard@gmail.com wrote: [...] > Before I go on, I would like to say that the "imbalance" of get_user_pages() > and put_page() bothers me from a purist standpoint... However, since this > discussion cropped up I went ahead and ported my work to Linus' current master > (5.3-rc3+) and in doing so I only had to steal a bit of Johns code... Sorry > John... :-( > > I don't have the commit messages all cleaned up and I know there may be some > discussion on these new interfaces but I wanted to throw this series out there > because I think it may be what Jan and Michal are driving at (or at least in > that direction. > > Right now only RDMA and DAX FS's are supported. Other users of GUP will still > fail on a DAX file and regular files will still be at risk.[2] > > I've pushed this work (based 5.3-rc3+ (33920f1ec5bf)) here[3]: > > https://github.com/weiny2/linux-kernel/tree/linus-rdmafsdax-b0-v3 > > I think the most relevant patch to this conversation is: > > https://github.com/weiny2/linux-kernel/commit/5d377653ba5cf11c3b716f904b057bee6641aaf6 > ohhh...can you please avoid using the old __put_user_pages_dirty() function? I thought I'd caught things early enough to get away with the rename and deletion of that. You could either: a) open code an implementation of vaddr_put_pages_dirty_lock() that doesn't call any of the *put_user_pages_dirty*() variants, or b) include my first patch ("") are part of your series, or c) base this on Andrews's tree, which already has merged in my first patch. thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Date: Thu, 08 Aug 2019 03:46:50 +0000 Subject: Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites Message-Id: List-Id: References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802091244.GD6461@dhcp22.suse.cz> <20190802124146.GL25064@quack2.suse.cz> <20190802142443.GB5597@bombadil.infradead.org> <20190802145227.GQ25064@quack2.suse.cz> <076e7826-67a5-4829-aae2-2b90f302cebd@nvidia.com> <20190807083726.GA14658@quack2.suse.cz> <20190807084649.GQ11812@dhcp22.suse.cz> <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> In-Reply-To: <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ira Weiny , Michal Hocko Cc: Jan Kara , Matthew Wilcox , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Dave Hansen , Jason Gunthorpe , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , LKML , amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org, devel@lists.orangefs.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org On 8/7/19 7:36 PM, Ira Weiny wrote: > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: >> On Wed 07-08-19 10:37:26, Jan Kara wrote: >>> On Fri 02-08-19 12:14:09, John Hubbard wrote: >>>> On 8/2/19 7:52 AM, Jan Kara wrote: >>>>> On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: >>>>>> On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: >>>>>>> On Fri 02-08-19 11:12:44, Michal Hocko wrote: >>>>>>>> On Thu 01-08-19 19:19:31, john.hubbard@gmail.com wrote: [...] > Before I go on, I would like to say that the "imbalance" of get_user_pages() > and put_page() bothers me from a purist standpoint... However, since this > discussion cropped up I went ahead and ported my work to Linus' current master > (5.3-rc3+) and in doing so I only had to steal a bit of Johns code... Sorry > John... :-( > > I don't have the commit messages all cleaned up and I know there may be some > discussion on these new interfaces but I wanted to throw this series out there > because I think it may be what Jan and Michal are driving at (or at least in > that direction. > > Right now only RDMA and DAX FS's are supported. Other users of GUP will still > fail on a DAX file and regular files will still be at risk.[2] > > I've pushed this work (based 5.3-rc3+ (33920f1ec5bf)) here[3]: > > https://github.com/weiny2/linux-kernel/tree/linus-rdmafsdax-b0-v3 > > I think the most relevant patch to this conversation is: > > https://github.com/weiny2/linux-kernel/commit/5d377653ba5cf11c3b716f904b057bee6641aaf6 > ohhh...can you please avoid using the old __put_user_pages_dirty() function? I thought I'd caught things early enough to get away with the rename and deletion of that. You could either: a) open code an implementation of vaddr_put_pages_dirty_lock() that doesn't call any of the *put_user_pages_dirty*() variants, or b) include my first patch ("") are part of your series, or c) base this on Andrews's tree, which already has merged in my first patch. thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Hubbard Subject: Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites Date: Wed, 7 Aug 2019 20:46:50 -0700 Message-ID: References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802091244.GD6461@dhcp22.suse.cz> <20190802124146.GL25064@quack2.suse.cz> <20190802142443.GB5597@bombadil.infradead.org> <20190802145227.GQ25064@quack2.suse.cz> <076e7826-67a5-4829-aae2-2b90f302cebd@nvidia.com> <20190807083726.GA14658@quack2.suse.cz> <20190807084649.GQ11812@dhcp22.suse.cz> <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Ira Weiny , Michal Hocko Cc: Jan Kara , Matthew Wilcox , Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Dave Hansen , Jason Gunthorpe , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , LKML , amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org, devel@lists.orangefs.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org List-Id: ceph-devel.vger.kernel.org On 8/7/19 7:36 PM, Ira Weiny wrote: > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: >> On Wed 07-08-19 10:37:26, Jan Kara wrote: >>> On Fri 02-08-19 12:14:09, John Hubbard wrote: >>>> On 8/2/19 7:52 AM, Jan Kara wrote: >>>>> On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: >>>>>> On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: >>>>>>> On Fri 02-08-19 11:12:44, Michal Hocko wrote: >>>>>>>> On Thu 01-08-19 19:19:31, john.hubbard@gmail.com wrote: [...] > Before I go on, I would like to say that the "imbalance" of get_user_pages() > and put_page() bothers me from a purist standpoint... However, since this > discussion cropped up I went ahead and ported my work to Linus' current master > (5.3-rc3+) and in doing so I only had to steal a bit of Johns code... Sorry > John... :-( > > I don't have the commit messages all cleaned up and I know there may be some > discussion on these new interfaces but I wanted to throw this series out there > because I think it may be what Jan and Michal are driving at (or at least in > that direction. > > Right now only RDMA and DAX FS's are supported. Other users of GUP will still > fail on a DAX file and regular files will still be at risk.[2] > > I've pushed this work (based 5.3-rc3+ (33920f1ec5bf)) here[3]: > > https://github.com/weiny2/linux-kernel/tree/linus-rdmafsdax-b0-v3 > > I think the most relevant patch to this conversation is: > > https://github.com/weiny2/linux-kernel/commit/5d377653ba5cf11c3b716f904b057bee6641aaf6 > ohhh...can you please avoid using the old __put_user_pages_dirty() function? I thought I'd caught things early enough to get away with the rename and deletion of that. You could either: a) open code an implementation of vaddr_put_pages_dirty_lock() that doesn't call any of the *put_user_pages_dirty*() variants, or b) include my first patch ("") are part of your series, or c) base this on Andrews's tree, which already has merged in my first patch. thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 From: jhubbard@nvidia.com (John Hubbard) Date: Wed, 7 Aug 2019 20:46:50 -0700 Subject: [PATCH 00/34] put_user_pages(): miscellaneous call sites In-Reply-To: <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802091244.GD6461@dhcp22.suse.cz> <20190802124146.GL25064@quack2.suse.cz> <20190802142443.GB5597@bombadil.infradead.org> <20190802145227.GQ25064@quack2.suse.cz> <076e7826-67a5-4829-aae2-2b90f302cebd@nvidia.com> <20190807083726.GA14658@quack2.suse.cz> <20190807084649.GQ11812@dhcp22.suse.cz> <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> Message-ID: List-Id: Linux Driver Project Developer List On 8/7/19 7:36 PM, Ira Weiny wrote: > On Wed, Aug 07, 2019@10:46:49AM +0200, Michal Hocko wrote: >> On Wed 07-08-19 10:37:26, Jan Kara wrote: >>> On Fri 02-08-19 12:14:09, John Hubbard wrote: >>>> On 8/2/19 7:52 AM, Jan Kara wrote: >>>>> On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: >>>>>> On Fri, Aug 02, 2019@02:41:46PM +0200, Jan Kara wrote: >>>>>>> On Fri 02-08-19 11:12:44, Michal Hocko wrote: >>>>>>>> On Thu 01-08-19 19:19:31, john.hubbard@gmail.com wrote: [...] > Before I go on, I would like to say that the "imbalance" of get_user_pages() > and put_page() bothers me from a purist standpoint... However, since this > discussion cropped up I went ahead and ported my work to Linus' current master > (5.3-rc3+) and in doing so I only had to steal a bit of Johns code... Sorry > John... :-( > > I don't have the commit messages all cleaned up and I know there may be some > discussion on these new interfaces but I wanted to throw this series out there > because I think it may be what Jan and Michal are driving at (or at least in > that direction. > > Right now only RDMA and DAX FS's are supported. Other users of GUP will still > fail on a DAX file and regular files will still be at risk.[2] > > I've pushed this work (based 5.3-rc3+ (33920f1ec5bf)) here[3]: > > https://github.com/weiny2/linux-kernel/tree/linus-rdmafsdax-b0-v3 > > I think the most relevant patch to this conversation is: > > https://github.com/weiny2/linux-kernel/commit/5d377653ba5cf11c3b716f904b057bee6641aaf6 > ohhh...can you please avoid using the old __put_user_pages_dirty() function? I thought I'd caught things early enough to get away with the rename and deletion of that. You could either: a) open code an implementation of vaddr_put_pages_dirty_lock() that doesn't call any of the *put_user_pages_dirty*() variants, or b) include my first patch ("") are part of your series, or c) base this on Andrews's tree, which already has merged in my first patch. thanks, -- John Hubbard NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A16FCC41514 for ; Thu, 8 Aug 2019 03:47:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76E2420B7C for ; Thu, 8 Aug 2019 03:47:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jmMmLPIB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="caNdsK+H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76E2420B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/KwH9UlM/ZwYIFfvctCVpUtisfRkS/HQd0fQL9eLyFE=; b=jmMmLPIBX4C0U0JQT1JeFHEca khituqZmushOx0zPCWW9VkHSTLubwFdrbsx6HkfIDldnN5MTfxVWgL2f1k/IOH7QaTJze6w6kegaW aZJi4lWbhZscTEiCMoBTKW8/FblCaQCWCGdFTVOLbKYhs/iCe3w81Wngk5q9LTCldApLJDxu7KXes 4M7VrdYBXypom9C7bOk5nM3MPI8XJ6AGChKHAPvoDBFu9whnPLea3xU6nmq5RWwmDTNBF71M+Vw5z FT5tRA6y8hRMYsKFOvOeZHS5oVrDQcWhfvEpb+p3zQjU5GCbvKG0RcZkWOLwwC5dXJZKwVIj/b6Ch HcaH9360A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvZOD-0002ok-C8; Thu, 08 Aug 2019 03:46:57 +0000 Received: from hqemgate16.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvZO8-0002oL-WA; Thu, 08 Aug 2019 03:46:54 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 07 Aug 2019 20:46:53 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 07 Aug 2019 20:46:51 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 07 Aug 2019 20:46:51 -0700 Received: from ngvpn01-164-84.dyn.scz.us.nvidia.com (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 8 Aug 2019 03:46:50 +0000 Subject: Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites To: Ira Weiny , Michal Hocko References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802091244.GD6461@dhcp22.suse.cz> <20190802124146.GL25064@quack2.suse.cz> <20190802142443.GB5597@bombadil.infradead.org> <20190802145227.GQ25064@quack2.suse.cz> <076e7826-67a5-4829-aae2-2b90f302cebd@nvidia.com> <20190807083726.GA14658@quack2.suse.cz> <20190807084649.GQ11812@dhcp22.suse.cz> <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: Date: Wed, 7 Aug 2019 20:46:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1565236013; bh=oa/UlzMF1BY8hfwSUK2E34E4BK86wv0rI2GL87o8kWQ=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=caNdsK+H718e8IaMHboxAo7N5kSDjdO0aPPP7qMD/uXC6LIuseTU5yocCYztoyhLS A8theOeNn9DFbaKSyltNZVy/0B3VPZPEr/7HwHnfipqBI1W9E/1RXgk4cYboMCcd2v K1AubOjDxM7RJmlTd1q1ZO/DARZkbUQqfdDa7AtzCGn8CgjUMfboXlhtit5supcfVJ t3SF5BlWoOZ+ktHQ+Gy0QbysjhXaepl4K0zI9Pv3YsYauPp0cOOqMsTfKIdJYZp847 qDjXLEk745BEl9a58mwF6yYg4Z7StCZBL718mfzBDBCPCwNZsIoTbJbWCkazTDd50+ NvHzitKycTv2g== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_204653_048810_A036796B X-CRM114-Status: GOOD ( 17.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jan Kara , kvm@vger.kernel.org, Dave Hansen , Dave Chinner , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, amd-gfx@lists.freedesktop.org, sparclinux@vger.kernel.org, Dan Williams , devel@driverdev.osuosl.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, x86@kernel.org, Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , xen-devel@lists.xenproject.org, devel@lists.orangefs.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, LKML , linux-xfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/7/19 7:36 PM, Ira Weiny wrote: > On Wed, Aug 07, 2019 at 10:46:49AM +0200, Michal Hocko wrote: >> On Wed 07-08-19 10:37:26, Jan Kara wrote: >>> On Fri 02-08-19 12:14:09, John Hubbard wrote: >>>> On 8/2/19 7:52 AM, Jan Kara wrote: >>>>> On Fri 02-08-19 07:24:43, Matthew Wilcox wrote: >>>>>> On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote: >>>>>>> On Fri 02-08-19 11:12:44, Michal Hocko wrote: >>>>>>>> On Thu 01-08-19 19:19:31, john.hubbard@gmail.com wrote: [...] > Before I go on, I would like to say that the "imbalance" of get_user_pages() > and put_page() bothers me from a purist standpoint... However, since this > discussion cropped up I went ahead and ported my work to Linus' current master > (5.3-rc3+) and in doing so I only had to steal a bit of Johns code... Sorry > John... :-( > > I don't have the commit messages all cleaned up and I know there may be some > discussion on these new interfaces but I wanted to throw this series out there > because I think it may be what Jan and Michal are driving at (or at least in > that direction. > > Right now only RDMA and DAX FS's are supported. Other users of GUP will still > fail on a DAX file and regular files will still be at risk.[2] > > I've pushed this work (based 5.3-rc3+ (33920f1ec5bf)) here[3]: > > https://github.com/weiny2/linux-kernel/tree/linus-rdmafsdax-b0-v3 > > I think the most relevant patch to this conversation is: > > https://github.com/weiny2/linux-kernel/commit/5d377653ba5cf11c3b716f904b057bee6641aaf6 > ohhh...can you please avoid using the old __put_user_pages_dirty() function? I thought I'd caught things early enough to get away with the rename and deletion of that. You could either: a) open code an implementation of vaddr_put_pages_dirty_lock() that doesn't call any of the *put_user_pages_dirty*() variants, or b) include my first patch ("") are part of your series, or c) base this on Andrews's tree, which already has merged in my first patch. thanks, -- John Hubbard NVIDIA _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E569C433FF for ; Thu, 8 Aug 2019 03:47:12 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E624B20880 for ; Thu, 8 Aug 2019 03:47:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="caNdsK+H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E624B20880 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hvZOC-00039X-8b; Thu, 08 Aug 2019 03:46:56 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hvZOA-00039R-Tq for xen-devel@lists.xenproject.org; Thu, 08 Aug 2019 03:46:54 +0000 X-Inumbo-ID: 292ae953-b98f-11e9-8980-bc764e045a96 Received: from hqemgate16.nvidia.com (unknown [216.228.121.65]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 292ae953-b98f-11e9-8980-bc764e045a96; Thu, 08 Aug 2019 03:46:53 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 07 Aug 2019 20:46:53 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 07 Aug 2019 20:46:51 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 07 Aug 2019 20:46:51 -0700 Received: from ngvpn01-164-84.dyn.scz.us.nvidia.com (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 8 Aug 2019 03:46:50 +0000 To: Ira Weiny , Michal Hocko References: <20190802022005.5117-1-jhubbard@nvidia.com> <20190802091244.GD6461@dhcp22.suse.cz> <20190802124146.GL25064@quack2.suse.cz> <20190802142443.GB5597@bombadil.infradead.org> <20190802145227.GQ25064@quack2.suse.cz> <076e7826-67a5-4829-aae2-2b90f302cebd@nvidia.com> <20190807083726.GA14658@quack2.suse.cz> <20190807084649.GQ11812@dhcp22.suse.cz> <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: Date: Wed, 7 Aug 2019 20:46:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190808023637.GA1508@iweiny-DESK2.sc.intel.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1565236013; bh=oa/UlzMF1BY8hfwSUK2E34E4BK86wv0rI2GL87o8kWQ=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=caNdsK+H718e8IaMHboxAo7N5kSDjdO0aPPP7qMD/uXC6LIuseTU5yocCYztoyhLS A8theOeNn9DFbaKSyltNZVy/0B3VPZPEr/7HwHnfipqBI1W9E/1RXgk4cYboMCcd2v K1AubOjDxM7RJmlTd1q1ZO/DARZkbUQqfdDa7AtzCGn8CgjUMfboXlhtit5supcfVJ t3SF5BlWoOZ+ktHQ+Gy0QbysjhXaepl4K0zI9Pv3YsYauPp0cOOqMsTfKIdJYZp847 qDjXLEk745BEl9a58mwF6yYg4Z7StCZBL718mfzBDBCPCwNZsIoTbJbWCkazTDd50+ NvHzitKycTv2g== Subject: Re: [Xen-devel] [PATCH 00/34] put_user_pages(): miscellaneous call sites X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jan Kara , kvm@vger.kernel.org, Dave Hansen , Dave Chinner , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, amd-gfx@lists.freedesktop.org, sparclinux@vger.kernel.org, Dan Williams , devel@driverdev.osuosl.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, x86@kernel.org, Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , xen-devel@lists.xenproject.org, devel@lists.orangefs.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-block@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, LKML , linux-xfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gOC83LzE5IDc6MzYgUE0sIElyYSBXZWlueSB3cm90ZToKPiBPbiBXZWQsIEF1ZyAwNywgMjAx OSBhdCAxMDo0Njo0OUFNICswMjAwLCBNaWNoYWwgSG9ja28gd3JvdGU6Cj4+IE9uIFdlZCAwNy0w OC0xOSAxMDozNzoyNiwgSmFuIEthcmEgd3JvdGU6Cj4+PiBPbiBGcmkgMDItMDgtMTkgMTI6MTQ6 MDksIEpvaG4gSHViYmFyZCB3cm90ZToKPj4+PiBPbiA4LzIvMTkgNzo1MiBBTSwgSmFuIEthcmEg d3JvdGU6Cj4+Pj4+IE9uIEZyaSAwMi0wOC0xOSAwNzoyNDo0MywgTWF0dGhldyBXaWxjb3ggd3Jv dGU6Cj4+Pj4+PiBPbiBGcmksIEF1ZyAwMiwgMjAxOSBhdCAwMjo0MTo0NlBNICswMjAwLCBKYW4g S2FyYSB3cm90ZToKPj4+Pj4+PiBPbiBGcmkgMDItMDgtMTkgMTE6MTI6NDQsIE1pY2hhbCBIb2Nr byB3cm90ZToKPj4+Pj4+Pj4gT24gVGh1IDAxLTA4LTE5IDE5OjE5OjMxLCBqb2huLmh1YmJhcmRA Z21haWwuY29tIHdyb3RlOgogIFsuLi5dCj4gQmVmb3JlIEkgZ28gb24sIEkgd291bGQgbGlrZSB0 byBzYXkgdGhhdCB0aGUgImltYmFsYW5jZSIgb2YgZ2V0X3VzZXJfcGFnZXMoKQo+IGFuZCBwdXRf cGFnZSgpIGJvdGhlcnMgbWUgZnJvbSBhIHB1cmlzdCBzdGFuZHBvaW50Li4uICBIb3dldmVyLCBz aW5jZSB0aGlzCj4gZGlzY3Vzc2lvbiBjcm9wcGVkIHVwIEkgd2VudCBhaGVhZCBhbmQgcG9ydGVk IG15IHdvcmsgdG8gTGludXMnIGN1cnJlbnQgbWFzdGVyCj4gKDUuMy1yYzMrKSBhbmQgaW4gZG9p bmcgc28gSSBvbmx5IGhhZCB0byBzdGVhbCBhIGJpdCBvZiBKb2hucyBjb2RlLi4uICBTb3JyeQo+ IEpvaG4uLi4gIDotKAo+IAo+IEkgZG9uJ3QgaGF2ZSB0aGUgY29tbWl0IG1lc3NhZ2VzIGFsbCBj bGVhbmVkIHVwIGFuZCBJIGtub3cgdGhlcmUgbWF5IGJlIHNvbWUKPiBkaXNjdXNzaW9uIG9uIHRo ZXNlIG5ldyBpbnRlcmZhY2VzIGJ1dCBJIHdhbnRlZCB0byB0aHJvdyB0aGlzIHNlcmllcyBvdXQg dGhlcmUKPiBiZWNhdXNlIEkgdGhpbmsgaXQgbWF5IGJlIHdoYXQgSmFuIGFuZCBNaWNoYWwgYXJl IGRyaXZpbmcgYXQgKG9yIGF0IGxlYXN0IGluCj4gdGhhdCBkaXJlY3Rpb24uCj4gCj4gUmlnaHQg bm93IG9ubHkgUkRNQSBhbmQgREFYIEZTJ3MgYXJlIHN1cHBvcnRlZC4gIE90aGVyIHVzZXJzIG9m IEdVUCB3aWxsIHN0aWxsCj4gZmFpbCBvbiBhIERBWCBmaWxlIGFuZCByZWd1bGFyIGZpbGVzIHdp bGwgc3RpbGwgYmUgYXQgcmlzay5bMl0KPiAKPiBJJ3ZlIHB1c2hlZCB0aGlzIHdvcmsgKGJhc2Vk IDUuMy1yYzMrICgzMzkyMGYxZWM1YmYpKSBoZXJlWzNdOgo+IAo+IGh0dHBzOi8vZ2l0aHViLmNv bS93ZWlueTIvbGludXgta2VybmVsL3RyZWUvbGludXMtcmRtYWZzZGF4LWIwLXYzCj4gCj4gSSB0 aGluayB0aGUgbW9zdCByZWxldmFudCBwYXRjaCB0byB0aGlzIGNvbnZlcnNhdGlvbiBpczoKPiAK PiBodHRwczovL2dpdGh1Yi5jb20vd2VpbnkyL2xpbnV4LWtlcm5lbC9jb21taXQvNWQzNzc2NTNi YTVjZjExYzNiNzE2ZjkwNGIwNTdiZWU2NjQxYWFmNgo+IAoKb2hoaC4uLmNhbiB5b3UgcGxlYXNl IGF2b2lkIHVzaW5nIHRoZSBvbGQgX19wdXRfdXNlcl9wYWdlc19kaXJ0eSgpCmZ1bmN0aW9uPyBJ IHRob3VnaHQgSSdkIGNhdWdodCB0aGluZ3MgZWFybHkgZW5vdWdoIHRvIGdldCBhd2F5IHdpdGgK dGhlIHJlbmFtZSBhbmQgZGVsZXRpb24gb2YgdGhhdC4gWW91IGNvdWxkIGVpdGhlcjoKCmEpIG9w ZW4gY29kZSBhbiBpbXBsZW1lbnRhdGlvbiBvZiB2YWRkcl9wdXRfcGFnZXNfZGlydHlfbG9jaygp IHRoYXQKZG9lc24ndCBjYWxsIGFueSBvZiB0aGUgKnB1dF91c2VyX3BhZ2VzX2RpcnR5KigpIHZh cmlhbnRzLCBvcgoKYikgaW5jbHVkZSBteSBmaXJzdCBwYXRjaCAoIiIpIGFyZSBwYXJ0IG9mIHlv dXIgc2VyaWVzLCBvcgoKYykgYmFzZSB0aGlzIG9uIEFuZHJld3MncyB0cmVlLCB3aGljaCBhbHJl YWR5IGhhcyBtZXJnZWQgaW4gbXkgZmlyc3QgcGF0Y2guCgoKdGhhbmtzLAotLSAKSm9obiBIdWJi YXJkCk5WSURJQQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcK aHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==