From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D421C47082 for ; Wed, 26 May 2021 13:37:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9CF7613BA for ; Wed, 26 May 2021 13:37:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9CF7613BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=posteo.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 86EB182EBA; Wed, 26 May 2021 15:37:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=posteo.net header.i=@posteo.net header.b="OC99vT32"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C28DE82E3C; Wed, 26 May 2021 15:37:18 +0200 (CEST) Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3F08082E3C for ; Wed, 26 May 2021 15:37:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=richard.genoud@posteo.net Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id DDCF9240026 for ; Wed, 26 May 2021 15:37:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1622036235; bh=w8eJxcWPawTKsd8M5VgJfz2M121bWYhDTH096Iwm91s=; h=Subject:To:Cc:From:Date:From; b=OC99vT32cZ8gGyBNFHqViyfVqzKe5oEPAwXkZqGv+aPSG0jP2CkAvTEtzQSi1yNw5 WWrbrUEYVIRhDW+EOqPulGCeTzNz1cPtQRcKndAaZIfqJ2Uzmvtfx24B4tImp5fTHT MuZwirLrwYDY1ehW5PaXZCeCkw2vHC1srq0FXJVJIOKaKvM+0LHtPCtksLJiiSUC46 W4t/JhCui92QHjCTQX31SDsihv5O1d8fxphLm0B7yxj+tBsdo3sohYt0D/aONTS6Zm H2Sa0MaamJy8SyGWqRkBWWuwBNdryPPc0D58DkW3JjZ2tm+GNjnjF6e+e5ICOAAZso wJCc3mT/ftD9w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FqsSV6dvdz9rxN; Wed, 26 May 2021 15:37:14 +0200 (CEST) Subject: Re: [PATCH 0/3] test/py: Rewrite SquashFS commands test suite To: Joao Marcos Costa , u-boot@lists.denx.de Cc: thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, sjg@chromium.org References: <20210524023133.22100-1-jmcosta944@gmail.com> From: Richard Genoud Message-ID: Date: Wed, 26 May 2021 13:37:14 +0000 MIME-Version: 1.0 In-Reply-To: <20210524023133.22100-1-jmcosta944@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr-FR Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi, Le 24/05/2021 à 04:31, Joao Marcos Costa a écrit : > Hello, > > This patch series fixes the following issues: > - poor strategy to check if files were properly loaded > - wrong quoting style for strings > - tests failing at the second run because of a wrong clean-up strategy > > Finally, it improves: > - code overall documentation level, with more comments and better > naming for functions and variables > - code readability by adding more helper functions > - completeness: more test cases were added for both sqfsls and sqfsload > commands > > The sqfsload new test suite may fail when testing images with fragmented > files if the patch I previously sent (fs/squashfs: fix reading of > fragmented files) is not applied, so this patch series depends on it. > > Best regards, > Joao > > Joao Marcos Costa (3): > test/py: rewrite common tools for SquashFS tests > test/py: rewrite sqfsload command test suite > test/py: rewrite sqfsls command test suite > > .../test_fs/test_squashfs/sqfs_common.py | 198 ++++++++++++------ > .../test_fs/test_squashfs/test_sqfs_load.py | 99 ++++++--- > .../test_fs/test_squashfs/test_sqfs_ls.py | 80 +++++-- > 3 files changed, 264 insertions(+), 113 deletions(-) > Tested-by: Richard Genoud Thanks !