From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FECEC43381 for ; Thu, 18 Feb 2021 17:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68FCA64EC4 for ; Thu, 18 Feb 2021 17:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234107AbhBRRXi (ORCPT ); Thu, 18 Feb 2021 12:23:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231801AbhBROna (ORCPT ); Thu, 18 Feb 2021 09:43:30 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F978C0613D6; Thu, 18 Feb 2021 06:42:13 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 1559741E96; Thu, 18 Feb 2021 14:42:03 +0000 (UTC) To: Mark Rutland Cc: Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-9-marcan@marcan.st> <20210217122200.GC5556@C02TD0UTHF1T.local> <20210218142205.GB89209@C02TD0UTHF1T.local> From: Hector Martin Subject: Re: [PATCH v2 08/25] arm64: Always keep DAIF.[IF] in sync Message-ID: Date: Thu, 18 Feb 2021 23:42:01 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210218142205.GB89209@C02TD0UTHF1T.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/2021 23.22, Mark Rutland wrote: > I think that for consistency we always want to keep IRQ and FIQ in-sync, > even when using GIC priorities. So when handling a pseudo-NMI we should > unmask DAIF.DA and leave DAIF.IF masked. In that case there's one more, in daifflags.h:local_daif_restore(): /* * If interrupts are disabled but we can take * asynchronous errors, we can take NMIs */ flags &= PSR_I_BIT; pmr = GIC_PRIO_IRQOFF; >> And a minor related one: should init_gic_priority_masking() WARN if FIQ is >> masked too? This probably goes with the above. > > I think it should, yes. Done for v3 then. Thanks! -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6A3C433DB for ; Thu, 18 Feb 2021 14:44:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 192C664E85 for ; Thu, 18 Feb 2021 14:44:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 192C664E85 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marcan.st Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IGT8MrF4agxm3iboaVHrEUuhlSUvV4EuTNrifcIdYEk=; b=ZyrTysgV5kMw7bCg74wCUb8Mb Bv5aaiK/j1OCIJW/zFTj0MUGl7XU2uSWsPE60OcDsE66CaAF3oqMNONe8wAzjxQqe9KKz6ztc1G8L 6sOF7sEuCqyo3VZb5NjNd+40kj4fA1pjkYE9YvKXoh7AC9wQ6U7/dUuArABbgvWvfAosXuP0tARaI ho25ZZfK9GN6HAmcYdMDLmnQ6lmE4gpUaOaaOv1xNO3oWdSdufc6yqHXUI/sllE7NzpYg/7/MA+oy sw5Yi81LhNXMIOqW/DdUD5AfJFVq9ed0OAlfkZErK9ZzhLb0CYef/+77/CzzLcG+6gEiP/aMBvbLE 3OKCFrc7g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCkVU-0008F8-AH; Thu, 18 Feb 2021 14:42:16 +0000 Received: from marcansoft.com ([212.63.210.85] helo=mail.marcansoft.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCkVS-0008EE-0x for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 14:42:15 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 1559741E96; Thu, 18 Feb 2021 14:42:03 +0000 (UTC) To: Mark Rutland References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-9-marcan@marcan.st> <20210217122200.GC5556@C02TD0UTHF1T.local> <20210218142205.GB89209@C02TD0UTHF1T.local> From: Hector Martin Subject: Re: [PATCH v2 08/25] arm64: Always keep DAIF.[IF] in sync Message-ID: Date: Thu, 18 Feb 2021 23:42:01 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210218142205.GB89209@C02TD0UTHF1T.local> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_094214_182953_8215365C X-CRM114-Status: GOOD ( 13.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Mark Kettenis , Will Deacon , linux-arm-kernel@lists.infradead.org, Stan Skowronek Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/02/2021 23.22, Mark Rutland wrote: > I think that for consistency we always want to keep IRQ and FIQ in-sync, > even when using GIC priorities. So when handling a pseudo-NMI we should > unmask DAIF.DA and leave DAIF.IF masked. In that case there's one more, in daifflags.h:local_daif_restore(): /* * If interrupts are disabled but we can take * asynchronous errors, we can take NMIs */ flags &= PSR_I_BIT; pmr = GIC_PRIO_IRQOFF; >> And a minor related one: should init_gic_priority_masking() WARN if FIQ is >> masked too? This probably goes with the above. > > I think it should, yes. Done for v3 then. Thanks! -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel