From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sharma, Shashank" Subject: Re: [PATCH v3 04/11] drm/i915/dsb: Indexed register write function for DSB. Date: Wed, 28 Aug 2019 22:16:45 +0530 Message-ID: References: <20190827191026.26175-1-animesh.manna@intel.com> <20190827191026.26175-5-animesh.manna@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9A9989D60 for ; Wed, 28 Aug 2019 16:46:50 +0000 (UTC) In-Reply-To: <20190827191026.26175-5-animesh.manna@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Animesh Manna , intel-gfx@lists.freedesktop.org Cc: Jani Nikula List-Id: intel-gfx@lists.freedesktop.org Ck9uIDgvMjgvMjAxOSAxMjo0MCBBTSwgQW5pbWVzaCBNYW5uYSB3cm90ZToKPiBEU0IgY2FuIHBy b2dyYW0gbGFyZ2Ugc2V0IG9mIGRhdGEgdGhyb3VnaCBpbmRleGVkIHJlZ2lzdGVyIHdyaXRlCj4g KG9wY29kZSAweDkpIGluIG9uZSBzaG90LiBXaWxsIGJlIHVzaW5nIGZvciBidWxrIHJlZ2lzdGVy IHByb2dyYW1taW5nClJlc2h1ZmZsZS0+IFRoaXMgZmVhdHVyZSBjYW4gYmUgdXNlZCBmb3IgYnVs ayByZWdpc3RlciBwcm9ncmFtbWluZyBlLmcuCj4gZS5nLiBnYW1tYSBsdXQgcHJvZ3JhbW1pbmcs IEhEUiBtZXRhIGRhdGEgcHJvZ3JhbW1pbmcuCj4KPiB2MTogSW5pdGlhbCB2ZXJzaW9uLgo+Cj4g djI6IHNpbXBsaWZpZWQgY29kZSBieSB1c2luZyBBTElHTigpLiAoQ2hyaXMpCj4KPiBDYzogU2hh c2hhbmsgU2hhcm1hIDxzaGFzaGFuay5zaGFybWFAaW50ZWwuY29tPgo+IENjOiBJbXJlIERlYWsg PGltcmUuZGVha0BpbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRl bC5jb20+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBBbmltZXNoIE1hbm5hIDxhbmltZXNoLm1hbm5hQGludGVsLmNvbT4KPiAtLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmMgfCA0OCArKysrKysr KysrKysrKysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZHNiLmggfCAgOCArKysrCj4gICAyIGZpbGVzIGNoYW5nZWQsIDU2IGluc2VydGlvbnMoKykKPgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kc2IuYwo+IGluZGV4IGRmMjg4NDQ2 Y2FlYi4uNTIwZjJiYmNjOGFlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rp c3BsYXkvaW50ZWxfZHNiLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu dGVsX2RzYi5jCj4gQEAgLTIyLDYgKzIyLDcgQEAKPiAgICNkZWZpbmUgRFNCX09QQ09ERV9JTkRF WEVEX1dSSVRFCTB4OQo+ICAgI2RlZmluZSBEU0JfT1BDT0RFX1BPTEwJCQkweEEKPiAgICNkZWZp bmUgRFNCX0JZVEVfRU4JCQkoMHhmIDw8IDIwKQo+ICsjZGVmaW5lIERTQl9SRUdfVkFMVUVfTUFT SwkJMHhmZmZmZgo+ICAgCj4gICBzdHJ1Y3QgaW50ZWxfZHNiICoKPiAgIGludGVsX2RzYl9nZXQo c3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gQEAgLTk2LDYgKzk3LDUzIEBAIHZvaWQgaW50ZWxf ZHNiX3B1dChzdHJ1Y3QgaW50ZWxfZHNiICpkc2IpCj4gICAJfQo+ICAgfQo+ICAgCj4gK3ZvaWQg aW50ZWxfZHNiX2luZGV4ZWRfcmVnX3dyaXRlKHN0cnVjdCBpbnRlbF9kc2IgKmRzYiwgaTkxNV9y ZWdfdCByZWcsCj4gKwkJCQkgdTMyIHZhbCkKV2UgbWlnaHQgbmVlZCBvbmUgc3BhY2UgaGVyZSwg dG8gZ2V0IHRoaXMgYWxpZ25lZCB0byBzdGFydCBvZiB0aGUgbGluZSAKYWJvdmUgKG9yIGlzIHRo aXMgZHVlIHRvIG15IG1haWwgY2xpZW50ID8pLgo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YyA9IGRzYi0+Y3J0YzsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ICsJdTMyICpidWYgPSBkc2ItPmNtZF9idWY7Cj4g Kwl1MzIgcmVnX3ZhbDsKPiArCi0gRG8gd2UgbmVlZCBhIEhBU19EU0IgY2hlY2sgYXQgc3RhcnQg b3IgdGhlIGNhbGxlciB3aWxsIHRha2UgY2FyZSBvZiBpdCA/Cj4gKwlpZiAoIWJ1Zikgewo+ICsJ CUk5MTVfV1JJVEUocmVnLCB2YWwpOwpJIGFtIHVuZGVyIHRoZSBhc3N1bXB0aW9uIHRoYXQgaW5k ZXhlZCByZWcgd3JpdGUgaXMgdG8gd3JpdGUgbXVsdGlwbGUgCnJlZ2lzdGVycywgYW5kICdyZWcn IGlzIHRoZSBiYXNlIHZhbHVlIG9mIHRoZSByZWdpc3RlciBzZXQuIEkgZG9udCB0aGluayAKaXQg bWFrZXMgc2Vuc2UgdG8gd3JpdGUgYSBzaW5nbGUgcmVnaXN0ZXIgaGVyZSBpbiBjYXNlIG9mIERT QiBmYWlsdXJlID8KPiArCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJaWYgKFdBUk5fT04oZHNiLT5m cmVlX3BvcyA+PSBEU0JfQlVGX1NJWkUpKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiRFNCIGJ1ZmZl ciBvdmVyZmxvdy5cbiIpOwo+ICsJCXJldHVybjsKPiArCX0KPiArCXJlZ192YWwgPSBidWZbZHNi LT5pbnNfc3RhcnRfb2Zmc2V0ICsgMV0gJiBEU0JfUkVHX1ZBTFVFX01BU0s7CgpXaHkgZG8gd2Ug aGF2ZSB0aGlzICsxIGhlcmUgPyBvbiB0aGUgdmVyeSBmaXJzdCBydW4gKHdoZW4gCmluc19zdGFy dF9vZmZzZXQgaXMgMCksIHRoaXMgd2lsbCBmZXRjaCByZWdfdmFsID0gYnVmWzFdOyBJcyB0aGlz IHdoYXQgCndlIHdhbnQgdG8gZG8gPwoKPiArCWlmIChyZWdfdmFsICE9IGk5MTVfbW1pb19yZWdf b2Zmc2V0KHJlZykpIHsKPiArCQkvKiBFdmVyeSBpbnN0cnVjdGlvbiBzaG91bGQgYmUgOCBieXRl IGFsaWduZWQuICovCj4gKwkJZHNiLT5mcmVlX3BvcyA9IEFMSUdOKGRzYi0+ZnJlZV9wb3MsIDIp OwpUaGUgY29tbWVudCBzYXlzIHRoYXQgeW91IHdhbnQgdGhlIHBvc2l0aW9uIHRvIGJlIDggYnl0 ZXMgYWxpZ24sIGJ1dCB0aGUgCmZhY3RvciBzZW50IHRvIHRoZSBtYWNybyBpcyAyID8KPiArCj4g KwkJLyogVXBkYXRlIHRoZSBzaXplLiAqLwo+ICsJCWRzYi0+aW5zX3N0YXJ0X29mZnNldCA9IGRz Yi0+ZnJlZV9wb3M7ClRoaXMgY29tbWVudCBpcyBpcnJlbGV2YW50LCB5b3UgYXJlIG5vdCB1cGRh dGluZyB0aGUgc2l6ZSwgeW91IGFyZSAKY2FjaGluZyB0aGUgYmFzZSBtZW1vcnkgbG9jYXRpb24u Cj4gKwkJYnVmW2RzYi0+ZnJlZV9wb3MrK10gPSAxOwoKV2hhdCBkb2VzIHRoaXMgaW5kaWNhdGUg PyBXaGF0IGlzIDEgPwoKSXQgd291bGQgYmUgZ3JlYXQgaWYgeW91IGNhbiBhZGQgYW4gYXNraSBn cmFwaC90YWJsZSBhbmQgZXhwbGFpbiB3aGF0IApkb2VzIHRoaXMgRFNCIGNvbW1hbmQgYnVmZmVy IGFjdHVhbGx5IGNvbnRhaW5zIGFzIHBlciB5b3VyIGRlc2lnbi4KCj4gKwo+ICsJCS8qIFVwZGF0 ZSB0aGUgb3Bjb2RlIGFuZCByZWcuICovCj4gKwkJYnVmW2RzYi0+ZnJlZV9wb3MrK10gPSAoRFNC X09QQ09ERV9JTkRFWEVEX1dSSVRFICA8PAo+ICsJCQkJCURTQl9PUENPREVfU0hJRlQpIHwKPiAr CQkJCQlpOTE1X21taW9fcmVnX29mZnNldChyZWcpOwo+ICsKPiArCQkvKiBVcGRhdGUgdGhlIHZh bHVlLiAqLwo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zKytdID0gdmFsOwo+ICsJfSBlbHNlIHsKPiAr CQkvKiBVcGRhdGUgdGhlIG5ldyB2YWx1ZS4gKi8KPiArCQlidWZbZHNiLT5mcmVlX3BvcysrXSA9 IHZhbDsKPiArCj4gKwkJLyogVXBkYXRlIHRoZSBzaXplLiAqLwo+ICsJCWJ1Zltkc2ItPmluc19z dGFydF9vZmZzZXRdKys7Cj4gKwl9CgpUaGUgY29kZSBpcyBsb29raW5nIHVubmVjZXNzYXJpbHkg Y29tcGxpY2F0ZWQgYXMgaW5zX3N0YXJ0X29mZnNldCBhbmQgCmZyZWVfcG9zIGFyZSBiZWluZyB1 c2VkIGZvciBtdWx0aXBsZSByZWFzb25zLiBJIGd1ZXNzIHlvdSBjYW4gdXNlIHNvbWUgCmxvY2Fs IHZhcmlhYmxlcyBsaWtlOgoKdTMyIGJhc2UgPSBjb3VudCA9IEFMSUdOKCk7CgogwqB7CgogwqDC oMKgIGJ1ZiBbY291bnQrK10gPSBzaXplOwoKIMKgwqAgYnVmIFtjb3VudCsrXSA9IGNvbW1hbmQ7 CgogwqAgYnVmIFtjb3VudCsrXSA9IHZhbHVlOwoKfQoKZHNiLT5zdGFydF9vZmZzZXQgPSBiYXNl OwoKZHNiLT5mcmVlX3BvcyA9IGNvdW50OwoKPiArCj4gKwkvKiBpZiBudW1iZXIgb2YgZGF0YSB3 b3JkcyBpcyBvZGQsIHRoZW4gdGhlIGxhc3QgZHdvcmQgc2hvdWxkIGJlIDAuKi8KPiArCWlmIChk c2ItPmZyZWVfcG9zICYgMHgxKQo+ICsJCWJ1Zltkc2ItPmZyZWVfcG9zXSA9IDA7Cj4gK30KPiAr Cj4gICB2b2lkIGludGVsX2RzYl9yZWdfd3JpdGUoc3RydWN0IGludGVsX2RzYiAqZHNiLCBpOTE1 X3JlZ190IHJlZywgdTMyIHZhbCkKPiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9 IGRzYi0+Y3J0YzsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p bnRlbF9kc2IuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZHNiLmgKPiBp bmRleCAxYjMzYWIxMTg2NDAuLmM4NDg3NDdmNTJkOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RzYi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZGlzcGxheS9pbnRlbF9kc2IuaAo+IEBAIC0zMCwxMSArMzAsMTkgQEAgc3RydWN0IGludGVs X2RzYiB7Cj4gICAJICogYW5kIGhlbHAgaW4gY2FsY3VsYXRpbmcgY21kX2J1Zl90YWlsLgo+ICAg CSAqLwo+ICAgCWludCBmcmVlX3BvczsKPiArCj4gKwkvKgo+ICsJICogaW5zX3N0YXJ0X29mZnNl dCB3aWxsIGhlbHAgdG8gc3RvcmUgc3RhcnQgYWRkcmVzcwo+ICsJICogb2YgdGhlIGRzYiBpbnN0 dWN0aW9uIG9mIGF1dG8taW5jcmVtZW50IHJlZ2lzdGVyLgo+ICsJICovCj4gKwl1MzIgaW5zX3N0 YXJ0X29mZnNldDsKSG93IGFib3V0IHRoZSB2YXJpYWJsZSB0byBiZSBuYW1lZCBhcyBiYXNlX29m ZnNldCA/IEFsc28sIGRvIHdlIG5lZWQgdG8gCmtlZXAgdGhpcyBzYXZlZCwgZXZlbiB3aGVuIHRo ZSB3cml0aW5nIGlzIGRvbmUgPwo+ICAgfTsKPiAgIAo+ICAgc3RydWN0IGludGVsX2RzYiAqCj4g ICBpbnRlbF9kc2JfZ2V0KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKTsKPiAgIHZvaWQgaW50ZWxf ZHNiX3B1dChzdHJ1Y3QgaW50ZWxfZHNiICpkc2IpOwo+ICAgdm9pZCBpbnRlbF9kc2JfcmVnX3dy aXRlKHN0cnVjdCBpbnRlbF9kc2IgKmRzYiwgaTkxNV9yZWdfdCByZWcsIHUzMiB2YWwpOwo+ICt2 b2lkIGludGVsX2RzYl9pbmRleGVkX3JlZ193cml0ZShzdHJ1Y3QgaW50ZWxfZHNiICpkc2IsIGk5 MTVfcmVnX3QgcmVnLAo+ICsJCQkJIHUzMiB2YWwpOwoKQ3Jvc3MgY2hlY2sgdGhlIGFsaWdubWVu dCBvZiBzZWNvbmQgbGluZS4KCi0gU2hhc2hhbmsKCj4gICAKPiAgICNlbmRpZgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=