From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B79C432BE for ; Fri, 27 Aug 2021 15:30:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCB7060FD9 for ; Fri, 27 Aug 2021 15:30:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BCB7060FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5863F170D; Fri, 27 Aug 2021 17:29:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5863F170D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1630078210; bh=Z9YCxM19NTbHNIIyx/VhdPDuBCm5n/qvojvZGsNabQs=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mmSbJNo85Ytckxs/3FO6QiSuo3xIjLPSQlIDQIILVlTm33wZoFcRg2v7l017M8xq9 Hb5wWpSHuZb6BmYopMuCCI/8q5I7KB9uzw1mB+LxbGRPBgN0bKXLbr0qaP2a7JP671 rU2H6e/ilwtzEVVCdzenXubffYdQkiyZlZ4Q1OOE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5DFBBF80107; Fri, 27 Aug 2021 17:29:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 47CCAF80129; Fri, 27 Aug 2021 17:28:51 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 74096F80054 for ; Fri, 27 Aug 2021 17:28:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 74096F80054 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="yxixc4aH" Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17RAUIpe002666; Fri, 27 Aug 2021 17:28:36 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=LQt026cMUPGEhdGgKRHOAiE5md4Umql7XViI6VQ6s/U=; b=yxixc4aHPR4KoPUgPgfq8E6GkwcF32s8WK12A/Wt6wqr+9JjnKBftH/ukdFYEYmHyWWX hNUXNa8wbKgmKYVhNQKRGLNGFBb6WyAkpiNjqbKQzaGzCu6F8sVQsAf+PbkXQ1xhiYjc nPV3dG39tcLIaJPxMDVB2fiPo0SgYfmYQM3fp78gGuxhJe5aoboq/Rgot0ijMkA7dVFZ rUvgmY3BgQ21/4luLthdZkV1i1ai9kQnBUodZENHM2j8fhapHvmBcI7PKUYoj89tD5sj 38LLhPDObUIH5NWi2jNYO+yK/K+EY76+XplSLiv25fe0VYmXK/MTU50V8XFfefOSpToC BA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3apqmkv1nw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Aug 2021 17:28:36 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id AB17110002A; Fri, 27 Aug 2021 17:28:35 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 818CC239D64; Fri, 27 Aug 2021 17:28:35 +0200 (CEST) Received: from lmecxl0577.lme.st.com (10.75.127.49) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 27 Aug 2021 17:28:35 +0200 Subject: Re: [PATCH 6/6] ASoC: audio-graph: remove Platform support To: Kuninori Morimoto References: <871rb758x7.wl-kuninori.morimoto.gx@renesas.com> <87sg3n3ubg.wl-kuninori.morimoto.gx@renesas.com> <87k0k916pj.wl-kuninori.morimoto.gx@renesas.com> From: Olivier MOYSAN Message-ID: Date: Fri, 27 Aug 2021 17:28:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87k0k916pj.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-08-27_04,2021-08-26_02,2020-04-07_01 Cc: Linux-ALSA X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Kuninori, Thanks for your feedback On 8/26/21 12:48 AM, Kuninori Morimoto wrote: > > Hi Olivier > > Thank you for conntacting me > >> I have seen that the STM32MP15 audio sound card is no more functional >> with recent kernels (5.13 or 5.14) >> The sound card is registered, but the all devices are issuing an error >> at runtime. These devices are using stm32_sai.c or stm32_i2s.c >> drivers. >> >> I found that the regression is linked to the commit >> 63f2f9cceb09f8e5f668e36c1cf764eea468ebed "ASoC: audio-graph: remove >> Platform support", as reverting this commit fixes the issue. >> >> When the platform component is missing the pcm_construct ops in the >> pcm dmaengine, is never called, resulting in an incomplete >> initialization of the sound card. >> I can't figure out what is the right way to handle this change, however. >> Do I need to update the CPU drivers to work without a platform component >> or does the audio-graph card has to be changed in some way ? > > Ahh, OK, I see. > Indeed the dev which is used for CPU is used at soc-generic-dmaengine as Platform, > without indicating it at DT (= simple-card has "plat" support for platform at DT, > but audio-graph doesn't ). > Yes, it seems that there is no way to force CPU to be used as platform with audio-graph. so, asoc_simple_canonicalize_platform() is necessary to do the job in this case. > I think key funciton is asoc_simple_canonicalize_platform(). > >> What do you mean "We can respawn it when we need it", in the commit >> message ? > > This means we can revert this patch if needed, and yes it is needed :) > Could you please respawn the feature ? or I can do it if you want. > I feel more confortable if you revert the commit, as you are the author of the patch. Thanks. BRs Olivier > Thank you for your help !! > > Best regards > --- > Kuninori Morimoto >