From: "Mueller, Reinhold" <Reinhold.Mueller@emtrion.de>
To: 'Fabio Estevam' <festevam@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: AW: [PATCH v4 2/2] arm64: dts: imx8mm: Add support for emtrion emCON-MX8M Mini
Date: Tue, 21 Dec 2021 07:33:16 +0000 [thread overview]
Message-ID: <e6adf5d9473e417d85a1845b007a4ee1@emtrion.de> (raw)
In-Reply-To: <CAOMZO5BvLZYh3=q_-XNcw-v5wDcBpR3Qo26Gd3hTtJ_a-FQiuA@mail.gmail.com>
Hi Fabio,
thanks for the fast feedback.
Below i have commented your issue for clarification.
Regards
Reinhold
Reinhold Mueller
Software engineer
emtrion GmbH
Am Hasenbiel 6 | 76297 Stutensee | Germany
Phone +49 7244 62694 20
Fax +49 7244 62694 19
Email Reinhold.Mueller@emtrion.de
Online www.emtrion.de
*** Merry X-Mas & Happy New Year 2022 ***
emtrion GmbH • Amtsgericht Mannheim • HRB 110 300 • Geschäftsführer: Ramona Maurer, Achmed Haddou • Umsatzsteueridentifikationsnummer:DE813694260 • Impressum: www.emtrion.de/de/impressum.html
HINWEIS: Personenbezogene Daten, die Sie per E-Mail an uns übermitteln, werden bei uns gespeichert und verarbeitet. Informationen zu unseren gesetzlichen Informationspflichten, zu uns und unseren Dienstleistungen finden Sie in unseren Datenschutzhinweisen.
Diese E-Mail kann vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind, oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte den Absender und vernichten diese Mail. Das unerlaubte kopieren, sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
> -----Ursprüngliche Nachricht-----
> Von: Fabio Estevam <festevam@gmail.com>
> Gesendet: Dienstag, 21. Dezember 2021 01:06
> An: Mueller, Reinhold <Reinhold.Mueller@emtrion.de>
> Cc: Rob Herring <robh+dt@kernel.org>; Sascha Hauer
> <s.hauer@pengutronix.de>; Sascha Hauer <kernel@pengutronix.de>;
> Shawn Guo <shawnguo@kernel.org>; NXP Linux Team <linux-
> imx@nxp.com>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE
> BINDINGS <devicetree@vger.kernel.org>; linux-kernel <linux-
> kernel@vger.kernel.org>
> Betreff: Re: [PATCH v4 2/2] arm64: dts: imx8mm: Add support for emtrion
> emCON-MX8M Mini
>
> Hi Reinhold,
>
> On Mon, Dec 20, 2021 at 4:23 AM <reinhold.mueller@emtrion.com> wrote:
>
> > + pinctrl_ecspi1: ecspi1-grp {
> > + fsl,pins = <
> > + MX8MM_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK 0x82
> > + MX8MM_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI 0x82
> > + MX8MM_IOMUXC_ECSPI1_MISO_ECSPI1_MISO 0x82
> > + >;
> > + };
> > +
> > + pinctrl_ecspi1_cs: ecspi1-cs {
> > + fsl,pins = <
> > + MX8MM_IOMUXC_ECSPI1_SS0_GPIO5_IO9 0x40000
> > + MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 0x40000
>
> This version looks good to me.
>
> One nit: you seem to use a single SPI chipselect, but you add two entries
> here.
>
> Is the MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13 needed too?
Yes, of course the emCON provides a connector connecting two slaves on the spi bus.
>
> Either way:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
next prev parent reply other threads:[~2021-12-21 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 7:23 [PATCH v4 0/2] new emtrion hardware emCON-MX8M Mini reinhold.mueller
2021-12-20 7:23 ` [PATCH v4 1/2] dt-bindings: arm: Add " reinhold.mueller
2021-12-21 15:13 ` Rob Herring
2021-12-20 7:23 ` [PATCH v4 2/2] arm64: dts: imx8mm: Add support for emtrion " reinhold.mueller
2021-12-21 0:06 ` Fabio Estevam
2021-12-21 7:33 ` Mueller, Reinhold [this message]
2022-01-24 17:05 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6adf5d9473e417d85a1845b007a4ee1@emtrion.de \
--to=reinhold.mueller@emtrion.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.