All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Fix memory leak when gfs2meta's fs_context is freed
Date: Wed, 9 Oct 2019 07:36:39 +0100	[thread overview]
Message-ID: <e6c80348-1bd1-bb02-0089-1ed836821fb8@redhat.com> (raw)
In-Reply-To: <824921067.4882112.1570209623167.JavaMail.zimbra@redhat.com>

On 04/10/2019 18:20, Bob Peterson wrote:
> ----- Original Message -----
>> gfs2 and gfs2meta share an ->init_fs_context function which allocates an
>> args structure stored in fc->fs_private. gfs2 registers a ->free
>> function to free this memory when the fs_context is cleaned up, but
>> there was not one registered for gfs2meta, causing a leak.
>>
>> Register a ->free function for gfs2meta. The existing gfs2_fc_free
>> function does what we need.
>>
>> Reported-by: syzbot+c2fdfd2b783754878fb6 at syzkaller.appspotmail.com
>> Signed-off-by: Andrew Price <anprice@redhat.com>
>> ---
> 
> Thanks. Now pushed to for-next.

Thanks Bob. Can we get this sent to Linus as a fix during this cycle?

Andy



  reply	other threads:[~2019-10-09  6:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03  0:19 memory leak in gfs2_init_fs_context syzbot
2019-10-03  0:19 ` [Cluster-devel] " syzbot
2019-10-03 15:35 ` [PATCH] gfs2: Fix memory leak when gfs2meta's fs_context is freed Andrew Price
2019-10-03 15:35   ` [Cluster-devel] " Andrew Price
2019-10-04 17:20   ` Bob Peterson
2019-10-04 17:20     ` Bob Peterson
2019-10-09  6:36     ` Andrew Price [this message]
2019-10-23 10:12       ` Andrew Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6c80348-1bd1-bb02-0089-1ed836821fb8@redhat.com \
    --to=anprice@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.