All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirti Wankhede <kwankhede@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>, David Airlie <airlied@linux.ie>,
	"Tony Krowiak" <akrowiak@linux.ibm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	<intel-gfx@lists.freedesktop.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Jason Herne <jjherne@linux.ibm.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	<kvm@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-s390@vger.kernel.org>, Halil Pasic <pasic@linux.ibm.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 00/10] Allow mdev drivers to directly create the vfio_device
Date: Mon, 14 Jun 2021 20:04:03 +0530	[thread overview]
Message-ID: <e6cecaed-3257-e636-52c2-abf7af2cdffa@nvidia.com> (raw)
In-Reply-To: <0-v1-324b2038f212+1041f1-vfio3a_jgg@nvidia.com>

Jason,

I couldn't find patch 1,2,4 and 5 of these series. Can you please keep 
kvm@vger.kernel.org cc for all patches?

Also it will be helpful if you can add version prefix, eg. 'v3' for this 
series, in subject line.

Thanks,
Kirti

On 6/8/2021 6:25 AM, Jason Gunthorpe wrote:
> This is a "v3" of the previous posted full conversion:
>    https://lore.kernel.org/r/0-v2-7667f42c9bad+935-vfio3_jgg@nvidia.com
> 
> Without the trailing patches that are running into complications:
>   - The CCW conversion has some complicated remarks
>   - AP is waiting for some locking stuff to get worked out
>   - No feedback on GT
>   - The license change topic for removing vfio_mdev.c
> 
> Getting the baseline functionality merged will allow Intel's IDXD mdev
> driver to advance. It has already been RFC posted in the new format:
> 
> https://lore.kernel.org/kvm/162164243591.261970.3439987543338120797.stgit@djiang5-desk3.ch.intel.com/
> 
> This series includes base infrastructure and the sample conversions. The
> remaining four issues can be sorted out one by one.
> 
> The major change in v3 is to enhance the driver core support for binding
> based on the request from Christoph Hellwig and Dan Williams. Based on
> some light analysis this looks broadly useful:
> 
> https://lore.kernel.org/kvm/20210428233856.GY1370958@nvidia.com/
> 
> ====
> 
> The mdev bus's core part for managing the lifecycle of devices is mostly
> as one would expect for a driver core bus subsystem.
> 
> However instead of having a normal 'struct device_driver' and binding the
> actual mdev drivers through the standard driver core mechanisms it open
> codes this with the struct mdev_parent_ops and provides a single driver
> that shims between the VFIO core's struct vfio_device and the actual
> device driver.
> 
> Instead, allow mdev drivers implement an actual struct mdev_driver and
> directly call vfio_register_group_dev() in the probe() function for the
> mdev. Arrange to bind the created mdev_device to the mdev_driver that is
> provided by the end driver.
> 
> The actual execution flow doesn't change much, eg what was
> parent_ops->create is now device_driver->probe and it is called at almost
> the exact same time - except under the normal control of the driver core.
> 
> Ultimately converting all the drivers unlocks a fair number of additional
> VFIO simplifications and cleanups.
> 
> v3:
>   - Use device_driver_attach() from the driver core
>   - 5 new patches to make device_driver_attach() exported and usable for this
>   - Remove trailing patches for now
> v2: https://lore.kernel.org/r/0-v2-7667f42c9bad+935-vfio3_jgg@nvidia.com
>   - Keep && m in samples kconfig
>   - Restore accidently squashed removeal of vfio_mdev.c
>   - Remove indirections to call bus_register()/bus_unregister()
>   - Reflow long doc lines
> v1: https://lore.kernel.org/r/0-v1-d88406ed308e+418-vfio3_jgg@nvidia.com
> 
> Jason Gunthorpe (10):
>    driver core: Do not continue searching for drivers if deferred probe
>      is used
>    driver core: Pull required checks into driver_probe_device()
>    driver core: Flow the return code from ->probe() through to sysfs bind
>    driver core: Don't return EPROBE_DEFER to userspace during sysfs bind
>    driver core: Export device_driver_attach()
>    vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE
>    vfio/mdev: Allow the mdev_parent_ops to specify the device driver to
>      bind
>    vfio/mtty: Convert to use vfio_register_group_dev()
>    vfio/mdpy: Convert to use vfio_register_group_dev()
>    vfio/mbochs: Convert to use vfio_register_group_dev()
> 
>   Documentation/s390/vfio-ap.rst   |   1 -
>   arch/s390/Kconfig                |   2 +-
>   drivers/base/base.h              |   1 -
>   drivers/base/bus.c               |   6 +-
>   drivers/base/dd.c                | 116 ++++++++++++-------
>   drivers/gpu/drm/i915/Kconfig     |   2 +-
>   drivers/vfio/mdev/Kconfig        |   7 --
>   drivers/vfio/mdev/Makefile       |   3 +-
>   drivers/vfio/mdev/mdev_core.c    |  46 ++++++--
>   drivers/vfio/mdev/mdev_driver.c  |  10 ++
>   drivers/vfio/mdev/mdev_private.h |   2 +
>   drivers/vfio/mdev/vfio_mdev.c    |  24 +---
>   include/linux/device.h           |   2 +
>   include/linux/mdev.h             |   2 +
>   samples/Kconfig                  |   6 +-
>   samples/vfio-mdev/mbochs.c       | 163 +++++++++++++++------------
>   samples/vfio-mdev/mdpy.c         | 159 ++++++++++++++------------
>   samples/vfio-mdev/mtty.c         | 185 ++++++++++++++-----------------
>   18 files changed, 397 insertions(+), 340 deletions(-)
> 

WARNING: multiple messages have this Message-ID
From: Kirti Wankhede <kwankhede@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>, David Airlie <airlied@linux.ie>,
	"Tony Krowiak" <akrowiak@linux.ibm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	 Cornelia Huck <cohuck@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	<dri-devel@lists.freedesktop.org>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	<intel-gfx@lists.freedesktop.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Jason Herne <jjherne@linux.ibm.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	<kvm@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-s390@vger.kernel.org>, Halil Pasic <pasic@linux.ibm.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH 00/10] Allow mdev drivers to directly create the vfio_device
Date: Mon, 14 Jun 2021 20:04:03 +0530	[thread overview]
Message-ID: <e6cecaed-3257-e636-52c2-abf7af2cdffa@nvidia.com> (raw)
In-Reply-To: <0-v1-324b2038f212+1041f1-vfio3a_jgg@nvidia.com>

Jason,

I couldn't find patch 1,2,4 and 5 of these series. Can you please keep 
kvm@vger.kernel.org cc for all patches?

Also it will be helpful if you can add version prefix, eg. 'v3' for this 
series, in subject line.

Thanks,
Kirti

On 6/8/2021 6:25 AM, Jason Gunthorpe wrote:
> This is a "v3" of the previous posted full conversion:
>    https://lore.kernel.org/r/0-v2-7667f42c9bad+935-vfio3_jgg@nvidia.com
> 
> Without the trailing patches that are running into complications:
>   - The CCW conversion has some complicated remarks
>   - AP is waiting for some locking stuff to get worked out
>   - No feedback on GT
>   - The license change topic for removing vfio_mdev.c
> 
> Getting the baseline functionality merged will allow Intel's IDXD mdev
> driver to advance. It has already been RFC posted in the new format:
> 
> https://lore.kernel.org/kvm/162164243591.261970.3439987543338120797.stgit@djiang5-desk3.ch.intel.com/
> 
> This series includes base infrastructure and the sample conversions. The
> remaining four issues can be sorted out one by one.
> 
> The major change in v3 is to enhance the driver core support for binding
> based on the request from Christoph Hellwig and Dan Williams. Based on
> some light analysis this looks broadly useful:
> 
> https://lore.kernel.org/kvm/20210428233856.GY1370958@nvidia.com/
> 
> ====
> 
> The mdev bus's core part for managing the lifecycle of devices is mostly
> as one would expect for a driver core bus subsystem.
> 
> However instead of having a normal 'struct device_driver' and binding the
> actual mdev drivers through the standard driver core mechanisms it open
> codes this with the struct mdev_parent_ops and provides a single driver
> that shims between the VFIO core's struct vfio_device and the actual
> device driver.
> 
> Instead, allow mdev drivers implement an actual struct mdev_driver and
> directly call vfio_register_group_dev() in the probe() function for the
> mdev. Arrange to bind the created mdev_device to the mdev_driver that is
> provided by the end driver.
> 
> The actual execution flow doesn't change much, eg what was
> parent_ops->create is now device_driver->probe and it is called at almost
> the exact same time - except under the normal control of the driver core.
> 
> Ultimately converting all the drivers unlocks a fair number of additional
> VFIO simplifications and cleanups.
> 
> v3:
>   - Use device_driver_attach() from the driver core
>   - 5 new patches to make device_driver_attach() exported and usable for this
>   - Remove trailing patches for now
> v2: https://lore.kernel.org/r/0-v2-7667f42c9bad+935-vfio3_jgg@nvidia.com
>   - Keep && m in samples kconfig
>   - Restore accidently squashed removeal of vfio_mdev.c
>   - Remove indirections to call bus_register()/bus_unregister()
>   - Reflow long doc lines
> v1: https://lore.kernel.org/r/0-v1-d88406ed308e+418-vfio3_jgg@nvidia.com
> 
> Jason Gunthorpe (10):
>    driver core: Do not continue searching for drivers if deferred probe
>      is used
>    driver core: Pull required checks into driver_probe_device()
>    driver core: Flow the return code from ->probe() through to sysfs bind
>    driver core: Don't return EPROBE_DEFER to userspace during sysfs bind
>    driver core: Export device_driver_attach()
>    vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE
>    vfio/mdev: Allow the mdev_parent_ops to specify the device driver to
>      bind
>    vfio/mtty: Convert to use vfio_register_group_dev()
>    vfio/mdpy: Convert to use vfio_register_group_dev()
>    vfio/mbochs: Convert to use vfio_register_group_dev()
> 
>   Documentation/s390/vfio-ap.rst   |   1 -
>   arch/s390/Kconfig                |   2 +-
>   drivers/base/base.h              |   1 -
>   drivers/base/bus.c               |   6 +-
>   drivers/base/dd.c                | 116 ++++++++++++-------
>   drivers/gpu/drm/i915/Kconfig     |   2 +-
>   drivers/vfio/mdev/Kconfig        |   7 --
>   drivers/vfio/mdev/Makefile       |   3 +-
>   drivers/vfio/mdev/mdev_core.c    |  46 ++++++--
>   drivers/vfio/mdev/mdev_driver.c  |  10 ++
>   drivers/vfio/mdev/mdev_private.h |   2 +
>   drivers/vfio/mdev/vfio_mdev.c    |  24 +---
>   include/linux/device.h           |   2 +
>   include/linux/mdev.h             |   2 +
>   samples/Kconfig                  |   6 +-
>   samples/vfio-mdev/mbochs.c       | 163 +++++++++++++++------------
>   samples/vfio-mdev/mdpy.c         | 159 ++++++++++++++------------
>   samples/vfio-mdev/mtty.c         | 185 ++++++++++++++-----------------
>   18 files changed, 397 insertions(+), 340 deletions(-)
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-06-14 14:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  0:55 Jason Gunthorpe
2021-06-08  0:55 ` [Intel-gfx] " Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 01/10] driver core: Do not continue searching for drivers if deferred probe is used Jason Gunthorpe
2021-06-08  5:51   ` Christoph Hellwig
2021-06-08  6:44   ` Greg Kroah-Hartman
2021-06-08 12:16     ` Jason Gunthorpe
2021-06-08 13:13       ` Greg Kroah-Hartman
2021-06-08 13:53         ` Jason Gunthorpe
2021-06-08  7:35   ` Greg Kroah-Hartman
2021-06-08 12:17     ` Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 02/10] driver core: Pull required checks into driver_probe_device() Jason Gunthorpe
2021-06-08  5:59   ` Christoph Hellwig
2021-06-08 12:21     ` Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Jason Gunthorpe
2021-06-08  6:07   ` Christoph Hellwig
2021-06-08 23:53     ` Jason Gunthorpe
2021-06-08  6:47   ` Greg Kroah-Hartman
2021-06-08 12:30     ` Jason Gunthorpe
2021-06-08 13:16       ` Greg Kroah-Hartman
2021-06-08 14:03         ` Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during " Jason Gunthorpe
2021-06-08  6:14   ` Christoph Hellwig
2021-06-08  7:37   ` Greg Kroah-Hartman
2021-06-08  0:55 ` [PATCH 05/10] driver core: Export device_driver_attach() Jason Gunthorpe
2021-06-08  6:19   ` Christoph Hellwig
2021-06-08 12:33     ` Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE Jason Gunthorpe
2021-06-08  0:55   ` [Intel-gfx] " Jason Gunthorpe
2021-06-08  6:20   ` Christoph Hellwig
2021-06-08  6:20     ` [Intel-gfx] " Christoph Hellwig
2021-06-11 12:40   ` Cornelia Huck
2021-06-11 12:40     ` [Intel-gfx] " Cornelia Huck
2021-06-14 12:35     ` Jason Gunthorpe
2021-06-14 12:35       ` [Intel-gfx] " Jason Gunthorpe
2021-06-14 12:35       ` Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Jason Gunthorpe
2021-06-08  6:21   ` Christoph Hellwig
2021-06-08  0:55 ` [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 09/10] vfio/mdpy: " Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 10/10] vfio/mbochs: " Jason Gunthorpe
2021-06-08  6:22 ` [PATCH 00/10] Allow mdev drivers to directly create the vfio_device Christoph Hellwig
2021-06-08  6:22   ` [Intel-gfx] " Christoph Hellwig
2021-06-14 14:34 ` Kirti Wankhede [this message]
2021-06-14 14:34   ` Kirti Wankhede
2021-06-14 14:34   ` Kirti Wankhede
2021-06-14 14:36   ` Jason Gunthorpe
2021-06-14 14:36     ` [Intel-gfx] " Jason Gunthorpe
2021-06-14 14:36     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6cecaed-3257-e636-52c2-abf7af2cdffa@nvidia.com \
    --to=kwankhede@nvidia.com \
    --cc=airlied@linux.ie \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=corbet@lwn.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gor@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hca@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jgg@nvidia.com \
    --cc=jjherne@linux.ibm.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    --cc=rafael@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --subject='Re: [PATCH 00/10] Allow mdev drivers to directly create the vfio_device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.