From mboxrd@z Thu Jan  1 00:00:00 1970
From: jilaiw@codeaurora.org
Subject: Re: [PATCH 1/2] drm/doc: Add hflip/vflip property descriptions in
 msm
Date: Wed, 29 Jul 2015 20:50:01 -0000
Message-ID: <e6d7e6b0385a29894171b201e1188a3e.squirrel@www.codeaurora.org>
References: <1438037853-14912-1-git-send-email-jilaiw@codeaurora.org>
    <20150728082943.GF16722@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:37286 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751643AbbG2UuD (ORCPT
	<rfc822;linux-arm-msm@vger.kernel.org>);
	Wed, 29 Jul 2015 16:50:03 -0400
In-Reply-To: <20150728082943.GF16722@phenom.ffwll.local>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Jilai Wang <jilaiw@codeaurora.org>, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org

Thanks for this information, Daniel.
I will change it to use rotation prop in next patch.
> On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote:
>> Add plane properties hflip/vflip which are used in MDP driver to flip
>> the input horizontally/vertically.
>>
>> Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>
>
> Is the existing rotation prop with flip masks not enough?
> -Daniel
>
>> ---
>>  Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/DocBook/drm.tmpl
>> b/Documentation/DocBook/drm.tmpl
>> index d9f5613..bef6d34 100644
>> --- a/Documentation/DocBook/drm.tmpl
>> +++ b/Documentation/DocBook/drm.tmpl
>> @@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
>>  	<td valign="top" >TBD</td>
>>  	</tr>
>>  	<tr>
>> -	<td rowspan="3" valign="top" >msm</td>
>> -	<td rowspan="3" valign="top" >Generic</td>
>> +	<td rowspan="5" valign="top" >msm</td>
>> +	<td rowspan="5" valign="top" >Generic</td>
>>  	<td valign="top" >"premultiplied"</td>
>>  	<td valign="top" >ENUM</td>
>>  	<td valign="top" >{ "false", "true" }</td>
>> @@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
>>  	<td valign="top" >Plane</td>
>>  	<td valign="top" >property to set plane's z position during
>> blending</td>
>>  	</tr>
>> +	<tr>
>> +	<td valign="top" >"hflip"</td>
>> +	<td valign="top" >ENUM</td>
>> +	<td valign="top" >{ "off", "on" }</td>
>> +	<td valign="top" >Plane</td>
>> +	<td valign="top" >property to flip the input horizontally</td>
>> +	</tr>
>> +	<tr>
>> +	<td valign="top" >"vflip"</td>
>> +	<td valign="top" >ENUM</td>
>> +	<td valign="top" >{ "off", "on" }</td>
>> +	<td valign="top" >Plane</td>
>> +	<td valign="top" >property to flip the input vertically</td>
>> +	</tr>
>>  	</tbody>
>>  	</table>
>>      </sect2>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>