From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbdCEMQi (ORCPT ); Sun, 5 Mar 2017 07:16:38 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:60018 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752359AbdCEMQh (ORCPT ); Sun, 5 Mar 2017 07:16:37 -0500 Subject: Re: [PATCH v3 3/6] dt-bindings: iio: document interrupt trigger support To: Fabrice Gasnier , linux@armlinux.org.uk, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1488300679-3259-1-git-send-email-fabrice.gasnier@st.com> <1488300679-3259-4-git-send-email-fabrice.gasnier@st.com> Cc: linux-iio@vger.kernel.org, mark.rutland@arm.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net, benjamin.gaignard@linaro.org, benjamin.gaignard@st.com, linus.walleij@linaro.org From: Jonathan Cameron Message-ID: Date: Sun, 5 Mar 2017 12:16:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1488300679-3259-4-git-send-email-fabrice.gasnier@st.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/02/17 16:51, Fabrice Gasnier wrote: > Document interrupt trigger that takes a generic interrupt, and > can be used as trigger source for sampling devices such as sensors, > ADCs... > > Signed-off-by: Fabrice Gasnier I'm not convinced we want the earlier device tree binding doc at all. In the vast majority of cases that chunk on providers is irrelevant. What matters is to document the specific case as you have done here. So this one I like, the earlier document less so, simply because it repeats what this more specific document has described. So Rob, what do you think of 'just' this bit? > --- > .../bindings/iio/trigger/iio-trig-interrupt.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > > diff --git a/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt b/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > new file mode 100644 > index 0000000..9de9856 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > @@ -0,0 +1,22 @@ > +Interrupt based trigger > + > +Any internal or external interrupt may be used as trigger source for > +devices like sensors, ADCs... As an example, external signal can be > +routed to a GPIO, and turned into an interrupt driven trigger. > + > +Required properties: > +- compatible: Should be "interrupt-trigger" > +- interrupts: The interrupt used as trigger. Generic interrupt client node as > + described in ../../interrupt-controller/interrupts.txt > + > +Optional properties: > +- #io-trigger-cells = <0>; See the IIO bindings, IIO trigger providers > + and consumers sections in ../iio-bindings.txt > + > +Example: > + trig0: interrupt-trigger0 { > + #io-trigger-cells = <0>; > + compatible = "interrupt-trigger"; > + interrupts = <11 0>; > + interrupt-parent = <&gpioa>; > + } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH v3 3/6] dt-bindings: iio: document interrupt trigger support Date: Sun, 5 Mar 2017 12:16:28 +0000 Message-ID: References: <1488300679-3259-1-git-send-email-fabrice.gasnier@st.com> <1488300679-3259-4-git-send-email-fabrice.gasnier@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1488300679-3259-4-git-send-email-fabrice.gasnier-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabrice Gasnier , linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, benjamin.gaignard-qxv4g6HH51o@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On 28/02/17 16:51, Fabrice Gasnier wrote: > Document interrupt trigger that takes a generic interrupt, and > can be used as trigger source for sampling devices such as sensors, > ADCs... > > Signed-off-by: Fabrice Gasnier I'm not convinced we want the earlier device tree binding doc at all. In the vast majority of cases that chunk on providers is irrelevant. What matters is to document the specific case as you have done here. So this one I like, the earlier document less so, simply because it repeats what this more specific document has described. So Rob, what do you think of 'just' this bit? > --- > .../bindings/iio/trigger/iio-trig-interrupt.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > > diff --git a/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt b/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > new file mode 100644 > index 0000000..9de9856 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > @@ -0,0 +1,22 @@ > +Interrupt based trigger > + > +Any internal or external interrupt may be used as trigger source for > +devices like sensors, ADCs... As an example, external signal can be > +routed to a GPIO, and turned into an interrupt driven trigger. > + > +Required properties: > +- compatible: Should be "interrupt-trigger" > +- interrupts: The interrupt used as trigger. Generic interrupt client node as > + described in ../../interrupt-controller/interrupts.txt > + > +Optional properties: > +- #io-trigger-cells = <0>; See the IIO bindings, IIO trigger providers > + and consumers sections in ../iio-bindings.txt > + > +Example: > + trig0: interrupt-trigger0 { > + #io-trigger-cells = <0>; > + compatible = "interrupt-trigger"; > + interrupts = <11 0>; > + interrupt-parent = <&gpioa>; > + } > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: jic23@kernel.org (Jonathan Cameron) Date: Sun, 5 Mar 2017 12:16:28 +0000 Subject: [PATCH v3 3/6] dt-bindings: iio: document interrupt trigger support In-Reply-To: <1488300679-3259-4-git-send-email-fabrice.gasnier@st.com> References: <1488300679-3259-1-git-send-email-fabrice.gasnier@st.com> <1488300679-3259-4-git-send-email-fabrice.gasnier@st.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28/02/17 16:51, Fabrice Gasnier wrote: > Document interrupt trigger that takes a generic interrupt, and > can be used as trigger source for sampling devices such as sensors, > ADCs... > > Signed-off-by: Fabrice Gasnier I'm not convinced we want the earlier device tree binding doc at all. In the vast majority of cases that chunk on providers is irrelevant. What matters is to document the specific case as you have done here. So this one I like, the earlier document less so, simply because it repeats what this more specific document has described. So Rob, what do you think of 'just' this bit? > --- > .../bindings/iio/trigger/iio-trig-interrupt.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > > diff --git a/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt b/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > new file mode 100644 > index 0000000..9de9856 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/trigger/iio-trig-interrupt.txt > @@ -0,0 +1,22 @@ > +Interrupt based trigger > + > +Any internal or external interrupt may be used as trigger source for > +devices like sensors, ADCs... As an example, external signal can be > +routed to a GPIO, and turned into an interrupt driven trigger. > + > +Required properties: > +- compatible: Should be "interrupt-trigger" > +- interrupts: The interrupt used as trigger. Generic interrupt client node as > + described in ../../interrupt-controller/interrupts.txt > + > +Optional properties: > +- #io-trigger-cells = <0>; See the IIO bindings, IIO trigger providers > + and consumers sections in ../iio-bindings.txt > + > +Example: > + trig0: interrupt-trigger0 { > + #io-trigger-cells = <0>; > + compatible = "interrupt-trigger"; > + interrupts = <11 0>; > + interrupt-parent = <&gpioa>; > + } >