From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7DBC433E1 for ; Wed, 29 Jul 2020 13:28:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4922E20809 for ; Wed, 29 Jul 2020 13:28:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QShFuS4E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4922E20809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0m8T-0006P2-GF for qemu-devel@archiver.kernel.org; Wed, 29 Jul 2020 09:28:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0m7a-0005XY-5F for qemu-devel@nongnu.org; Wed, 29 Jul 2020 09:27:50 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:20363 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k0m7Y-0001Iq-Jb for qemu-devel@nongnu.org; Wed, 29 Jul 2020 09:27:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596029267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+LiotuYguoZDXMYe0CQ9h6WgQQSLTKS6oqaXWJpKpqs=; b=QShFuS4Ea0Kx/rnzaNHGxqbF9BDbXU2jChxRVVLX8tG2JJdXVUpluKxDbMcosDUgEcXdCn h16qT8s9bqg9173Lr2qMmmFbuhOuWNyOfRISuCUWtI9AoDQahVhxaAaVyF83ZaJ3U5XjuH 86EZxqq15AhZks4mjVVWTgrpE4xxpMw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-335-Po_RiWbPOj63GtSbJc0WTQ-1; Wed, 29 Jul 2020 09:27:43 -0400 X-MC-Unique: Po_RiWbPOj63GtSbJc0WTQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E5858005B0; Wed, 29 Jul 2020 13:27:42 +0000 (UTC) Received: from starship (unknown [10.35.206.108]) by smtp.corp.redhat.com (Postfix) with ESMTP id C08701002393; Wed, 29 Jul 2020 13:27:39 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3 15/18] hw/block/nvme: reject invalid nsid values in active namespace id list From: Maxim Levitsky To: Klaus Jensen , qemu-block@nongnu.org Date: Wed, 29 Jul 2020 16:27:38 +0300 In-Reply-To: <20200706061303.246057-16-its@irrelevant.dk> References: <20200706061303.246057-1-its@irrelevant.dk> <20200706061303.246057-16-its@irrelevant.dk> User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/29 09:27:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Dmitry Fomichev , Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Javier Gonzalez , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 2020-07-06 at 08:13 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Reject the nsid broadcast value (0xffffffff) and 0xfffffffe in the > Active Namespace ID list. > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index fc58f3d76530..af39126cd8d1 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -992,6 +992,16 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeIdentify *c) > > trace_pci_nvme_identify_nslist(min_nsid); > > + /* > + * Both 0xffffffff (NVME_NSID_BROADCAST) and 0xfffffffe are invalid values > + * since the Active Namespace ID List should return namespaces with ids > + * *higher* than the NSID specified in the command. This is also specified > + * in the spec (NVM Express v1.3d, Section 5.15.4). > + */ > + if (min_nsid >= NVME_NSID_BROADCAST - 1) { > + return NVME_INVALID_NSID | NVME_DNR; > + } > + > list = g_malloc0(data_len); > for (i = 0; i < n->num_namespaces; i++) { > if (i < min_nsid) { Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky