All of lore.kernel.org
 help / color / mirror / Atom feed
* Add missing line break in test_verifier
@ 2024-01-25  3:12 Tiezhu Yang
  2024-01-25 21:59 ` Andrii Nakryiko
  0 siblings, 1 reply; 3+ messages in thread
From: Tiezhu Yang @ 2024-01-25  3:12 UTC (permalink / raw)
  To: Andrii Nakryiko; +Cc: bpf

Hi Andrii,

There was a line break at the end of printf() in the original patch [1],
but it is missing with small change in the git tree. Would you be able
to squash below trivial change into the current commit [2]?

diff --git a/tools/testing/selftests/bpf/test_verifier.c 
b/tools/testing/selftests/bpf/test_verifier.c
index e1a1dfe8d7fa..df04bda1c927 100644
--- a/tools/testing/selftests/bpf/test_verifier.c
+++ b/tools/testing/selftests/bpf/test_verifier.c
@@ -1527,7 +1527,7 @@ static void do_test_single(struct bpf_test *test, 
bool unpriv,
         int i, err;

         if ((test->flags & F_NEEDS_JIT_ENABLED) && jit_disabled) {
-               printf("SKIP (requires BPF JIT)");
+               printf("SKIP (requires BPF JIT)\n");
                 skips++;
                 sched_yield();
                 return;

Otherwise, there are no break lines in the test log, like this:

#106/p inline simple bpf_loop call SKIP (requires BPF JIT)#107/p don't 
inline bpf_loop call, flags non-zero SKIP (requires BPF JIT)#108/p don't 
inline bpf_loop call, callback non-constant SKIP (requires BPF 
JIT)#109/p bpf_loop_inline and a dead func SKIP (requires BPF JIT)#110/p 
bpf_loop_inline stack locations for loop vars SKIP (requires BPF 
JIT)#111/p inline bpf_loop call in a big program SKIP (requires BPF 
JIT)#112/p BPF_ST_MEM stack imm non-zero OK

[1] 
https://lore.kernel.org/bpf/20240123090351.2207-3-yangtiezhu@loongson.cn/
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=0b50478fd877

Thanks,
Tiezhu


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Add missing line break in test_verifier
  2024-01-25  3:12 Add missing line break in test_verifier Tiezhu Yang
@ 2024-01-25 21:59 ` Andrii Nakryiko
  2024-01-26  1:39   ` Tiezhu Yang
  0 siblings, 1 reply; 3+ messages in thread
From: Andrii Nakryiko @ 2024-01-25 21:59 UTC (permalink / raw)
  To: Tiezhu Yang; +Cc: Andrii Nakryiko, bpf

On Wed, Jan 24, 2024 at 7:13 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> Hi Andrii,
>
> There was a line break at the end of printf() in the original patch [1],
> but it is missing with small change in the git tree. Would you be able
> to squash below trivial change into the current commit [2]?
>
> diff --git a/tools/testing/selftests/bpf/test_verifier.c
> b/tools/testing/selftests/bpf/test_verifier.c
> index e1a1dfe8d7fa..df04bda1c927 100644
> --- a/tools/testing/selftests/bpf/test_verifier.c
> +++ b/tools/testing/selftests/bpf/test_verifier.c
> @@ -1527,7 +1527,7 @@ static void do_test_single(struct bpf_test *test,
> bool unpriv,
>          int i, err;
>
>          if ((test->flags & F_NEEDS_JIT_ENABLED) && jit_disabled) {
> -               printf("SKIP (requires BPF JIT)");
> +               printf("SKIP (requires BPF JIT)\n");

Yeah, my bad, missed adding \n when fixing up message. I don't think
we can fix this up anymore, would you be able to send this as a proper
patch and we can apply this?

>                  skips++;
>                  sched_yield();
>                  return;
>
> Otherwise, there are no break lines in the test log, like this:
>
> #106/p inline simple bpf_loop call SKIP (requires BPF JIT)#107/p don't
> inline bpf_loop call, flags non-zero SKIP (requires BPF JIT)#108/p don't
> inline bpf_loop call, callback non-constant SKIP (requires BPF
> JIT)#109/p bpf_loop_inline and a dead func SKIP (requires BPF JIT)#110/p
> bpf_loop_inline stack locations for loop vars SKIP (requires BPF
> JIT)#111/p inline bpf_loop call in a big program SKIP (requires BPF
> JIT)#112/p BPF_ST_MEM stack imm non-zero OK
>
> [1]
> https://lore.kernel.org/bpf/20240123090351.2207-3-yangtiezhu@loongson.cn/
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=0b50478fd877
>
> Thanks,
> Tiezhu
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Add missing line break in test_verifier
  2024-01-25 21:59 ` Andrii Nakryiko
@ 2024-01-26  1:39   ` Tiezhu Yang
  0 siblings, 0 replies; 3+ messages in thread
From: Tiezhu Yang @ 2024-01-26  1:39 UTC (permalink / raw)
  To: Andrii Nakryiko; +Cc: Andrii Nakryiko, bpf



On 01/26/2024 05:59 AM, Andrii Nakryiko wrote:
> On Wed, Jan 24, 2024 at 7:13 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>>
>> Hi Andrii,
>>
>> There was a line break at the end of printf() in the original patch [1],
>> but it is missing with small change in the git tree. Would you be able
>> to squash below trivial change into the current commit [2]?
>>
>> diff --git a/tools/testing/selftests/bpf/test_verifier.c
>> b/tools/testing/selftests/bpf/test_verifier.c
>> index e1a1dfe8d7fa..df04bda1c927 100644
>> --- a/tools/testing/selftests/bpf/test_verifier.c
>> +++ b/tools/testing/selftests/bpf/test_verifier.c
>> @@ -1527,7 +1527,7 @@ static void do_test_single(struct bpf_test *test,
>> bool unpriv,
>>          int i, err;
>>
>>          if ((test->flags & F_NEEDS_JIT_ENABLED) && jit_disabled) {
>> -               printf("SKIP (requires BPF JIT)");
>> +               printf("SKIP (requires BPF JIT)\n");
>
> Yeah, my bad, missed adding \n when fixing up message. I don't think
> we can fix this up anymore, would you be able to send this as a proper
> patch and we can apply this?

OK, will do it as soon as possible.

Thanks,
Tiezhu


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-26  1:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-25  3:12 Add missing line break in test_verifier Tiezhu Yang
2024-01-25 21:59 ` Andrii Nakryiko
2024-01-26  1:39   ` Tiezhu Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.