From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbdBNFFM (ORCPT ); Tue, 14 Feb 2017 00:05:12 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34572 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbdBNFFK (ORCPT ); Tue, 14 Feb 2017 00:05:10 -0500 Subject: Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean To: Nicholas Mc Guire , Cyrille Pitchen References: <1486973636-1117-1-git-send-email-der.herr@hofr.at> Cc: David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger , Mika Westerberg , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: Date: Tue, 14 Feb 2017 05:52:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1486973636-1117-1-git-send-email-der.herr@hofr.at> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/13/2017 09:13 AM, Nicholas Mc Guire wrote: > writeable in struct intel_spi is a boolean and assignment should be to > true/false not 1/0 as recommended by boolinit.cocci. > > Signed-off-by: Nicholas Mc Guire > --- > > make coccicheck complained with: > ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1 > > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y) > > Patch is against 4.10-rc7 (localversion-next is next-20170213) > > drivers/mtd/spi-nor/intel-spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c > index 4630716..2956f2c 100644 > --- a/drivers/mtd/spi-nor/intel-spi.c > +++ b/drivers/mtd/spi-nor/intel-spi.c > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi, > * whole partition read-only to be on the safe side. > */ > if (intel_spi_is_protected(ispi, base, limit)) > - ispi->writeable = 0; > + ispi->writeable = false; > > end = (limit << 12) + 4096; > if (end > part->size) > Looks OK, also this is the only place in the driver where writeable is assigned to an explicit true/false value. Acked-by: Marek Vasut btw the variable should be renamed from writeable to writable ;-) -- Best regards, Marek Vasut