[PATCH] infiniband/qib: drop qib_pci_link_reset()

[PATCH] infiniband/qib: drop qib_pci_link_reset()

[Cao jin]

In AER recovery, pci_error_handlers.link_reset() is never called,
drop it now.

Signed-off-by: Cao jin <caoj.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 drivers/infiniband/hw/qib/qib_pcie.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c
index 6abe1c621aa4..c379b8342a09 100644
--- a/drivers/infiniband/hw/qib/qib_pcie.c
+++ b/drivers/infiniband/hw/qib/qib_pcie.c
@@ -682,13 +682,6 @@ qib_pci_slot_reset(struct pci_dev *pdev)
 	return PCI_ERS_RESULT_CAN_RECOVER;
 }
 
-static pci_ers_result_t
-qib_pci_link_reset(struct pci_dev *pdev)
-{
-	qib_devinfo(pdev, "QIB link_reset function called, ignored\n");
-	return PCI_ERS_RESULT_CAN_RECOVER;
-}
-
 static void
 qib_pci_resume(struct pci_dev *pdev)
 {
@@ -707,7 +700,6 @@ qib_pci_resume(struct pci_dev *pdev)
 const struct pci_error_handlers qib_pci_err_handler = {
 	.error_detected = qib_pci_error_detected,
 	.mmio_enabled = qib_pci_mmio_enabled,
-	.link_reset = qib_pci_link_reset,
 	.slot_reset = qib_pci_slot_reset,
 	.resume = qib_pci_resume,
 };
-- 
2.1.0



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] infiniband/hfil: drop pci_link_reset()

[Cao jin]

In AER recovery, pci_error_handlers.link_reset() is never called,
drop it now.

Signed-off-by: Cao jin <caoj.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
---
 drivers/infiniband/hw/hfi1/pcie.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/pcie.c b/drivers/infiniband/hw/hfi1/pcie.c
index 89c68da1c273..8aed2a8a378b 100644
--- a/drivers/infiniband/hw/hfi1/pcie.c
+++ b/drivers/infiniband/hw/hfi1/pcie.c
@@ -599,15 +599,6 @@ pci_slot_reset(struct pci_dev *pdev)
 	return PCI_ERS_RESULT_CAN_RECOVER;
 }
 
-static pci_ers_result_t
-pci_link_reset(struct pci_dev *pdev)
-{
-	struct hfi1_devdata *dd = pci_get_drvdata(pdev);
-
-	dd_dev_info(dd, "HFI1 link_reset function called, ignored\n");
-	return PCI_ERS_RESULT_CAN_RECOVER;
-}
-
 static void
 pci_resume(struct pci_dev *pdev)
 {
@@ -626,7 +617,6 @@ pci_resume(struct pci_dev *pdev)
 const struct pci_error_handlers hfi1_pci_err_handler = {
 	.error_detected = pci_error_detected,
 	.mmio_enabled = pci_mmio_enabled,
-	.link_reset = pci_link_reset,
 	.slot_reset = pci_slot_reset,
 	.resume = pci_resume,
 };
-- 
2.1.0



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] infiniband/hfil: drop pci_link_reset()

[Dennis Dalessandro]

On 12/19/2016 01:46 AM, Cao jin wrote:
> In AER recovery, pci_error_handlers.link_reset() is never called,
> drop it now.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>

Is this part of a larger patch series? If the function is never called 
it should be removed from struct pci_error_handlers should it not? Then 
in the same series be removed from all the drivers.

Probably should check with the folks on linux-pci about this though.

-Denny

Re: [PATCH] infiniband/hfil: drop pci_link_reset()

[Cao jin]

On 12/19/2016 11:54 PM, Dennis Dalessandro wrote:
> On 12/19/2016 01:46 AM, Cao jin wrote:
>> In AER recovery, pci_error_handlers.link_reset() is never called,
>> drop it now.
>>
>> Signed-off-by: Cao jin <caoj.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> 
> Is this part of a larger patch series?

Not now.

> If the function is never called
> it should be removed from struct pci_error_handlers should it not? Then
> in the same series be removed from all the drivers.

Maybe we can remove the unnecessary implementation in each device first,
if finally pci guys confirmed that .link_reset could be removed, then we
could removed it in the future, not quite necessary to place them into
the same series. But it is also good hear their voice first.

-- 
Sincerely,
Cao jin

> 
> Probably should check with the folks on linux-pci about this though.
> 
> -Denny
> 
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] infiniband/hfil: drop pci_link_reset()

[Cao jin]

On 12/19/2016 11:54 PM, Dennis Dalessandro wrote:
> On 12/19/2016 01:46 AM, Cao jin wrote:
>> In AER recovery, pci_error_handlers.link_reset() is never called,
>> drop it now.
>>
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> 
> Is this part of a larger patch series?

Not now.

> If the function is never called
> it should be removed from struct pci_error_handlers should it not? Then
> in the same series be removed from all the drivers.

Maybe we can remove the unnecessary implementation in each device first,
if finally pci guys confirmed that .link_reset could be removed, then we
could removed it in the future, not quite necessary to place them into
the same series. But it is also good hear their voice first.

-- 
Sincerely,
Cao jin

> 
> Probably should check with the folks on linux-pci about this though.
> 
> -Denny
> 
> 
> 
> 

Re: [PATCH] infiniband/qib: drop qib_pci_link_reset()

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

On Mon, 2016-12-19 at 14:46 +0800, Cao jin wrote:
> In AER recovery, pci_error_handlers.link_reset() is never called,
> drop it now.
> 
> Signed-off-by: Cao jin <caoj.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
> 

Thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] infiniband/hfil: drop pci_link_reset()

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

On Mon, 2016-12-19 at 14:46 +0800, Cao jin wrote:
> In AER recovery, pci_error_handlers.link_reset() is never called,
> drop it now.
> 
> Signed-off-by: Cao jin <caoj.fnst-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>

Thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]