From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46006) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d43CC-0000ph-2s for qemu-devel@nongnu.org; Fri, 28 Apr 2017 06:32:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d43C7-0004Zz-6t for qemu-devel@nongnu.org; Fri, 28 Apr 2017 06:32:16 -0400 Received: from mail-wr0-x22e.google.com ([2a00:1450:400c:c0c::22e]:33525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d43C6-0004ZO-Uo for qemu-devel@nongnu.org; Fri, 28 Apr 2017 06:32:11 -0400 Received: by mail-wr0-x22e.google.com with SMTP id w50so31373952wrc.0 for ; Fri, 28 Apr 2017 03:32:10 -0700 (PDT) Sender: Richard Henderson References: <20170427120006.20564-1-rth@twiddle.net> <20170427120006.20564-6-rth@twiddle.net> <87wpa47rlx.fsf@linaro.org> From: Richard Henderson Message-ID: Date: Fri, 28 Apr 2017 12:32:06 +0200 MIME-Version: 1.0 In-Reply-To: <87wpa47rlx.fsf@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v5 05/19] tcg-runtime: add lookup_tb_ptr helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= Cc: qemu-devel@nongnu.org, cota@braap.org On 04/28/2017 12:29 PM, Alex Bennée wrote: >> + return tcg_ctx.code_gen_epilogue; > > Minor comments: I did notice is given we rely on the backends to set this up > in later patches if it is worth adding an assert (or tcg_debug_assert?) > to catch this early if a new backend doesn't set this up? Sure, I can check for this in tcg_prologue_init and a faulty backend will die very early. r~